- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jun 19 2018
Jun 18 2018
Jun 5 2018
May 29 2018
May 25 2018
May 22 2018
May 18 2018
In D13063#308254, @marius wrote:In any case, I think support for busses is a must for MMCCAM due to eSD. Judging Linux code and commit messages I've read, designs with multiple eSDIO devices on a bus are real.
Mar 11 2018
In D13064#307569, @markj wrote:In D13064#307542, @kibab wrote:In D13064#299460, @markj wrote:In D13064#299426, @benno wrote:Have you looked at markj's netdump branch? Would his lower-level UDP send routines be a better transport for the console messages?
That code is specifically designed to run after a panic, while this is not. Ideally netcons would be usable in either context, but I wouldn't consider that to be a gating feature.
Actually I need precisely that! Running UDP send after panic would help to see a panic message. What is the purpose of netdump branch, what are you developing there?
The aim is to make it possible to transmit kernel dumps after a panic. See the netdump.4 and dumpon.8 man pages in that branch. I've been meaning to get it into FreeBSD for a long time and would rather not hold it up to add new features now, as I'm basically ready to get it reviewed and merged, but I'd be happy to work on refactoring it for use by other subsystems afterwards.
Marius,
thanks for your review.
I have created separate issues for each of the point you've mentioned: https://github.com/kibab/freebsd/projects/1
Seems none of those are directly related to the scope of this particular change. Do you think it's fine to commit this code so that partition functionality is in -HEAD?
Mar 10 2018
So, as I wrote in reply to the inline comment, supporting multiple MMC cards on the same bus is not something I would try to implement in the new stack, given that I have never seen any hardware with such setup and that the old stack AFAIK doesn't properly support this.
Apart from that, any comments?
In D13063#276864, @marius wrote:In D13063#271753, @kibab wrote:RCA = 2 is just because I need to send _some_ RCA to the card. So I chose to send 2, could also choose any other number :-)
Unlike SD prior to eSD, MMC is a bus which may have multiple children that in case of MMC require unique RCAs to be assigned. So while you may start with 2 for the first child, you need code which increments the RCA for additional children on the same bus.
In D13064#303809, @cem wrote:Haven't done a thorough review, but will take another look when some of the outstanding issues are cleaned up.
In D13064#299460, @markj wrote:In D13064#299426, @benno wrote:Have you looked at markj's netdump branch? Would his lower-level UDP send routines be a better transport for the console messages?
That code is specifically designed to run after a panic, while this is not. Ideally netcons would be usable in either context, but I wouldn't consider that to be a gating feature.
This was added in r330674 by manu@
Jan 19 2018
This change LGTM, I would like to know how this was discovered?
Nov 14 2017
Address review comments
Nov 13 2017
RCA = 2 is just because I need to send _some_ RCA to the card. So I chose to send 2, could also choose any other number :-)
Address review comments
Nov 12 2017
Hi Marius, thank you very much for such a verbose review!
I have addressed most of your comments. As for the remaining ones -- they require some more work which I'd like to do in the upcoming changes. As all my work should be reviewed by Warner before committing, I'd like to try to keep the diff sizes under certain limit.
Address review comments
Oct 28 2017
In D12762#264842, @marius wrote:Well, IMO committing the partition identification code only with all the glory details yet to be done is premature, even for head.
Generally: Please adhere to style(9).
void function shouldn'r return a value, remove sdda_hook_into_geom()
Actually implement partitions support
Oct 22 2017
Oct 9 2017
Properly do attachment of child devices
Oct 8 2017
newbus attach musings
Sep 24 2017
Sep 23 2017
Superceded by D12471 that provides more generic way of adding MMCCAM support to SDHCI drivers.
Sep 22 2017
Sep 18 2017
Added licenses for the code from Broadcom
Added files lost in the process of doing git rebase magic. PTAL
Sep 15 2017
Sep 13 2017
Sep 11 2017
Sep 10 2017
Use tabs, not spaces, in calendar file
Include caldndar.freebsd modifications here
Aug 29 2017
Renamed kernel conf for amd64 and fixes whitespaces
Removed device mmccam, added NO_UNIVERSE
Removed device mmccam, added NO_UNIVERSE
In D12114#251451, @lifanov wrote:Is it better to just call it MMCCAM instead of GENERIC-MMCCAM?
Aug 24 2017
This is an ancient sh*t and nobody cares.
Removed arm64-related part
Aug 23 2017
- Updating D12110: Add MMCCAM-enabled kernel config for IMX6 and arm64 #
- Enter a brief description of the changes included in this update.
- The first line is used as subject, next lines as comment. #
- If you intended to create a new revision, use:
- $ arc diff --create
Aug 5 2017
This was merged with some modifications.
Jul 17 2017
Mar 17 2016
I have started to cleanup my diff. This upload removes excessive kernel config files and fixes issues with alphabetical ordering in several places. So, no functional changes at all.