Page MenuHomeFreeBSD
Feed Search

Jun 21 2026

seuros added inline comments to D57685: fwcam: add IIDC 1394 FireWire camera driver.
Jun 21 2026, 9:45 PM · firewire
adrian accepted D57728: firewire: NULL check on malloc in fw_busreset().
Jun 21 2026, 8:32 PM · drivers, firewire
seuros added a reviewer for D57728: firewire: NULL check on malloc in fw_busreset(): firewire.
Jun 21 2026, 8:22 PM · drivers, firewire
ziaee added inline comments to D57685: fwcam: add IIDC 1394 FireWire camera driver.
Jun 21 2026, 8:19 PM · firewire
adrian accepted D57685: fwcam: add IIDC 1394 FireWire camera driver.

in general this looks fine! thanks!

Jun 21 2026, 8:14 PM · firewire
adrian accepted D57617: if_fwsubr: remove ARP target hardware address trimming.
Jun 21 2026, 8:10 PM · network, drivers, firewire
adrian added a comment to D57617: if_fwsubr: remove ARP target hardware address trimming.

ok, if you have tested it between macosx and linux and freebsd then that's good enough for me.

Jun 21 2026, 8:10 PM · network, drivers, firewire
seuros added a comment to D57617: if_fwsubr: remove ARP target hardware address trimming.

Did you check interoperability vs OS X or Linux? If this change is correct then firewire interface was not functional for many years and nobody noticed that. This raises question on whether it needs to be kept in FreeBSD at all.

AFAIK, the only real firewire application today is dumping data from old but expensive professional video cameras.

Jun 21 2026, 2:12 PM · network, drivers, firewire
glebius added a comment to D57617: if_fwsubr: remove ARP target hardware address trimming.

This code originates from the very beginning of firewire and it is not a copy from ether_output().

Jun 21 2026, 1:37 PM · network, drivers, firewire
glebius added a comment to D57617: if_fwsubr: remove ARP target hardware address trimming.

Did you check interoperability vs OS X or Linux? If this change is correct then firewire interface was not functional for many years and nobody noticed that. This raises question on whether it needs to be kept in FreeBSD at all.

Jun 21 2026, 1:30 PM · network, drivers, firewire

Jun 19 2026

seuros updated the diff for D57685: fwcam: add IIDC 1394 FireWire camera driver.

remove bring-up debug logging.

Jun 19 2026, 9:46 PM · firewire
seuros updated the diff for D57685: fwcam: add IIDC 1394 FireWire camera driver.

address doc lint

Jun 19 2026, 9:20 PM · firewire
ziaee added inline comments to D57685: fwcam: add IIDC 1394 FireWire camera driver.
Jun 19 2026, 8:46 PM · firewire
seuros added reviewers for D57685: fwcam: add IIDC 1394 FireWire camera driver: firewire, ziaee.
Jun 19 2026, 8:42 PM · firewire
seuros added a reviewer for D57684: firewire: add shared helpers for ISO receive drivers: firewire.
Jun 19 2026, 8:38 PM · firewire
adrian closed D57615: firewire: extract shared helpers from fwe and fwip.
Jun 19 2026, 7:01 PM · firewire

Jun 18 2026

ngie added a comment to D57617: if_fwsubr: remove ARP target hardware address trimming.

Were there any RFCs that superseded the one referenced?

No, if it were, it would be mentioned, like this one:
https://datatracker.ietf.org/doc/html/rfc2460 (look for "Obsoleted by" or "Updated by")

Jun 18 2026, 11:53 PM · network, drivers, firewire
pouria added a comment to D57617: if_fwsubr: remove ARP target hardware address trimming.

Were there any RFCs that superseded the one referenced?

Jun 18 2026, 11:39 PM · network, drivers, firewire
ngie added a comment to D57617: if_fwsubr: remove ARP target hardware address trimming.

Some other research I just did.

Jun 18 2026, 11:30 PM · network, drivers, firewire
ngie updated subscribers of D57617: if_fwsubr: remove ARP target hardware address trimming.

@bz, @glebius, @melifaro, etc: can you help confirm that this is change is correct?

Jun 18 2026, 10:52 PM · network, drivers, firewire
ngie added a project to D57617: if_fwsubr: remove ARP target hardware address trimming: network.
Jun 18 2026, 10:51 PM · network, drivers, firewire
seuros updated subscribers of D57617: if_fwsubr: remove ARP target hardware address trimming.

No, I just necromanced into code that was idle for 22 years. The AF_ARP case was copied from if_ethersubr.c when @dfr added if_fwsubr.c in 2004.

Jun 18 2026, 9:29 PM · network, drivers, firewire
adrian updated subscribers of D57617: if_fwsubr: remove ARP target hardware address trimming.
Jun 18 2026, 8:46 PM · network, drivers, firewire
adrian added a comment to D57617: if_fwsubr: remove ARP target hardware address trimming.

wait, did this change at some point?

Jun 18 2026, 8:45 PM · network, drivers, firewire
imp accepted D57615: firewire: extract shared helpers from fwe and fwip.
Jun 18 2026, 8:13 PM · firewire

Jun 17 2026

seuros updated the test plan for D57617: if_fwsubr: remove ARP target hardware address trimming.
Jun 17 2026, 5:15 PM · network, drivers, firewire
adrian added a project to D57615: firewire: extract shared helpers from fwe and fwip: firewire.
Jun 17 2026, 2:59 AM · firewire

Jun 8 2026

seuros added a comment to D57459: fix(fwe): add missing net epoch around ether_input.

Apple Computers (Imacs, MacMini, Laptops), Lenovo T61p, Startech, SIIG, LACIE.

Jun 8 2026, 8:13 PM · firewire, network
glebius added a comment to D57459: fix(fwe): add missing net epoch around ether_input.

Out of curiosity: what hardware do you use to encounter this bug? Is it legacy (about 15 year old) mainboard or is it something new like https://www.startech.com/en-us/cards-adapters/firewire?

Jun 8 2026, 5:17 PM · firewire, network
adrian closed D57496: firewire: Fix watchdog_clock aliasing and fw_tl2xfer UAF race.
Jun 8 2026, 2:34 PM · drivers, firewire
zlei retitled D57496: firewire: Fix watchdog_clock aliasing and fw_tl2xfer UAF race from fix(firewire): fix watchdog_clock aliasing and fw_tl2xfer UAF race
Jun 8 2026, 7:38 AM · drivers, firewire
zlei retitled D57495: fwip: Fix M_PKTHDR loss in fwip_async_output broadcast path from fix(fwip): fix M_PKTHDR loss in fwip_async_output broadcast path
Jun 8 2026, 7:37 AM · drivers, firewire
zlei accepted D57496: firewire: Fix watchdog_clock aliasing and fw_tl2xfer UAF race.

The part watchdog_clock of this change looks good to me.

Jun 8 2026, 7:36 AM · drivers, firewire
zlei accepted D57495: fwip: Fix M_PKTHDR loss in fwip_async_output broadcast path.

Looks sane to me.

Jun 8 2026, 6:45 AM · drivers, firewire
adrian accepted D57496: firewire: Fix watchdog_clock aliasing and fw_tl2xfer UAF race.

This broadly looks good to me but I am currently unable to test it.

Jun 8 2026, 4:34 AM · drivers, firewire
seuros added inline comments to D57496: firewire: Fix watchdog_clock aliasing and fw_tl2xfer UAF race.
Jun 8 2026, 4:19 AM · drivers, firewire
adrian added inline comments to D57496: firewire: Fix watchdog_clock aliasing and fw_tl2xfer UAF race.
Jun 8 2026, 3:55 AM · drivers, firewire
adrian accepted D57495: fwip: Fix M_PKTHDR loss in fwip_async_output broadcast path.
Jun 8 2026, 3:54 AM · drivers, firewire
adrian added a comment to D57495: fwip: Fix M_PKTHDR loss in fwip_async_output broadcast path.

oh good catch!

Jun 8 2026, 3:53 AM · drivers, firewire
seuros added a reviewer for D57496: firewire: Fix watchdog_clock aliasing and fw_tl2xfer UAF race: zlei.
Jun 8 2026, 3:39 AM · drivers, firewire
seuros added a reviewer for D57495: fwip: Fix M_PKTHDR loss in fwip_async_output broadcast path: zlei.
Jun 8 2026, 3:38 AM · drivers, firewire
adrian added a comment to D57459: fix(fwe): add missing net epoch around ether_input.

hm, good question, should we do it per frame or in batches?

A bit late to see this patch.

The NET_EPOCH_ENTER() / NET_EPOCH_EXIT() is a bit heavy weight on every packet. For high speed hardware you want to batch input the packets. For firewire I think it is not a high speed hardware so that ( batch input ) probably make no noticeable difference.

Jun 8 2026, 3:01 AM · firewire, network
zlei added a comment to D57459: fix(fwe): add missing net epoch around ether_input.

hm, good question, should we do it per frame or in batches?

Jun 8 2026, 2:50 AM · firewire, network

Jun 7 2026

seuros added projects to D57495: fwip: Fix M_PKTHDR loss in fwip_async_output broadcast path: firewire, drivers.
Jun 7 2026, 3:17 PM · drivers, firewire
adrian added projects to D57496: firewire: Fix watchdog_clock aliasing and fw_tl2xfer UAF race: firewire, drivers.
Jun 7 2026, 3:08 PM · drivers, firewire

Jun 6 2026

adrian closed D57466: firewire: clean up XXX comments.
Jun 6 2026, 8:18 PM · firewire
adrian closed D57459: fix(fwe): add missing net epoch around ether_input.
Jun 6 2026, 8:18 PM · firewire, network
adrian accepted D57466: firewire: clean up XXX comments.

i'll approve this assuming you've tested it on amd64; I'll update my g5 mac w/ firewire and test it later.

Jun 6 2026, 8:12 PM · firewire
adrian accepted D57459: fix(fwe): add missing net epoch around ether_input.
Jun 6 2026, 8:07 PM · firewire, network
adrian added a project to D57459: fix(fwe): add missing net epoch around ether_input: firewire.
Jun 6 2026, 7:59 PM · firewire, network
adrian added a project to D57466: firewire: clean up XXX comments: firewire.
Jun 6 2026, 7:58 PM · firewire
pi set the icon for firewire to Tag.
Jun 6 2026, 7:48 PM
pi created firewire.
Jun 6 2026, 7:43 PM