in general this looks fine! thanks!
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Jun 21 2026
ok, if you have tested it between macosx and linux and freebsd then that's good enough for me.
In D57617#1323362, @glebius wrote:Did you check interoperability vs OS X or Linux? If this change is correct then firewire interface was not functional for many years and nobody noticed that. This raises question on whether it needs to be kept in FreeBSD at all.
AFAIK, the only real firewire application today is dumping data from old but expensive professional video cameras.
This code originates from the very beginning of firewire and it is not a copy from ether_output().
Did you check interoperability vs OS X or Linux? If this change is correct then firewire interface was not functional for many years and nobody noticed that. This raises question on whether it needs to be kept in FreeBSD at all.
Jun 19 2026
remove bring-up debug logging.
address doc lint
Jun 18 2026
In D57617#1321866, @pouria wrote:In D57617#1321864, @ngie wrote:Were there any RFCs that superseded the one referenced?
No, if it were, it would be mentioned, like this one:
https://datatracker.ietf.org/doc/html/rfc2460 (look for "Obsoleted by" or "Updated by")
In D57617#1321864, @ngie wrote:Were there any RFCs that superseded the one referenced?
Some other research I just did.
No, I just necromanced into code that was idle for 22 years. The AF_ARP case was copied from if_ethersubr.c when @dfr added if_fwsubr.c in 2004.
wait, did this change at some point?
Jun 17 2026
Jun 8 2026
Apple Computers (Imacs, MacMini, Laptops), Lenovo T61p, Startech, SIIG, LACIE.
Out of curiosity: what hardware do you use to encounter this bug? Is it legacy (about 15 year old) mainboard or is it something new like https://www.startech.com/en-us/cards-adapters/firewire?
The part watchdog_clock of this change looks good to me.
Looks sane to me.
This broadly looks good to me but I am currently unable to test it.
oh good catch!
In D57459#1317325, @zlei wrote:In D57459#1316924, @adrian wrote:hm, good question, should we do it per frame or in batches?
A bit late to see this patch.
The NET_EPOCH_ENTER() / NET_EPOCH_EXIT() is a bit heavy weight on every packet. For high speed hardware you want to batch input the packets. For firewire I think it is not a high speed hardware so that ( batch input ) probably make no noticeable difference.
In D57459#1316924, @adrian wrote:hm, good question, should we do it per frame or in batches?
Jun 7 2026
Jun 6 2026
i'll approve this assuming you've tested it on amd64; I'll update my g5 mac w/ firewire and test it later.