In D12793#274236, @lifanov wrote:

OK, this works now and looks pretty good.
Can you consider making some configuration files @sample?
https://www.freebsd.org/doc/en/books/porters-handbook/book.html#plist-config

There are two steps to it:

1. install the file with .sample suffix (like arangod.conf.sample)
2. list it with @sample in pkg-plist:

@sample %%ETCDIR%%/arangod.conf.sample

When pkg installs a package with @sample entries, these get copied to the correct location if the files are missing
and then the user can modify the configuration files without causing checksum mismatches and without the files
being clobbered on package update.

Install configuration files as samples.

OK, this works now and looks pretty good.
Can you consider making some configuration files @sample?
https://www.freebsd.org/doc/en/books/porters-handbook/book.html#plist-config

Update the arangodb user directory

In D12793#274211, @lifanov wrote:

This doesn't build for me:

/work/stage/usr/local/share/arangodb/js/server/bootstrap/coordinator-database.js
CMake Error at cmake_install.cmake:87 (file):
  file INSTALL cannot find
  "/usr/home/lifanov/src/svn/freebsd/ports/head/databases/arangodb32/work/.build/var/log/arangodb3".
gmake[1]: *** [Makefile:99: install/strip] Error 1

Add the cmake patch

This doesn't build for me:

/work/stage/usr/local/share/arangodb/js/server/bootstrap/coordinator-database.js
CMake Error at cmake_install.cmake:87 (file):
  file INSTALL cannot find
  "/usr/home/lifanov/src/svn/freebsd/ports/head/databases/arangodb32/work/.build/var/log/arangodb3".
gmake[1]: *** [Makefile:99: install/strip] Error 1

Update maintainer address.

Update to 3.2.8

In D12793#270047, @lifanov wrote:

In D12793#269311, @dev_dudu.ro wrote:

In D12793#268412, @lifanov wrote:

This looks pretty good, but %%DATADIR%%3 and %%DOCSDIR%%3 in pkg-plist should really be directories.
Can you consider configuring these to match the port name or maybe swithing the portname to arangodb3?

I'm not sure I understand what you mean - should I replace them with the actual final value - e.g. /usr/local/share, or add @dir entries for them to pkg-plist?

The directory that gets installed is /usr/local/share/arangodb3, which suggests that PORTNAME should be agangodb3?
There are several other places where arangodb3 name gets used. Example:

: ${arangod_dbpath="/var/db/arangodb3"}
: ${arangod_logpath="/var/log/arangodb3"}
: ${arangod_apppath="/var/db/arangodb3-apps"}

As for the renaming bit I was thinking of following the mongodbXY port convention and eventually add an arangodb33 port that is set to conflict with the arangodb32 port. Thoughts?

Versioning it like mongodbXY is a good idea in general, but it is useful if the two versions are incompatible or require special upgrade/migration steps (like postgresql).
Another consideration is how long do you expect people to run arangodb 3.2 once 3.3 is realeased.

Thanks!

Updated to 3.2.7
Addressed reviewer comments

In D12793#269311, @dev_dudu.ro wrote:

In D12793#268412, @lifanov wrote:

This looks pretty good, but %%DATADIR%%3 and %%DOCSDIR%%3 in pkg-plist should really be directories.
Can you consider configuring these to match the port name or maybe swithing the portname to arangodb3?

I'm not sure I understand what you mean - should I replace them with the actual final value - e.g. /usr/local/share, or add @dir entries for them to pkg-plist?

In D12793#268412, @lifanov wrote:

This looks pretty good, but %%DATADIR%%3 and %%DOCSDIR%%3 in pkg-plist should really be directories.
Can you consider configuring these to match the port name or maybe swithing the portname to arangodb3?

This looks pretty good, but %%DATADIR%%3 and %%DOCSDIR%%3 in pkg-plist should really be directories.
Can you consider configuring these to match the port name or maybe swithing the portname to arangodb3?

Remove git dependency and add python dependency

Move USE_GITHUB to its rightful place.

Simplify the man page moving logic

Do not explicitly gzip man pages.

In D12793#265614, @lifanov wrote:

I can see in the build system that some components are hard to decouple.
Try decoupling what you can, like boost or libcurl.

I can see in the build system that some components are hard to decouple.
Try decoupling what you can, like boost or libcurl.

In D12793#265567, @lifanov wrote:

How did you generate pkg-plist? The files listed in it are already relative to LOCALBASE and @dir should only specify directories that are empty.
The "make makeplist" target should generate a pkg-plist close to what you want, so then you need to review it and make any manual changes you need.

Silenced stage-qa and check-orphans.

Could you also try running "make stage-qa" and "make check-orphans" please and make sure these are clean?

How did you generate pkg-plist? The files listed in it are already relative to LOCALBASE and @dir should only specify directories that are empty.
The "make makeplist" target should generate a pkg-plist close to what you want, so then you need to review it and make any manual changes you need.

Hi and welcome to FreeBSD!

Committed revision 447973.

Update with some review from gerald@

updated patch from Danilo, sync with PR

Change according to feedback: instead of creating a -cgx part, only split away the ccx part. his is less confusing for end users and still attains our objective of constraining the fortran part in an independent port.
It also reduces the diffs.

thanks Mat... new PR created;
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220674

empty line added as suggested

Looks ok, feel free to submit a PR to get this committed.

osversion conditional moved up a touch

changes made as suggested by Mat with thanks....

conditional added to fix build issue on 11.0-RELEASE (clang fails)

oh no... doesn't look like it's building on 11.0-RELEASE clang.
It does build on 11.1 RC2 (that also has the required fuse changes)

new diff as per Mat's request (using the svn diff -x -U9999)

Could you upload the diff with arcanist arc diff --update D11550 ? Or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

make makepatch renamed some of the patches (underscore instead of hyphen)
diff now captures that change

diff's broke in stage-qa:

root@condor:/usr/ports/net/glusterfs # portlint -C
WARN: Makefile: [5]: whitespace before end of line.
WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support.
WARN: Makefile: possible use of absolute pathname "/boot/modules".
WARN: Consider to set DEVELOPER=yes in /etc/make.conf
0 fatal errors and 4 warnings found.

used make makepatch to correctly recreate the files/patches after first applying patch -b -p0 to a vanilla make extract.

In D10554#219975, @rfyu28uyeg_snkmail.com wrote:

If that is preferred over shebangfix in-place changes in STAGEDIR and a reduced footprint, I'll work up a patch for print/tex-xetex to do that and drop the shebangfix.mk patch.

In D10554#219970, @mat wrote:

And if all this is only to fix the couple of ports that extract their distfiles directly in STAGEDIR during install, I think those should be fixed instead, not the framework.

In D10554#219965, @mat wrote:

This makes the shebangfix.mk code a lot more complicated.

In D10554#219966, @mat wrote:

As a side note, if you need to "patch" shebangs after the build process has run, you are doing it wrong, you should provide the correct path, or patch the build process so that the correct shebangs are generated.

I tend to agree with @mat on this

And if all this is only to fix the couple of ports that extract their distfiles directly in STAGEDIR during install, I think those should be fixed instead, not the framework.

As a side note, if you need to "patch" shebangs after the build process has run, you are doing it wrong, you should provide the correct path, or patch the build process so that the correct shebangs are generated.

This makes the shebangfix.mk code a lot more complicated.

Added updates to three ports affected by the prospective changes to shebangfix.mk

The latest diff is strange.

New diff with support of LXQt 0.11.0.

Great, please go ahead.

Requests fulfilled.

Sorry, I see why your PKGNAMESUFFIX change was made. I don't have strong feelings on it, so I'll leave it up to you :)

Please see my inline comments, but if mine and Bryan's are followed, please consider it approved by me.

@bdrewery, so lines 77-85 should be replaced with the following. Anything else that needs to be done to get this committed?

In D5816#129668, @cs wrote:

Is there any reason you add the COPYING file in games/ioquake3/Makefile and games/openarena-oax/Makefile?

In D5744#129684, @cs wrote:

Don't use the current date as the date of the version. Use the date of the actual commit as the version number.

Use the latest commit date for the version suffix.

Don't use the current date as the date of the version. Use the date of the actual commit as the version number.

Is there any reason you add the COPYING file in games/ioquake3/Makefile and games/openarena-oax/Makefile?

Add a can of bsd.options.mk fu.

Removed the obsolete plist target.

Add diff created by arcanist.

Add long patch that shows all the context.

Could you upload a diff generated with:

Could you upload a diff generated with: