Going to update this to be applicable to HEAD after some build test. Some of this review has been committed by various folks.

Thank you! Already on github: https://github.com/freebsd/freebsd/commit/2a1c75d8f2f60bf398ad401e6cde49562f938564. Time to rebase ;)

Yes, I was planning to commit it on Wednesday if I get a chance, but wouldn't mind if someone else does it in the meantime...

does this still need committing?

I’m fine with this patch unless you consider it as quick recovery from damage caused by r304459.
But, current usage of INTRNG on MIPS platform is still little ‘non-standard’ and I thing that MIPS needs more love in this area.

In D7692#160754, @adrian wrote:

(Eg, it needs a bunch more testing on non-FDT, non-INTRNG platforms, but I bet that's going to be easy..)

ok, cool. commit it and we'll shake out any other issues afterwards. :)

The updated diff also fixes additional problems seen on Broadcom MIPS (INTRNG without FDT) as a result of the r304459 changes. The new diff was boot tested by mizhka.

This looks good to me.

Quick check on Broadcom 4716.

Provide more diff context

nathan, what do you think about this? it's fallout from the last intrng change.

In D7692#160205, @adrian wrote:

Hm, can you get someone who does FDT stuff on #bsdmips to look at this?

Hm, can you get someone who does FDT stuff on #bsdmips to look at this?

Previous diff was not compiling for BCM kernel config, as BCM only uses INTRNG but not FDT.
Rework the fix, so that cpu_establish_[hard|soft]intr uses a different intr mapping strategy, which doesn't require FDT-specific data to be exposed to non-FDT kernels.

Update for ARM64 and MIPS.

Update diff

Updated diffs upon suggestions from adrian and bsdimp.

talk to warner (bsdimp) about the right way to do the kernel config stuff. the XXX_BASE stuff was me abstracting out config files in the atheros mips world before it got too bad. It's not the "right" way. Ask him what the right way is!

This uses the read/write macros in a novel way (register ids, not register addresses) but I think it's fine.

Update diffs. The only change now is changing '#include <fbsd-*>' to '/include/ "fbsd-*"' in the base SoC dtsi files.

OK. I'll do this tomorrow.

I mean, can't we have the ofw probe routine check the normal device list, rather than compat data?

In D5993#127869, @adrian wrote:

surely the flash DTS stuff could be modified to probe the flash_ident array, based on the names?

surely the flash DTS stuff could be modified to probe the flash_ident array, based on the names?

Choose correct repo

Yeah, I think we should break this out into something in sys/kern/ that we can optionally include where appropriate.

ooo!