In D26961#602872, @tcberner wrote:

Im not sure whether it is a good idea to execute all the commands silenty during build -- I would probably prefer to remove the '@'.

This change does more than advertised in the CR description (which doesn't describe as much as the commit message should).

In D27023#602993, @mhorne wrote:

In D27023#602923, @kp wrote:

What else in the kernel wants to have access to this information?

Nothing yet. NetApp has a module that aggregates stats from various protocols, so that's where this patch is coming from. It would seem that a read-only copy is enough for this use-case, if that's your concern.

I was mostly just wondering. If I'd noticed the inverse (i.e. V_igmpstat is in the header but used nowhere else) I'd be inclined to reverse that. Generally you want as little visibility for your data as possible.
It may be worth adding a comment here to explain why it's in the header.

In D27023#602923, @kp wrote:

What else in the kernel wants to have access to this information?

I think this change is fine as is.

I'm still in doubt about the usefulness of LOCALBASE being specified at run-time if it is not applied to all paths in the system.
And for all other cases (not changed at run-time) a compiled in _PATH_LOCALBASE works as well, while scripts can use the sysctl command.

• Use CHN_F_VIRTUAL to get rid of virtual channels

• Improve unpcb names somewhat
• Clarify that the difference from LOCAL_CREDS applies only to stream/seqpacket sockets

• also patch malloc_domainset
• manpage

• Reorder second switch case to match first; no functional change.

• Update the comment. No functional change.

Fix typo

Datapoint: glibc does not appear to use CLONE_FS anywhere internally (or rather, only once, in tandem with CLONE_FILES, for creating threads): https://github.com/bminor/glibc/search?q=CLONE_FS

What else in the kernel wants to have access to this information?

Remove the accidental newline.

Review fixes.

Drop uses of _acq in updates of pm_eptgen and pm_active.

More bugfixes

Rust ports are "beautiful" :P

Separate -1 and default cases.

Fix bugs found in review

• Fix nvlist_add_boolean() typo.
• Remove bitperfect field from ud::userdev

Add missing chunk.

In D26986#602826, @mhorne wrote:

@gjb Would you prefer to see this change (and the preceeding ones) MFC'd to stable/12, or should it be for 13 only?

In D25963#602721, @bz wrote:

Thank you SOOOOOOOOOOO MUCH!!!!

If this builds, commit it! It'll help a lot!

I like it generally. I wonder what to do about shell. I think the following

@gjb Would you prefer to see this change (and the preceeding ones) MFC'd to stable/12, or should it be for 13 only?

• Add pminrate/pmaxrate and rminrate/rmaxrate labels
• Add pfmts and rfmts labels
• Add bitperfect label for sound(4) dsps

I think I have a way for us to converge on our strategies. Please see https://reviews.freebsd.org/D27022

In D27016#602731, @markj wrote:

The reason we handle CLONE_FS by setting RFFDG is because a process' cwd (and chroot dir and umask) is stored in the fd table.