FreeBSD code review with git-arc:
https://freebsdfoundation.org/wp-content/uploads/2021/11/FreeBSD-Code-Review-with-git-arc.pdf
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 42984 Build 39872: arc lint + arc unit
Event Timeline
devel/git-arc/Makefile | ||
---|---|---|
6–8 | This will build git-arc-default if you just run make, best remove this and use the flavors helpers as seen below. | |
22 | This is a very very bad idea, it will break if git lose one of those flavors. | |
23 | Better follow the how to use flavors section, and use flavor helpers. |
devel/git-arc/Makefile | ||
---|---|---|
22 | It's probably obvious, but the goal here is to not force a dependency on the default flavor of devel/git. Without this, users who have, e.g., git-lite installed will have a conflict when installing git-arc. I suppose sub-packages, when they arrive, will be a better solution. If git were broken into multiple packages we could just depend on the base git package and users who want the extra git components could install them independently. |
This comment was removed by jrm.
This comment was removed by jrm.
This comment was removed by jrm.