This is a big enough changes that I will do the libraries and tools as a separate review.
I've only removed files that prevented cpp from finding base system header.
Differential D25477
Kernel build changes for openzfs vendor import imp on Jun 26 2020, 9:10 PM. Authored by Tags None Referenced Files
Details
Diff Detail
Event Timeline
Comment Actions Lots of repetition in the module makefiles should be cleaned up. Normally I wouldn't fuss too much, but in this case it's very pervasive.
Comment Actions LGTM overall; do we support AVX in kernel code now, or are we just building these but giving kfpu_allowed a false value for now? Comment Actions Thanks for the earlier cleanups. Mostly minor stuff, and much of it is questions or leading questions...
Comment Actions There is always room for improvement, but this seems generally ok.
Note: #2 does not mean that you should remove everything from an that and guidance on formatting lists as previously described, fwiw I recommend switching to the one-per-line form when a list no longer fits in one line without wrapping. These seem like little things, but as with C code, consistent and clean style helps.
Comment Actions I'll echo Simon here: any change of this size could always be a bit better, but given the level of nits I'm finding most of them can be addressed by being a little more explicit about the points I've questioned in the commit message.
Comment Actions this revision never landed, but all the parts did and its OBE, so I've stolen this and am abandoning it. |