Page MenuHomeFreeBSD
Differential D22979

bsdinstall: Use TMPDIR if set
ClosedPublic
Actions

Authored by freqlabs on Dec 30 2019, 11:57 PM.
Tags
None
Referenced Files
F103806888: D22979.id66170.diff
Fri, Nov 29, 5:15 PM
Unknown Object (File)
Fri, Nov 22, 10:59 PM
Unknown Object (File)
Oct 25 2024, 5:07 AM
Unknown Object (File)
Oct 18 2024, 6:13 AM
Unknown Object (File)
Oct 5 2024, 6:05 PM
Unknown Object (File)
Oct 5 2024, 4:18 AM
Unknown Object (File)
Oct 5 2024, 3:41 AM
Unknown Object (File)
Oct 2 2024, 7:39 PM
View All 60 Files
Subscribers
bcr
imp

Details

Reviewers
bcran
darkfiberiru_gmail.com
Group Reviewers
manpages
Summary

This allows separate bsdinstall workflows to run simultaneously without stomping on each other, by specifying different TMPDIR and BSDINSTALL_CHROOT paths for each installation. This is beneficial when using bsdinstall scripts to prepare several different VM volumes, for example.

If TMPDIR is unset, it defaults to /tmp, which preserves the existing behavior.

Sponsored by: iXsystems, Inc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

freqlabs created this revision.Dec 30 2019, 11:57 PM
Herald added a reviewer: manpages. · View Herald TranscriptDec 30 2019, 11:57 PM
Herald added a subscriber: imp. · View Herald Transcript
freqlabs added a parent revision: D22937: bsdinstall: Clean up bsdinstall-esps file.Dec 30 2019, 11:57 PM
freqlabs updated this revision to Diff 66172.Dec 31 2019, 12:07 AM

Use $BSDINSTALL_CHROOT in place of /mnt for umount.

bcr accepted this revision as: manpages.Dec 31 2019, 10:48 AM
bcr added a subscriber: bcr.

Man page looks good to me.

darkfiberiru_gmail.com accepted this revision.EditedDec 31 2019, 7:59 PM

Looks like a good change to me. Fixes my concern about doing parallel runs for things like vm's

This revision is now accepted and ready to land.Dec 31 2019, 7:59 PM
bcran accepted this revision.Jan 2 2020, 3:05 AM
freqlabs mentioned this in D22937: bsdinstall: Clean up bsdinstall-esps file.Jan 2 2020, 4:44 PM
freqlabs added a comment.Jan 2 2020, 5:00 PM

@bcran Thanks! Would you mind committing this for me? I don't have the bit.

bcran added a comment.Jan 6 2020, 4:06 PM
In D22979#504080, @ryan_freqlabs.com wrote:

@bcran Thanks! Would you mind committing this for me? I don't have the bit.

Sure! I'll try and get it committed today.

freqlabs added a comment.Jan 14 2020, 4:20 PM
In D22979#505271, @bcran wrote:

Sure! I'll try and get it committed today.

Thank you! :)

bcran added a comment.Jan 14 2020, 5:55 PM
In D22979#507973, @ryan_freqlabs.com wrote:

Thank you! :)

Sorry for the delay, I've been ill.

bcran closed this revision.Jan 15 2020, 12:54 AM

Fixed in r356740 (https://svnweb.freebsd.org/base?view=revision&revision=356740).

Revision Contents
Changeset List

PathSize
usr.sbin/
bsdinstall/
8 lines
10 lines
partedit/
5 lines
2 lines
18 lines
scripts/
10 lines
2 lines
10 lines
2 lines
7 lines

Diff 66170

View Options

usr.sbin/bsdinstall/bsdinstall

Loading...
View Options

usr.sbin/bsdinstall/bsdinstall.8

Loading...
View Options

usr.sbin/bsdinstall/partedit/gpart_ops.c

Loading...
View Options

usr.sbin/bsdinstall/partedit/partedit.h

Loading...
View Options

usr.sbin/bsdinstall/partedit/partedit.c

Loading...
View Options

usr.sbin/bsdinstall/scripts/bootconfig

Loading...
View Options

usr.sbin/bsdinstall/scripts/mount

Loading...
View Options

usr.sbin/bsdinstall/scripts/script

Loading...
View Options

usr.sbin/bsdinstall/scripts/umount

Loading...
View Options

usr.sbin/bsdinstall/scripts/zfsboot

Loading...