Page MenuHomeFreeBSD
Differential D17527

sysutils/ipmitool - unbreak for openssl 1.1.1
ClosedPublic
Actions

Authored by sbruno on Oct 12 2018, 3:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 4:35 AM
Unknown Object (File)
Dec 22 2023, 11:10 PM
Unknown Object (File)
Sep 14 2023, 2:27 PM
Unknown Object (File)
Jun 28 2023, 5:56 PM
Unknown Object (File)
Apr 20 2023, 1:35 PM
Unknown Object (File)
Apr 7 2023, 4:35 PM
Unknown Object (File)
Mar 21 2023, 8:02 PM
Unknown Object (File)
Jan 4 2023, 8:45 AM
View All 9 Files
Subscribers
0mp
mat

Details

Reviewers
zi
emaste
jhb
0mp
Summary

This new patch file is an amalgum of several updates upstream on github.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 20165
Build 19655: arc lint + arc unit

Event Timeline

sbruno created this revision.Oct 12 2018, 3:50 AM
Herald added a subscriber: mat. · View Herald TranscriptOct 12 2018, 3:50 AM
Harbormaster completed remote builds in B20153: Diff 49041.Oct 12 2018, 3:50 AM
sbruno added a comment.Oct 12 2018, 3:51 AM

https://github.com/ipmitool/ipmitool/commit/1664902525a1c3771b4d8b3ccab7ea1ba6b2bdd1#diff-707b424f074d272f2934512475a3e99c

https://github.com/ipmitool/ipmitool/commit/b57487e360916ab3eaa50aa6d021c73b6337a4a0#diff-707b424f074d272f2934512475a3e99c

https://github.com/ipmitool/ipmitool/commit/f004b4b7197fc83e7d47ec8cbcaefffa9a922717#diff-707b424f074d272f2934512475a3e99c

sbruno added a comment.Oct 12 2018, 3:52 AM

Tested on FreeBSD 12 natively and compiled in poudriere.

I'm unsure if we want a port Makefile directive to "patch only if freebsd is running openssl 1.1.0" or if we want to wrap this diff file in a bunch of code to handle the difference in ABI (e.g. #if OPENSSL_VERSION > foo).

I suspect that we want the former, port Makefile directive, if only to alleviate the maintenance burden.

sbruno updated this revision to Diff 49066.Oct 12 2018, 4:22 PM

Apply openssl 1.1.1 update patch only if running on a FreeBSD version where
openssl 1.1.1 exists.

Harbormaster completed remote builds in B20165: Diff 49066.Oct 12 2018, 4:22 PM
0mp accepted this revision.Oct 12 2018, 4:38 PM
0mp added a subscriber: 0mp.

The Makefile part looks good to me.

I didn't review the OpenSSL fix.

This revision is now accepted and ready to land.Oct 12 2018, 4:38 PM
sbruno closed this revision.Dec 26 2018, 5:52 PM

r481915 | sbruno | 2018-10-12 11:51:37 -0600 (Fri, 12 Oct 2018) | 11 lines

sysutils/ipmitool: unbreak with openssl 1.1.1 import

  • Only apply openssl patch if we are on a version of FreeBSD with openssl 1.1.1
  • Don't bump portrevision as we don't change anything except on broken systems

It should be noted that this is a functional way to fix this port and is the method
used upstream. There are most likely better ways to do this.

Reviewed by: 0mp (Makefile changes)
Obtained from
Sponsored by: Limelight Networks

Revision Contents
Changeset List

PathSize
sysutils/
ipmitool/
8 lines
files/
140 lines

Diff 49066

View Options

sysutils/ipmitool/Makefile

Loading...
View Options

sysutils/ipmitool/files/extra-patch-src_plugins_lanplus_lanplus__crypt__impl.c

Loading...