- Add new port editors/cudatext
- Use FLAVORS (need portmgr approval)
- Depends of https://reviews.freebsd.org/D14661
Details
Details
- Reviewers
- None
- Group Reviewers
portmgr
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| cudatext/Makefile | ||
|---|---|---|
| 46 | Remove, set GH_PROJECT=CudaText instead. Isn't there a warning about this exact thing? | |
Comment Actions
The whole Makefile is badly ordered. Please read Chapter 15. Order of Variables in Port Makefiles.
| Makefile | ||
|---|---|---|
| 43 ↗ | (On Diff #46241) | Like the warning told you, please remove this line, it is wrong. |
| 45 ↗ | (On Diff #46241) | The flavors are framework generated, you cannot know which will be the default, it would be better to use variables instead of a condition, like: USE_FPC_gtk2= cairo
USE_GNOME_gtk2= cairo
USE_FPC+= ${USE_FPC_${FLAVOR}}
USE_GNOME+= ${USE_GNOME_${FLAVOR}} |
| Makefile | ||
|---|---|---|
| 33–35 ↗ | (On Diff #46349) | Wrong place in the Makefile. These are flavors helpers. See Chapter 15. Order of Variables in Port Makefiles. |