Page MenuHomeFreeBSD
Differential D15178

audio/mixxx update to 2.1.4
AbandonedPublic
Actions

Authored by acm on Apr 24 2018, 4:07 AM.
Tags
Referenced Files
Unknown Object (File)
Fri, Apr 12, 2:03 PM
Unknown Object (File)
Mon, Apr 8, 10:16 AM
Unknown Object (File)
Dec 20 2023, 2:52 AM
Unknown Object (File)
Nov 23 2023, 1:09 PM
Unknown Object (File)
Nov 23 2023, 11:47 AM
Unknown Object (File)
Nov 23 2023, 9:45 AM
Unknown Object (File)
Nov 15 2023, 8:06 AM
Unknown Object (File)
Nov 13 2023, 8:03 AM
View All 49 Files
Subscribers
mat

Details

Reviewers
None
Group Reviewers
portmgr
Summary
  • Add qt4|qt5 FLAVORS
Test Plan

Tested on poudriere 11-amd64

https://people.freebsd.org/~acm/ports/logs/mixxx-qt4-2.1.0.log
https://people.freebsd.org/~acm/ports/logs/mixxx-qt5-2.1.0.log

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

acm created this revision.Apr 24 2018, 4:07 AM
Herald added a subscriber: mat. · View Herald TranscriptApr 24 2018, 4:07 AM
mat added inline comments.May 25 2018, 2:42 PM
mixxx/Makefile
1

The only case where you can remove this line is if the person in it asked you to. In all other cases, it is write-only.

7

The distribution file name is too generic, please use DIST_SUBDIR.

35–39

Wrong place in the Makefile.

36

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

41

Wrong place in the Makefile.

42–54

Wrong place in the Makefile.

70–73

Wrong place in the Makefile.

acm updated this revision to Diff 43008.May 25 2018, 6:18 PM
acm marked 7 inline comments as done.
  • Apply changes according mat commentaries
mat added inline comments.May 25 2018, 10:32 PM
Makefile
7–9 ↗(On Diff #43008)

Sorry, missed the fact that you were not using USE_GITHUB like you should, here, add:

DISTVERSIONPREFIX=release-

and later, add:

USE_GITHUB=yes
GH_ACCOUNT=mixxxdj
47 ↗(On Diff #43008)

Remove.

75–81 ↗(On Diff #43008)

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

acm updated this revision to Diff 43346.Jun 5 2018, 9:46 PM
acm marked 3 inline comments as done.
  • Apply changes according mat commentaries
acm updated this revision to Diff 43347.Jun 5 2018, 10:03 PM
  • Update patch file with right version
mat added inline comments.Jun 6 2018, 10:49 AM
mixxx/Makefile
5

You should probably be using DISTVERSION.

6–7

Not required, could be removed.

33–35

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

96–109

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

acm retitled this revision from audio/mixxx update to 2.1.0 to audio/mixxx update to 2.1.1.Aug 3 2018, 3:07 PM
acm updated this revision to Diff 46234.Aug 3 2018, 3:09 PM
  • Apply changes accord to mat commentaries
acm updated this revision to Diff 46254.Aug 3 2018, 5:32 PM
  • Migrate to new QT helpers
mat added inline comments.Aug 6 2018, 9:17 AM
Makefile
33 ↗(On Diff #46254)

You should probably help to set FLAVOR here, you could drop all :U* dances later, see https://www.freebsd.org/doc/en/books/porters-handbook/flavors-using.html

45 ↗(On Diff #46254)

Default, please remove.

acm updated this revision to Diff 46351.Aug 6 2018, 6:44 PM
  • Apply mat's suggestions
acm marked 2 inline comments as done.Aug 6 2018, 6:44 PM
mat added inline comments.Aug 7 2018, 7:17 AM
Makefile
36–37 ↗(On Diff #46351)

Not exactly sure why using flavors helpers for this, it is the same value for both.

acm updated this revision to Diff 46373.Aug 7 2018, 7:24 AM
  • Add missing items to flavor_CONFLICTS
acm marked an inline comment as done.Aug 7 2018, 7:24 AM
acm marked 2 inline comments as done.
acm marked 2 inline comments as done.
mat added inline comments.Aug 7 2018, 4:37 PM
mixxx/Makefile
46

There is a release-2.1.1 you can use:

DISTVERSIONPREFIX=  release-
acm updated this revision to Diff 47473.Aug 30 2018, 5:42 AM
acm retitled this revision from audio/mixxx update to 2.1.1 to audio/mixxx update to 2.1.3.
  • Update to 2.1.3
  • Add DISTVERSIONPREFIX
  • Add CONFLICTS
acm marked an inline comment as done.Aug 30 2018, 5:44 AM
mat added inline comments.Aug 30 2018, 2:41 PM
mixxx/Makefile
5

This should probably be DISTVERSION.

17

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

acm updated this revision to Diff 49541.Oct 24 2018, 6:03 AM
acm retitled this revision from audio/mixxx update to 2.1.3 to audio/mixxx update to 2.1.4.
  • Update to 2.1.4
  • Some minor changes
acm marked 2 inline comments as done.Oct 24 2018, 6:04 AM
acm abandoned this revision.Nov 14 2018, 9:13 PM
  • Remove FLAVOR support. QT4 will be deprecated soon. it'll use QT instead of

Revision Contents
Changeset List

Diff 46373

View Options

mixxx/Makefile

Loading...
View Options

mixxx/distinfo

Loading...
View Options

mixxx/files/patch-build_depends.py

Loading...
View Options

mixxx/files/patch-build_features.py

Loading...
View Options

mixxx/files/patch-build_mixxx.py

Loading...
View Options

mixxx/files/patch-src_controllers_controllermanager.cpp

Loading...
View Options

mixxx/files/patch-src_musicbrainz_chromaprinter.cpp

Loading...
View Options

mixxx/files/patch-src_upgrade.cpp

Loading...
View Options

mixxx/pkg-plist

Loading...