Page MenuHomeFreeBSD
Differential D51148

lang/php*-extensions: Fix version numbers and Makefile ordering
ClosedPublic
Actions

Authored by olgeni on Thu, Jul 3, 2:59 PM.
Tags
None
Referenced Files
F124349923: D51148.diff
Fri, Jul 25, 2:11 PM
Unknown Object (File)
Thu, Jul 17, 9:47 PM
Unknown Object (File)
Mon, Jul 7, 5:44 AM
Unknown Object (File)
Mon, Jul 7, 5:44 AM
Unknown Object (File)
Mon, Jul 7, 5:44 AM
Unknown Object (File)
Mon, Jul 7, 5:44 AM
Unknown Object (File)
Mon, Jul 7, 5:44 AM
Unknown Object (File)
Thu, Jul 3, 6:55 PM
Subscribers
None

Details

Reviewers
bofh
Commits
R11:68f55354316d: lang/php*-extensions: Fix version numbers and Makefile ordering
Summary
  • Update pkg-descr files to show correct PHP version (was 8.0 for all)
  • Update COMMENT in Makefiles to include correct version branch
  • Fix Makefile variable ordering (IGNORE_WITH_PHP before PHP_VER)
  • Apply portfmt formatting

While here, ensure all ports pass portclippy validation.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olgeni requested review of this revision.Thu, Jul 3, 2:59 PM
olgeni created this revision.
Harbormaster completed remote builds in B65189: Diff 157885.Thu, Jul 3, 2:59 PM
bofh requested changes to this revision.Thu, Jul 3, 3:05 PM
bofh added inline comments.
lang/php81-extensions/Makefile
13–14

As you are fixing these I think we should also fix these IGNORE_WITH_PHP lines. This should also include 84 and 85. The same for others except php85 I believe.

This revision now requires changes to proceed.Thu, Jul 3, 3:05 PM
olgeni added a comment.Thu, Jul 3, 3:08 PM

Let me have a look at it...

olgeni updated this revision to Diff 157887.Thu, Jul 3, 3:16 PM

Better now!

Harbormaster completed remote builds in B65190: Diff 157887.Thu, Jul 3, 3:16 PM
bofh accepted this revision.Thu, Jul 3, 3:17 PM

Macro shipit:

This revision is now accepted and ready to land.Thu, Jul 3, 3:17 PM
Closed by commit R11:68f55354316d: lang/php*-extensions: Fix version numbers and Makefile ordering (authored by olgeni). · Explain WhyThu, Jul 3, 6:50 PM
This revision was automatically updated to reflect the committed changes.
olgeni added a commit: R11:68f55354316d: lang/php*-extensions: Fix version numbers and Makefile ordering.

Revision Contents
Changeset List

PathSize
lang/
php81-extensions/
16 lines
2 lines
php82-extensions/
16 lines
2 lines
php83-extensions/
16 lines
2 lines
php84-extensions/
13 lines
2 lines
php85-extensions/
15 lines
2 lines

Diff 157904

View Options

lang/php81-extensions/Makefile

Loading...
View Options

lang/php81-extensions/pkg-descr

Loading...
View Options

lang/php82-extensions/Makefile

Loading...
View Options

lang/php82-extensions/pkg-descr

Loading...
View Options

lang/php83-extensions/Makefile

Loading...
View Options

lang/php83-extensions/pkg-descr

Loading...
View Options

lang/php84-extensions/Makefile

Loading...
View Options

lang/php84-extensions/pkg-descr

Loading...
View Options

lang/php85-extensions/Makefile

Loading...
View Options

lang/php85-extensions/pkg-descr

Loading...