irc/soju: replace USES=go:no_target with USES=go:modules
Needs RevisionPublic
Actions

Authored by guest-svmhdvn on May 23 2024, 1:16 PM.

Details

Reviewers

Summary

irc/soju previously USES=go:no_target to disable the usual Go Port building infrastructure and instead rely on the upstream project's makefile to build. This made it difficult to reason about how port-provided flags finally get passed into the build.

This change uses the Porter's Handbook suggested method of porting Go applications as described here https://docs.freebsd.org/en/books/porters-handbook/book/#using-go. It removes the USES=go:no_target in order to use the FreeBSD Go application build infrastructure.

I've build and run tested this change.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

guest-svmhdvn requested review of this revision.May 23 2024, 1:16 PM

guest-svmhdvn created this revision.

I have to reject this:

I don't see any reason to deviate from what upstream recommends, and quite the contrary I would prefer to accommodate them when possible, instead of playing the cat-and-mouse game.
DOCS option removal is unwarranted, and since documentation (man pages) needs to be generated (and dependent on another port), I'd decided to add it as an OPTION instead for someone who prefer not to have any documentation. On the contrary, I am happy to include the other .md files the port ships with.
GO_MODULE was added not so long ago to reduce the churn (GH_TUPLE changes) repeated updates were causing, while using the recommended go get mechanism.

Following changes from this differential are good to go in: