graphics/timg: update to 1.6.0
ClosedPublic
Actions

Authored by uzsolt on Feb 14 2024, 7:47 PM.

Details

Reviewers

bofh
diizzy

Commits

R11:63460d2fa17b: graphics/timg: update to 1.6.0

Summary

Changelog: https://github.com/hzeller/timg/releases/tag/v1.6.0
Pet portclippy.

Test Plan

Portclippy, portfmt and portlint are ok.
Poudriere builds on 13.2 and 14.0

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

uzsolt requested review of this revision.Feb 14 2024, 7:47 PM

uzsolt created this revision.

What about these? (These might be installed if people are using ports and not Poudriere)
https://github.com/hzeller/timg/blob/v1.6.0/CMakeLists.txt#L59
https://github.com/hzeller/timg/blob/v1.6.0/CMakeLists.txt#L64

graphics/timg/Makefile
13	That doesn't seem to be needed/correct?
14	https://docs.freebsd.org/en/books/porters-handbook/book/#uses-pkgconfig
21	https://cgit.freebsd.org/ports/tree/Mk/Uses/jpeg.mk

Uses pkgconfig
Remove unneeded BUILD_DEPENDS
Add WITH_POPPLER, WITH_RSVG to CMAKE_OFF.

In D43898#1001771, @diizzy wrote:

What about these? (These might be installed if people are using ports and not Poudriere)
https://github.com/hzeller/timg/blob/v1.6.0/CMakeLists.txt#L59
https://github.com/hzeller/timg/blob/v1.6.0/CMakeLists.txt#L64

Added them to CMAKE_OFF. Thanks.

graphics/timg/Makefile
21	It doesn't work because jpeg.mk add graphics/jpeg-turbo dependency (https://cgit.freebsd.org/ports/tree/Mk/Uses/jpeg.mk#n17) but timg need graphics/libjpeg-turbo (plus 'lib' in name).