Differential Diff 115789

Diff 115789

Properties

Path

Size

stand/

common/

md.c

49 lines

Diff 115789

View Options

stand/common/md.c

This file was added.

Property	Old Value	New Value
File Mode	null	100755

				#!/bin/sh

				/usr/bin/sed -i.bak "$@"
				for x in "${@}" ; do
				tobikUnsubmitted Done Inline Actions This script always has exit status 0 which means that the blackbox behavior now differs when DEVELOPER is set and when it is not. If I introduce a syntax error in a sed expression the build will continue unpatched anyway when it probably should abort like before. Maybe add `set -e` or `\|\| exit 1` to the script or handle the error case in some other way. tobik: This script always has exit status 0 which means that the blackbox behavior now differs when…
				swillsAuthorUnsubmitted Done Inline Actions Sure, that's fine. swills: Sure, that's fine.
				if [ -f "${x}" ]; then
				if cmp "${x}" "${x}".bak > /dev/null 2>&1 ; then
				matUnsubmitted Done Inline Actions cmp as a silent mode: if cmp -s "${x}" "${x}".bak ; then mat: cmp as a silent mode: ``` if cmp -s "${x}" "${x}".bak ; then ```
				if [ ! -z "${REWARNFILE}" ]; then
				echo sed failed: backup file same as original: ${x} >> ${REWARNFILE}
				fi
				bdreweryUnsubmitted Done Inline Actions `[ -f $blah ]` doesn't generate output so the redirections aren't needed. bdrewery: `[ -f $blah ]` doesn't generate output so the redirections aren't needed.
				tobikUnsubmitted Done Inline Actions Every file flagged here will always be prefixed with ${WRKDIR} which seems redundant. WRKDIR can also be a pretty long path. Would it make sense to strip it like what is done in the shebang and symlink checks in qa.sh? tobik: Every file flagged here will always be prefixed with ${WRKDIR} which seems redundant. WRKDIR…
				swillsAuthorUnsubmitted Done Inline Actions Good idea. swills: Good idea.
				fi
				matUnsubmitted Done Inline Actions if !cmp "${x}" "${x}".bak > /dev/null 2>&1; then (or maybe without the `!`, not sure) mat: ``` if !cmp "${x}" "${x}".bak > /dev/null 2>&1; then ``` (or maybe without the `!`, not sure)
				fi
				done
				bdreweryUnsubmitted Not Done Inline Actions You quoted the first `if [ -f` but then lost quotes everywhere else. It will be significant with filenames with spaces or globbing characters. Unlikely but trivial to avoid the problem. bdrewery: You quoted the first `if [ -f` but then lost quotes everywhere else. It will be significant…