Page MenuHomeFreeBSD
Differential D33715

budsma: fix boundary alignment test
ClosedPublic
Actions

Authored by dougm on Jan 1 2022, 11:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 16, 8:35 AM
Unknown Object (File)
Jan 18 2025, 12:51 AM
Unknown Object (File)
Dec 7 2024, 7:22 PM
Unknown Object (File)
Nov 19 2024, 8:22 PM
Unknown Object (File)
Nov 19 2024, 6:27 PM
Unknown Object (File)
Nov 14 2024, 7:28 AM
Unknown Object (File)
Nov 13 2024, 11:57 AM
Unknown Object (File)
Nov 11 2024, 6:32 AM
View All 54 Files
Subscribers
andrew
emaste
imp
jhibbits

Details

Reviewers
se
manu
Commits
rG01f79c9da806: busdma: _bus_dmamap_addseg repaired
rGf1e7a532d1ee: busdma: _bus_dmamap_addseg repaired
Summary

c606ab59e7f9 vm_extern: use standard address checkers everywhere

broke a check in _bus_dmamap_addseg on many architectures. This change makes it clear that it is not a particular range that is being boundary-checked, but the proposed union of the two adjacent ranges.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm created this revision.Jan 1 2022, 11:48 PM
Herald added a reviewer: manu. · View Herald TranscriptJan 1 2022, 11:48 PM
Herald added subscribers: jhibbits, emaste, andrew. · View Herald Transcript
dougm requested review of this revision.Jan 1 2022, 11:48 PM
se accepted this revision.Jan 2 2022, 1:23 PM

Looks good to me:

increase current segment by sgsize bytes if

  • curraddr is contiguous to the end of the segment,
  • adding sgsize will not cause maxsegsz to be exceeded, and
  • start address plus increased segment length will still pass the boundary check.
This revision is now accepted and ready to land.Jan 2 2022, 1:23 PM
Closed by commit rGf1e7a532d1ee: busdma: _bus_dmamap_addseg repaired (authored by dougm). · Explain WhyJan 2 2022, 6:43 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rGf1e7a532d1ee: busdma: _bus_dmamap_addseg repaired.
Herald added a subscriber: imp. · View Herald TranscriptJan 2 2022, 6:43 PM
dougm added a commit: rG01f79c9da806: busdma: _bus_dmamap_addseg repaired.Jul 12 2022, 5:33 PM

Revision Contents
Changeset List

PathSize
sys/
arm/
arm/
4 lines
arm64/
arm64/
4 lines
powerpc/
powerpc/
4 lines
riscv/
riscv/
4 lines
x86/
x86/
4 lines

Diff 100812

View Options

sys/arm/arm/busdma_machdep.c

Loading...
View Options

sys/arm64/arm64/busdma_bounce.c

Loading...
View Options

sys/powerpc/powerpc/busdma_machdep.c

Loading...
View Options

sys/riscv/riscv/busdma_bounce.c

Loading...
View Options

sys/x86/x86/busdma_bounce.c

Loading...