Changeset View
Changeset View
Standalone View
Standalone View
sysutils/fusefs-ntfs/Makefile
| # Created by: Max Khon | # Created by: Max Khon | ||||
| PORTNAME= ntfs | PORTNAME= ntfs | ||||
| PORTVERSION= 2017.3.23 | PORTVERSION= 2021.8.22 | ||||
| CATEGORIES= sysutils | CATEGORIES= sysutils | ||||
| MASTER_SITES= http://tuxera.com/opensource/ | MASTER_SITES= https://tuxera.com/opensource/ | ||||
| PKGNAMEPREFIX= fusefs- | PKGNAMEPREFIX= fusefs- | ||||
| DISTNAME= ${PORTNAME}-3g_ntfsprogs-${PORTVERSION} | DISTNAME= ${PORTNAME}-3g_ntfsprogs-${PORTVERSION} | ||||
| MAINTAINER= freebsd@dussan.org | MAINTAINER= freebsd@dussan.org | ||||
| COMMENT= Mount NTFS partitions (read/write) and disk images | COMMENT= Mount NTFS partitions (read/write) and disk images | ||||
| LICENSE= GPLv2+ | LICENSE= GPLv2+ | ||||
| LICENSE_FILE= ${WRKSRC}/COPYING | LICENSE_FILE= ${WRKSRC}/COPYING | ||||
| LIB_DEPENDS= libuuid.so:misc/e2fsprogs-libuuid | LIB_DEPENDS= libuuid.so:misc/e2fsprogs-libuuid | ||||
| USES= fuse pkgconfig iconv libtool localbase:ldflags tar:tgz | # Doesnt support fuse3 (yet) | ||||
| USES= fuse:2 pkgconfig iconv libtool localbase:ldflags tar:tgz | |||||
| USE_LDCONFIG= yes | USE_LDCONFIG= yes | ||||
| GNU_CONFIGURE= yes | GNU_CONFIGURE= yes | ||||
| CONFIGURE_ARGS= --exec-prefix=${PREFIX} --disable-mount-helper \ | CONFIGURE_ARGS= --with-fuse=external \ | ||||
danfe: There's nothing wrong with multiple arguments per line for the `CONFIGURE_ARGS`, but even if… | |||||
| --disable-mtab --with-fuse=external --disable-ldconfig | --exec-prefix=${PREFIX} \ | ||||
| CPPFLAGS+= -I${WRKSRC}/include/ntfs-3g/ | --disable-ldconfig \ | ||||
| --enable-extras \ | |||||
| --disable-mount-helper \ | |||||
| --disable-mtab | |||||
| OPTIONS_DEFINE= DOCS | |||||
| OPTIONS_DEFINE= LOCK UBLIO DOCS | INSTALL_TARGET= install-strip | ||||
Not Done Inline ActionsWhat happened to the options block? They equally apply to the new version just as they do to the current one. danfe: What happened to the options block? They equally apply to the new version just as they do to… | |||||
| OPTIONS_DEFAULT=LOCK UBLIO | |||||
| LOCK_DESC= Lock the device when mounting (avoids access) | |||||
| LOCK_CFLAGS= -DUSE_LOCK | |||||
| UBLIO_DESC= Enable user space cache for improved speed | |||||
| UBLIO_EXTRA_PATCHES= ${FILESDIR}/extra-patch-ublio | |||||
| UBLIO_LIB_DEPENDS= libublio.so:devel/libublio | |||||
| UBLIO_CFLAGS= -DUSE_UBLIO | |||||
| SUB_FILES= pkg-message | #SUB_FILES= pkg-message | ||||
Not Done Inline ActionsDid you mean to leave this line here, and lines 36-37 ? asomers: Did you mean to leave this line here, and lines 36-37 ? | |||||
Done Inline ActionsYeh, just for now, this patch is not in final form ready for tree. I'm at the 'disable all the things' and establish a baseline upstream stage. koobs: Yeh, just for now, this patch is not in final form ready for tree. I'm at the 'disable all the… | |||||
Not Done Inline Actions
I don't understand this rationale, as well as removing most of the existing port's Makefile. Simply bumping the PORTVERSION is enough for the port to build (modulo adjusting the checksum, one patch, and pkg-plist). Throwing away previous work, mixing style and functional changes is not how we do things in FreeBSD, sorry. danfe: > I'm at the 'disable all the things' and establish a baseline upstream stage.
I don't… | |||||
| DOCSDIR= ${PREFIX}/share/doc/ntfs-3g | DOCSDIR= ${PREFIX}/share/doc/ntfs-3g | ||||
| post-patch: | #post-install-DOCS-on: | ||||
| @${REINPLACE_CMD} -e 's|ENODATA|ENOATTR|' \ | # ${INSTALL_DATA} ${FILESDIR}/README.FreeBSD ${STAGEDIR}${DOCSDIR}/ | ||||
| ${WRKSRC}/libntfs-3g/object_id.c \ | |||||
| ${WRKSRC}/libntfs-3g/reparse.c \ | |||||
| ${WRKSRC}/libntfs-3g/security.c | |||||
| @${REINPLACE_CMD} -e 's|\($$(AM_CFLAGS)\) \(-I$$(top_srcdir)/include/ntfs-3g\)|\2 \1|; \ | |||||
| /install-exec-hook:/,/^$$/ s|^@.*||' ${WRKSRC}/libntfs-3g/Makefile.in | |||||
| post-install: | |||||
| ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libntfs-3g.so | |||||
| post-install-DOCS-on: | |||||
| ${INSTALL_DATA} ${FILESDIR}/README.FreeBSD ${STAGEDIR}${DOCSDIR}/ | |||||
| .include <bsd.port.mk> | .include <bsd.port.mk> | ||||
There's nothing wrong with multiple arguments per line for the CONFIGURE_ARGS, but even if you prefer tall (one argument per line) version for some reason, it should not be part of the version bump or other function change.