Differential D32266 Diff 100827 graphics/zathura/Makefile

Changeset View

Standalone View

graphics/zathura/Makefile

	# Created by: Quentin Stievenart <acieroid@awesom.eu>			# Created by: Quentin Stievenart <acieroid@awesom.eu>

	PORTNAME= zathura			PORTNAME= zathura
	DISTVERSION= 0.4.5			DISTVERSION= 0.4.8
	CATEGORIES= graphics print			CATEGORIES= graphics print
	MASTER_SITES= https://git.pwmt.org/pwmt/${PORTNAME}/-/archive/${DISTVERSION}/			MASTER_SITES= https://git.pwmt.org/pwmt/${PORTNAME}/-/archive/${DISTVERSION}/

	MAINTAINER= quentin.stievenart@gmail.com			MAINTAINER= quentin.stievenart@gmail.com
	COMMENT= Customizable lightweight pdf viewer			COMMENT= Highly customizable and functional document viewer

	LICENSE= ZLIB			LICENSE= ZLIB
	LICENSE_FILE= ${WRKSRC}/LICENSE			LICENSE_FILE= ${WRKSRC}/LICENSE

	LIB_DEPENDS= libcairo.so:graphics/cairo \			LIB_DEPENDS= libcairo.so:graphics/cairo \
	libgirara-gtk3.so:x11-toolkits/girara \			libgirara-gtk3.so:x11-toolkits/girara
	libsynctex.so:devel/tex-synctex
	BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}sphinx>=1.2.2,1:textproc/py-sphinx@${PY_FLAVOR} \			BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}sphinx>=1.2.2,1:textproc/py-sphinx@${PY_FLAVOR} \
	${PYTHON_PKGNAMEPREFIX}sphinx_rtd_theme>0:textproc/py-sphinx_rtd_theme@${PY_FLAVOR}			${PYTHON_PKGNAMEPREFIX}sphinx_rtd_theme>0:textproc/py-sphinx_rtd_theme@${PY_FLAVOR}

	USES= compiler:c11 gettext-tools:build gnome meson ninja pkgconfig \			USES= compiler:c11 gettext-tools:build gnome meson ninja pkgconfig \
	python:3.6+			python:3.6+
	USE_GNOME= glib20 gtk30 gdkpixbuf2			USE_GNOME= glib20 gtk30 gdkpixbuf2
	INSTALLS_ICONS= yes			INSTALLS_ICONS= yes

	OPTIONS_DEFINE= SQLITE			OPTIONS_DEFINE= SQLITE SYNCTEX
	OPTIONS_DEFAULT= SQLITE			OPTIONS_DEFAULT= SQLITE SYNCTEX

	SQLITE_USES= sqlite			SQLITE_USES= sqlite
	SQLITE_MESON_ENABLED= sqlite			SQLITE_MESON_ENABLED= sqlite

				SYNCTEX_DESC= SyncTeX support
				koobsUnsubmitted Done Inline Actions OPTION_DESC's should have descriptions that describe the feature/value from a user perspective. Sometimes this is just the name of the dependencies, but often it is not. In this case I believe SyncTeX is used for Zathura's 'Forward/Inverse Search' feature. One may consider: Renaming the SYNCTEX option to SEARCH, OR Creating a SEARCH option GROUP, with LATEX being an option within it In the latter case, the search group can have its own description like SEARCH_DESC"Forward/Inverse Search " and LATEX_DESC="Latex Support", or similasr koobs: OPTION_DESC's should have descriptions that describe the feature/value from a user perspective.
				kfv_kfv.ioAuthorUnsubmitted Done Inline Actions I improved the description but kept the title as is since Zathura uses the same term even on their website. But if you still think it's better to change it to something like SEARCH, let me know and I'll follow your call. kfv_kfv.io: I improved the description but kept the title as is since Zathura uses the same term even on…
				koobsUnsubmitted Done Inline Actions Is there synchronization support for other formats? Granted upstream describes the technology that drives the feature (synctex), but this still feels like: LATEX_DESC=LaTeX Synchronization Support with SyncTeX koobs: Is there synchronization support for other formats? Granted upstream describes the technology…
				kfv_kfv.ioAuthorUnsubmitted Done Inline Actions I haven't seen forward/inverse search synchronisation anywhere else, but theoretically, there could be, and I just searched for inverse search technologies, and GNU LilyPond seems to have something similar. So yes, there should be similar implementations for other typesetting systems. Therefore, since Zathura is a general document viewer and they might implement other synchronisation technologies in future, we'd better use something more descriptive, right. But I go with TeX as the title since it's not only targeting LaTeX. Please let me know if you have another idea. TEX_DESC= Direct and reverse synchronisation support with SyncTeX kfv_kfv.io: I haven't seen forward/inverse search synchronisation anywhere else, but theoretically, there…
				koobsUnsubmitted Not Done Inline Actions 'to do' isnt the best grammar here. 'for' is better. koobs: 'to do' isnt the best grammar here. 'for' is better.
				SYNCTEX_LIB_DEPENDS= libsynctex.so.2:devel/tex-synctex
				koobsUnsubmitted Done Inline Actions Review summary says `libsynctex >= 1.19.0` but this version spec is not added here. Perhaps depend on the packagename instead, allowing you to pass the version requirement. koobs: Review summary says ` libsynctex >= 1.19.0` but this version spec is not added here. Perhaps…
				kfv_kfv.ioAuthorUnsubmitted Done Inline Actions Is it OK now? I didn't know how to ask for a greater than or equal to a specific version. Please let me know if I should do it differently. kfv_kfv.io: Is it OK now? I didn't know how to ask for a greater than or equal to a specific version.
				koobsUnsubmitted Done Inline Actions Depend on the package name, instead of the library like: `RUN_DEPENDS=tex-synctex>=1.19.0:devel/tex-synctex` If its also required at build time: `BUILD_DEPENDS=tex-synctex>=1.19.0:devel/tex-synctex` koobs: Depend on the package name, instead of the library like: `RUN_DEPENDS=tex-synctex>=1.19.0…
				kfv_kfv.ioAuthorUnsubmitted Done Inline Actions Done. Please let me know if there's anything else I could improve. kfv_kfv.io: Done. Please let me know if there's anything else I could improve.
				koobsUnsubmitted Not Done Inline Actions There's duplicate `TEX_DESC`'s here. koobs: There's duplicate `TEX_DESC`'s here.
				SYNCTEX_MESON_ENABLED= synctex

	.include <bsd.port.mk>			.include <bsd.port.mk>