Changeset View
Standalone View
devel/py-qt5-pyqt/Makefile
- This file was added.
| PORTNAME= pyqt | |||||
| PORTVERSION= ${PYQT5_VERSION} | |||||
| PORTREVISION= 3 | |||||
| CATEGORIES= devel python | |||||
| MASTER_SITES= ${MASTER_SITES_PYQT5} | |||||
| PKGNAMEPREFIX= ${PYQT_PY_RELNAME}- | |||||
| DISTNAME= ${PYQT5_DISTNAME} | |||||
| MAINTAINER= kde@FreeBSD.org | |||||
| COMMENT= Python bindings for the Qt5 toolkit, QtCore module | |||||
| PYQT_DIST= yes | |||||
| LIB_DEPENDS= libqscintilla2_qt5.so:devel/qscintilla2-qt5 | |||||
| USES= python:3.8+ pyqt:5 qt:5 | |||||
| USE_PYTHON= concurrent flavors py3kplist | |||||
| USE_PYQT= qtbuilder sip pysip | |||||
| USE_QT= ${_USE_QT_ALL:Nphonon4} | |||||
makc: I think it shouldn't pull everything from Qt5. Definitely various qt tools are not needed as… | |||||
Done Inline ActionsHmmm, but if I split it, we're going back to the original state, aren't we? Is there a cleaner way (yes the subpackage, but even if it is possible, it is not in poudriere)? lbartoletti: Hmmm, but if I split it, we're going back to the original state, aren't we? Is there a cleaner… | |||||
Done Inline ActionsNo, I do not suggest to spit it back. My point is that PyQt is mainly a wrapper around Qt libraries, not all of Qt. The PyQt port should depend on all required Qt components, but not on all Qt ports. For example, after this update I now have all of qt5-sqldrivers-* packages with corresponding database ports (firebird25, postgresql, etc) installed, also qt5-examples, qt5-l10n, qt5-pixeltool, etc, which are not used by anything. I suggest to explicitly set USE_QT to what PyQt needs itself. makc: No, I do not suggest to spit it back. My point is that PyQt is mainly a wrapper around Qt… | |||||
Done Inline ActionsSo, if I'm not wrong. PyQT, will need: All USE_QT from py-qt5-* ports except x11-toolkits/py-qt5-chart, net/py-qt5-networkauth and www/py-qt5-webengine Is it ok for you? Thanks lbartoletti: So, if I'm not wrong. PyQT, will need:
`buildtools core dbus declarative designer gui help… | |||||
Done Inline ActionsLooks fine! buildtools and qmake should probably be build-only dependencies. makc: Looks fine!
buildtools and qmake should probably be build-only dependencies. | |||||
Done Inline ActionsOk. With this “reduced” list, only QtBluetooth, QtNfc and QtX11Extras disappear from the list of python packages (and which were not present today). lbartoletti: Ok. With this “reduced” list, only QtBluetooth, QtNfc and QtX11Extras disappear from the list… | |||||
| PORTSCOUT?= limit:^${_QT_VERSION:R} | |||||
| post-extract: | |||||
| ${RM} -r ${WRKSRC}/pyuic/uic/port_v2 | |||||
| post-install: | |||||
| ${PYTHON_CMD} ${PYTHON_LIBDIR}/compileall.py \ | |||||
Done Inline ActionsThis seems to repeat the do-build from Mk/Uses/pyqt.mk. Why redefine this? arrowd: This seems to repeat the `do-build` from `Mk/Uses/pyqt.mk`. Why redefine this? | |||||
Done Inline ActionsI have to add "--confirm-license", but maybe It could be moved with a condition in Mk/Uses/pyqt.mk lbartoletti: I have to add "--confirm-license", but maybe It could be moved with a condition in… | |||||
Done Inline Actionslbartoletti: Done in https://reviews.freebsd.org/D33237?id=99413 | |||||
| -f -d ${PYTHONPREFIX_SITELIBDIR}/PyQt5 \ | |||||
| ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/PyQt5 | |||||
| ${PYTHON_CMD} -O ${PYTHON_LIBDIR}/compileall.py \ | |||||
| -f -d ${PYTHONPREFIX_SITELIBDIR}/PyQt5 \ | |||||
| ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/PyQt5 | |||||
| @${FIND} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/PyQt5 \ | |||||
| -name '*.so*' -exec ${STRIP_CMD} {} + | |||||
| .include <bsd.port.mk> | |||||
I think it shouldn't pull everything from Qt5. Definitely various qt tools are not needed as runtime deps for pyqt, and also qt plugins including qt5-sqldrivers-*.