Differential D33168 Diff 99174 lib/geom/part/geom_part.c

Changeset View

Standalone View

lib/geom/part/geom_part.c

Show First 20 Lines • Show All 121 Lines • ▼ Show 20 Lines	struct g_command PUBSYM(class_commands)[] = {
},		},
{ "commit", 0, gpart_issue, G_NULL_OPTS,		{ "commit", 0, gpart_issue, G_NULL_OPTS,
"geom"		"geom"
},		},
{ "create", 0, gpart_issue, {		{ "create", 0, gpart_issue, {
{ 's', "scheme", NULL, G_TYPE_STRING },		{ 's', "scheme", NULL, G_TYPE_STRING },
{ 'n', "entries", G_VAL_OPTIONAL, G_TYPE_NUMBER },		{ 'n', "entries", G_VAL_OPTIONAL, G_TYPE_NUMBER },
{ 'f', "flags", GPART_FLAGS, G_TYPE_STRING },		{ 'f', "flags", GPART_FLAGS, G_TYPE_STRING },
		{ 'l', "tblpri_start", G_VAL_OPTIONAL, G_TYPE_STRING },
		{ 'L', "tblsec_start", G_VAL_OPTIONAL, G_TYPE_STRING },
		cemUnsubmitted Not Done Inline Actions Why not use G_TYPE_NUMBER? cem: Why not use G_TYPE_NUMBER?
		bzAuthorUnsubmitted Done Inline Actions Because g_part_parm_quad() operates on a string (see add -b / -s) and g_part_parm_intmax() only handles an u_int which probably is not large enough for current storage anymore. Not sure why begin and size where chosen to be passed as string (possibly because they are also taking SI suffixes in user space) and it is hard to describe an option as two different things (though not impossible)? bz: Because g_part_parm_quad() operates on a string (see add -b / -s) and g_part_parm_intmax() only…
G_OPT_SENTINEL },		G_OPT_SENTINEL },
"-s scheme [-n entries] [-f flags] provider"		"-s scheme [-l/-L start pri/sec table] [-n entries] [-f flags] provider"
},		},
{ "delete", 0, gpart_issue, {		{ "delete", 0, gpart_issue, {
{ 'i', GPART_PARAM_INDEX, NULL, G_TYPE_NUMBER },		{ 'i', GPART_PARAM_INDEX, NULL, G_TYPE_NUMBER },
{ 'f', "flags", GPART_FLAGS, G_TYPE_STRING },		{ 'f', "flags", GPART_FLAGS, G_TYPE_STRING },
G_OPT_SENTINEL },		G_OPT_SENTINEL },
"-i index [-f flags] geom"		"-i index [-f flags] geom"
},		},
{ "destroy", 0, gpart_issue, {		{ "destroy", 0, gpart_issue, {
▲ Show 20 Lines • Show All 1,207 Lines • Show Last 20 Lines