Page MenuHomeFreeBSD
Differential D32749 Diff 98517 sys/dev/acpica/acpi_pci.c

Changeset View

Standalone View

View Options

sys/dev/acpica/acpi_pci.c

Show First 20 Lines • Show All 198 Lines • ▼ Show 20 Linesacpi_pci_child_location_method(device_t cbdev, device_t child, struct sbuf *sb)
return (0); return (0);
} }
static int static int
acpi_pci_get_device_path(device_t bus, device_t child, const char *locator, struct sbuf *sb) acpi_pci_get_device_path(device_t bus, device_t child, const char *locator, struct sbuf *sb)
{ {
if (strcmp(locator, BUS_LOCATOR_ACPI) == 0) if (strcmp(locator, BUS_LOCATOR_ACPI) == 0)
return (acpi_get_acpi_device_path(bus, child, locator, sb)); return (acpi_get_acpi_device_path(bus, child, locator, sb));
jhbUnsubmitted
Not Done
Inline Actions

I would maybe make this function use pci_get_device_path_method as its default at the bottom rather than only for UEFI, so something like:

static int
acpi_pci_get_device_path(...)
{
     if (strcmp(locator, BUS_LOCATOR_ACPI) == 0) {
        return (acpi_get_device_path(...));
     return (pci_get_device_path_method(...));
}
jhb: I would maybe make this function use `pci_get_device_path_method` as its default at the bottom…
/* For the rest, punt to the default handler */ /* Otherwise follow base class' actions */
return (bus_generic_get_device_path(bus, child, locator, sb)); return (pci_get_device_path_method(bus, child, locator, sb));
} }
/* /*
* PCI power manangement * PCI power manangement
*/ */
static int static int
acpi_pci_set_powerstate_method(device_t dev, device_t child, int state) acpi_pci_set_powerstate_method(device_t dev, device_t child, int state)
{ {
▲ Show 20 Lines • Show All 277 Lines • Show Last 20 Lines