Differential D473 Diff 1362 sys/powerpc/powerpc/elf32_machdep.c

Changeset View

Standalone View

sys/powerpc/powerpc/elf32_machdep.c

Context not available.
	* $FreeBSD$	* $FreeBSD$
	*/	*/

		#include "opt_pax.h"

	#include <sys/param.h>	#include <sys/param.h>
	#include <sys/kernel.h>	#include <sys/kernel.h>
	#include <sys/systm.h>	#include <sys/systm.h>
Context not available.
	#include <sys/exec.h>	#include <sys/exec.h>
	#include <sys/imgact.h>	#include <sys/imgact.h>
	#include <sys/malloc.h>	#include <sys/malloc.h>
		#include <sys/pax.h>
	#include <sys/proc.h>	#include <sys/proc.h>
	#include <sys/namei.h>	#include <sys/namei.h>
	#include <sys/fcntl.h>	#include <sys/fcntl.h>
Context not available.
	.sv_shared_page_base = FREEBSD32_SHAREDPAGE,	.sv_shared_page_base = FREEBSD32_SHAREDPAGE,
	.sv_shared_page_len = PAGE_SIZE,	.sv_shared_page_len = PAGE_SIZE,
	.sv_schedtail = NULL,	.sv_schedtail = NULL,
		#ifdef PAX_ASLR
		.sv_pax_aslr_init = _pax_aslr_init32,
		#endif
	};	};
	INIT_SYSENTVEC(elf32_sysvec, &elf32_freebsd_sysvec);	INIT_SYSENTVEC(elf32_sysvec, &elf32_freebsd_sysvec);

Context not available.
		impUnsubmitted Not Done Inline Actions This is a fairly common idiom. Perhaps it would be better to say .sv_pax_aslr_init = PAX_INIT(_pax_aslr_init32) where PAX_INIT(x) expands to x when PAX_ASLR is defined, and NULL when not. Pick your own name instead of PAX_INIT, I'm not picky about that. But to do that, then sys/pax.h likely would need to always be included... imp: This is a fairly common idiom. Perhaps it would be better to say .sv_pax_aslr_init = PAX_INIT…
		desUnsubmitted Not Done Inline Actions In the non-PAX_ASLR case sv_pax_aslr_init is implicitly initialized to NULL, so the #else is unnecessary. Same for all the other {elf,freebsd}{,32,64}_machdep.c. des: In the non-PAX_ASLR case sv_pax_aslr_init is implicitly initialized to NULL, so the #else is…