Page MenuHomeFreeBSD
Differential D32031 Diff 98053 graphics/py-wand/Makefile

Changeset View

Standalone View

View Options

graphics/py-wand/Makefile

PORTNAME= Wand PORTNAME= Wand
PORTVERSION= 0.6.7 DISTVERSION= 0.6.7
PORTREVISION= 1
CATEGORIES= graphics python CATEGORIES= graphics python
MASTER_SITES= CHEESESHOP MASTER_SITES= CHEESESHOP
PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
MAINTAINER= python@FreeBSD.org MAINTAINER= rsmith@xs4all.nl
COMMENT= MagickWand Python binding COMMENT= MagickWand Python binding
LICENSE= MIT LICENSE= MIT
LICENSE_FILE= ${WRKSRC}/LICENSE LICENSE_FILE= ${WRKSRC}/LICENSE
USES= python:3.6+ USES= python
USE_PYTHON= autoplist concurrent distutils USE_PYTHON= autoplist concurrent distutils
NO_ARCH= yes NO_ARCH= yes
PORTDOCS= *
koobsUnsubmitted
Not Done
Inline Actions

Leftover trailing \, but i would add numpy here for additional (optional) tests to be run

koobs: Leftover trailing `\`, but i would add numpy here for additional (optional) tests to be run
OPTIONS_DEFINE= X11 OPTIONS_DEFINE= DOCS X11
OPTIONS_SINGLE= IMAGEMAGICK OPTIONS_DEFAULT= X11
OPTIONS_SINGLE_IMAGEMAGICK= IMAGEMAGICK6 IMAGEMAGICK7
OPTIONS_DEFAULT=IMAGEMAGICK7 X11
IMAGEMAGICK6_DESC= Use ImageMagick 6.x (graphics/ImageMagick6*)
IMAGEMAGICK7_DESC= Use ImageMagick 7.x (graphics/ImageMagick7*)
.include <bsd.port.options.mk> DOCS_BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}sphinx>=0:textproc/py-sphinx@${PY_FLAVOR}
lbartolettiUnsubmitted
Done
Inline Actions

I wonder if >=0,1 is not a typo.
>=0 should be sufficient?

lbartoletti: I wonder if `>=0,1` is not a typo. `>=0` should be sufficient?
DOCS_VARS= PYDISTUTILS_BUILD_TARGET+="build_sphinx -a -E"
.if ${PORT_OPTIONS:MX11} X11_LIB_DEPENDS= ${_IMAGEMAGICK_LIB_DEPENDS}
.if ${PORT_OPTIONS:MIMAGEMAGICK7} X11_LIB_DEPENDS_OFF= ${_IMAGEMAGICK_LIB_DEPENDS}-nox11
LIB_DEPENDS= libMagickWand-7.so:graphics/ImageMagick7
.else _IMAGEMAGICK_LIB_DEPENDS= libMagickWand-${IMAGEMAGICK_DEFAULT}.so:graphics/ImageMagick${IMAGEMAGICK_DEFAULT}
koobsUnsubmitted
Not Done
Inline Actions

Is it possible to just have straight X11_LIB_DEPENDS= and X11_LIB_DEPENDS_OFF lines here instead of the shared/indirect variable? Prefer explicit/readability over 'deduplication'

koobs: Is it possible to just have straight X11_LIB_DEPENDS= and X11_LIB_DEPENDS_OFF lines here…
LIB_DEPENDS= libMagickWand-6.so:graphics/ImageMagick6
.endif post-install-DOCS-on:
.else @${MKDIR} ${STAGEDIR}${DOCSDIR}
.if ${PORT_OPTIONS:MIMAGEMAGICK7} (cd ${WRKSRC}/build/sphinx/html && \
LIB_DEPENDS= libMagickWand-7.so:graphics/ImageMagick7-nox11 ${COPYTREE_SHARE} . ${STAGEDIR}${DOCSDIR} \
.else "! -name .buildinfo -and ! -name objects.inv")
LIB_DEPENDS= libMagickWand-6.so:graphics/ImageMagick6-nox11
.endif
.endif
.include <bsd.port.mk> .include <bsd.port.mk>