Changeset View
Standalone View
sys/arm/qualcomm/ipq4018_machdep.c
- This file was added.
| /*- | |||||
| * SPDX-License-Identifier: BSD-2-Clause-FreeBSD | |||||
| * | |||||
| * Copyright (c) 2021 Adrian Chadd <adrian@FreeBSD.org> | |||||
| * All rights reserved. | |||||
| * | |||||
| * Redistribution and use in source and binary forms, with or without | |||||
| * modification, are permitted provided that the following conditions | |||||
| * are met: | |||||
| * 1. Redistributions of source code must retain the above copyright | |||||
| * notice, this list of conditions and the following disclaimer. | |||||
| * 2. Redistributions in binary form must reproduce the above copyright | |||||
| * notice, this list of conditions and the following disclaimer in the | |||||
| * documentation and/or other materials provided with the distribution. | |||||
| * | |||||
| * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND | |||||
| * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | |||||
| * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE | |||||
| * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE | |||||
| * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL | |||||
| * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS | |||||
| * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) | |||||
| * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT | |||||
| * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY | |||||
| * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF | |||||
| * SUCH DAMAGE. | |||||
| */ | |||||
| #include "opt_platform.h" | |||||
| #include <sys/cdefs.h> | |||||
| __FBSDID("$FreeBSD$"); | |||||
| #include <sys/param.h> | |||||
| #include <sys/systm.h> | |||||
| #include <sys/bus.h> | |||||
| #include <sys/reboot.h> | |||||
| #include <sys/devmap.h> | |||||
| #include <sys/physmem.h> | |||||
| #include <vm/vm.h> | |||||
| #include <machine/bus.h> | |||||
| #include <machine/intr.h> | |||||
| #include <machine/machdep.h> | |||||
| #include <machine/platformvar.h> | |||||
| #include <dev/fdt/fdt_common.h> | |||||
| #include <dev/ofw/openfirm.h> | |||||
| #include <arm/qualcomm/ipq4018_machdep.h> | |||||
| #include <arm/qualcomm/ipq4018_reg.h> | |||||
| #include "platform_if.h" | |||||
| static int | |||||
| ipq4018_attach(platform_t plat) | |||||
| { | |||||
| return (0); | |||||
| } | |||||
| static void | |||||
| ipq4018_late_init(platform_t plat) | |||||
| { | |||||
| /* | |||||
| * These cover the SRAM/TZ regions that are not fully | |||||
jrtc27: FIXME or XXX this and explain *why* the current code doesn't work. Or maybe we should fix the… | |||||
Done Inline Actionsok, lemme update the comment. I'd like to fix this properly later :) adrian: ok, lemme update the comment. I'd like to fix this properly later :) | |||||
| * accessible from the OS. They're in the ipq4018.dtsi | |||||
| * tree. | |||||
| * | |||||
| * Without these, the system fails to boot because we | |||||
| * aren't parsing the regions correctly. | |||||
| * | |||||
| * These will be unnecessary once the parser and setup | |||||
| * code is fixed. | |||||
| */ | |||||
| physmem_exclude_region(IPQ4018_MEM_SMEM_START, | |||||
| IPQ4018_MEM_SMEM_SIZE, | |||||
| EXFLAG_NODUMP | EXFLAG_NOALLOC); | |||||
| physmem_exclude_region(IPQ4018_MEM_TZ_START, | |||||
| IPQ4018_MEM_TZ_SIZE, | |||||
| EXFLAG_NODUMP | EXFLAG_NOALLOC); | |||||
| } | |||||
| static int | |||||
| ipq4018_devmap_init(platform_t plat) | |||||
| { | |||||
| /* | |||||
| * This covers the boot UART. Without it we can't boot successfully: | |||||
| * there's a mutex uninit panic in subr_vmem.c that occurs when doing | |||||
| * a call to pmap_mapdev() when the bus space code is doing its thing. | |||||
| */ | |||||
| devmap_add_entry(IPQ4018_MEM_UART1_START, IPQ4018_MEM_UART1_SIZE); | |||||
Not Done Inline ActionsI assume this is only needed for early printf? If so it's entirely unsurprising that things explode if you don't reserve it, and the comment could do a better job of pointing at it being that. jrtc27: I assume this is only needed for early printf? If so it's entirely unsurprising that things… | |||||
Done Inline Actions
adrian: > I assume this is only needed for early printf? If so it's entirely unsurprising that things… | |||||
Done Inline ActionsNope, it's required to boot normally! That's what the comment is pointing out. It's actually not needed for early printf. I have a feeling there's something that has crept into the arm boot process which has been hidden because it seems /every/ platform uses devmaps that cover the initial console. :) adrian: Nope, it's required to boot normally! That's what the comment is pointing out. It's actually… | |||||
| return (0); | |||||
| } | |||||
| static void | |||||
| ipq4018_cpu_reset(platform_t plat) | |||||
| { | |||||
| } | |||||
| /* | |||||
| * Early putc routine for EARLY_PRINTF support. To use, add to kernel config: | |||||
| * option SOCDEV_PA=0x07800000 | |||||
| * option SOCDEV_VA=0x07800000 | |||||
| * option EARLY_PRINTF | |||||
| * Resist the temptation to change the #if 0 to #ifdef EARLY_PRINTF here. It | |||||
| * makes sense now, but if multiple SOCs do that it will make early_putc another | |||||
| * duplicate symbol to be eliminated on the path to a generic kernel. | |||||
| */ | |||||
| #if 0 | |||||
impUnsubmitted Not Done Inline ActionsWe generally don't commit #if 0 code to the tree. If EARLY_PRINTF isn't right, then find a better way. Though this code looks very 'early system bringup-y rather than what we'd normally commit to the tree since it's kinda fragile... imp: We generally don't commit #if 0 code to the tree. If EARLY_PRINTF isn't right, then find a… | |||||
ianUnsubmitted Not Done Inline ActionsThis review-comment is just wrong in this case. The code-comment block explains exactly why it must be #if 0, not #if EARLY_PRINTF. ian: This review-comment is just wrong in this case. The code-comment block explains exactly why it… | |||||
impUnsubmitted Not Done Inline ActionsNo. It is right. If 0 is wrong and the comment is wrong on that point. If it is optional, it needs a new option name if EARLY_PRINTF isn't right. imp: No. It is right. If 0 is wrong and the comment is wrong on that point. If it is optional, it… | |||||
impUnsubmitted Not Done Inline ActionsSince this is early bring up, this comment should have "should" read in the RFC sense: if there is a reason to keep it for a while and evolve it as the code matures, that's cool too. imp: Since this is early bring up, this comment should have "should" read in the RFC sense: if there… | |||||
adrianAuthorUnsubmitted Done Inline Actionsi can put another build option in there just to enable it when building this platform? adrian: i can put another build option in there just to enable it when building this platform? | |||||
impUnsubmitted Not Done Inline ActionsFor now, it's fine. Let's wait until things are further along with other soc support for qualcomm imp: For now, it's fine. Let's wait until things are further along with other soc support for… | |||||
ianUnsubmitted Not Done Inline ActionsNo, it is wrong. Look at the existing armv7 code that's checked in already. The SOCs that have maintainers all have early_putc code wrapped in #if 0. For a good reason. If you want to go add soc-specific options for every soc so that #if 0 can be replaced with something like #ifdef RK3288_EARLY_PRINTF, then by all means knock yourself out. But fix the existing code before you start complaining about something not matching existing practice. Also, this code is NOT just for one-time early bringup. It's for every time booting fails in early boot, like when something breaks in loader, or uboot. That's why we leave this stuff in there wrapped in #if 0. ian: No, it is wrong. Look at the existing armv7 code that's checked in already. The SOCs that… | |||||
| void | |||||
| qca_msm_early_putc(int c) | |||||
| { | |||||
| static int is_init = 0; | |||||
| int limit; | |||||
| /* | |||||
| * This must match what's put into SOCDEV_VA. You have to change them | |||||
| * both together. | |||||
| * | |||||
| * XXX TODO I should really go and just make UART_BASE here depend upon | |||||
| * SOCDEV_VA so they move together. | |||||
| */ | |||||
| #define UART_BASE IPQ4018_MEM_UART1_START | |||||
| volatile uint32_t * UART_DM_TF0 = (uint32_t *)(UART_BASE + 0x70); | |||||
| volatile uint32_t * UART_DM_SR = (uint32_t *)(UART_BASE + 0x08); | |||||
| #define UART_DM_SR_TXEMT (1 << 3) | |||||
| #define UART_DM_SR_TXRDY (1 << 2) | |||||
| volatile uint32_t * UART_DM_ISR = (uint32_t *)(UART_BASE + 0x14); | |||||
| volatile uint32_t * UART_DM_CR = (uint32_t *)(UART_BASE + 0x10); | |||||
| #define UART_DM_TX_READY (1 << 7) | |||||
| #define UART_DM_CLEAR_TX_READY 0x300 | |||||
| volatile uint32_t * UART_DM_NO_CHARS_FOR_TX = (uint32_t *)(UART_BASE + 0x40); | |||||
| volatile uint32_t * UART_DM_TFWR = (uint32_t *)(UART_BASE + 0x1c); | |||||
| #define UART_DM_TFW_VALUE 0 | |||||
| volatile uint32_t * UART_DM_IPR = (uint32_t *)(UART_BASE + 0x18); | |||||
| #define UART_DM_STALE_TIMEOUT_LSB 0xf | |||||
| if (is_init == 0) { | |||||
| is_init = 1; | |||||
| *UART_DM_TFWR = UART_DM_TFW_VALUE; | |||||
| wmb(); | |||||
| *UART_DM_IPR = UART_DM_STALE_TIMEOUT_LSB; | |||||
| wmb(); | |||||
| } | |||||
| /* Wait until TXFIFO is empty via ISR */ | |||||
| limit = 100000; | |||||
| if ((*UART_DM_SR & UART_DM_SR_TXEMT) == 0) { | |||||
| while (((*UART_DM_ISR & UART_DM_TX_READY) == 0) && --limit) { | |||||
| /* Note - can't use DELAY here yet, too early */ | |||||
| rmb(); | |||||
| } | |||||
| *UART_DM_CR = UART_DM_CLEAR_TX_READY; | |||||
| wmb(); | |||||
| } | |||||
| /* FIFO is ready. Say we're going to write one byte */ | |||||
| *UART_DM_NO_CHARS_FOR_TX = 1; | |||||
| wmb(); | |||||
| limit = 100000; | |||||
| while (((*UART_DM_SR & UART_DM_SR_TXRDY) == 0) && --limit) { | |||||
| /* Note - can't use DELAY here yet, too early */ | |||||
| rmb(); | |||||
| } | |||||
| /* Put character in first fifo slot */ | |||||
| *UART_DM_TF0 = c; | |||||
| wmb(); | |||||
| } | |||||
| early_putc_t *early_putc = qca_msm_early_putc; | |||||
| #endif | |||||
| static platform_method_t ipq4018_methods[] = { | |||||
| PLATFORMMETHOD(platform_attach, ipq4018_attach), | |||||
| PLATFORMMETHOD(platform_devmap_init, ipq4018_devmap_init), | |||||
| PLATFORMMETHOD(platform_late_init, ipq4018_late_init), | |||||
| PLATFORMMETHOD(platform_cpu_reset, ipq4018_cpu_reset), | |||||
| #ifdef SMP | |||||
| PLATFORMMETHOD(platform_mp_start_ap, ipq4018_mp_start_ap), | |||||
| PLATFORMMETHOD(platform_mp_setmaxid, ipq4018_mp_setmaxid), | |||||
| #endif | |||||
| PLATFORMMETHOD_END, | |||||
| }; | |||||
| FDT_PLATFORM_DEF2(ipq4018, ipq4018_ac58u, "ASUS RT-AC58U", 0, | |||||
| "asus,rt-ac58u", 80); | |||||
FIXME or XXX this and explain *why* the current code doesn't work. Or maybe we should fix the issue like I described on IRC rather than committing this kind of hack (so GENERIC kernels work on this board, for example...).