Page MenuHomeFreeBSD
Differential D32360 Diff 96940 sys/arm64/include/pmap.h

Changeset View

Standalone View

View Options

sys/arm64/include/pmap.h

Show First 20 Lines • Show All 146 Lines • ▼ Show 20 Lines
#define ASID_RESERVED_FOR_EFI 1 #define ASID_RESERVED_FOR_EFI 1
#define ASID_FIRST_AVAILABLE (ASID_RESERVED_FOR_EFI + 1) #define ASID_FIRST_AVAILABLE (ASID_RESERVED_FOR_EFI + 1)
#define ASID_TO_OPERAND_SHIFT 48 #define ASID_TO_OPERAND_SHIFT 48
#define ASID_TO_OPERAND(asid) ({ \ #define ASID_TO_OPERAND(asid) ({ \
KASSERT((asid) != -1, ("invalid ASID")); \ KASSERT((asid) != -1, ("invalid ASID")); \
(uint64_t)(asid) << ASID_TO_OPERAND_SHIFT; \ (uint64_t)(asid) << ASID_TO_OPERAND_SHIFT; \
}) })
#define PMAP_WANT_ACTIVE_CPUS_NAIVE
andrewUnsubmitted
Done
Inline Actions

We could add pm_active to the pmap struct on arm64 at the cost of 2 atomic operations per-process switch and the extra used space in the struct. We may not want to MFC it if we consider pmap_t to be have stable size outside of pmap.c so would be better added later if so.

andrew: We could add `pm_active` to the pmap struct on arm64 at the cost of 2 atomic operations per…
kibAuthorUnsubmitted
Done
Inline Actions

I do not see a point. This would make each context switch to pay two atomics for the benefit of rarely used API. It would be esp. saddle because armv8 indeed does not need to maintain pm_active for TLB invalidations due to availability of broadcast invl instructions.

kib: I do not see a point. This would make each context switch to pay two atomics for the benefit…
andrewUnsubmitted
Done
Inline Actions

Having looked at the other pmap implementations I noticed on powerpc pm_active is managed, but doesn't seem to be currently used (other than by this patch).

andrew: Having looked at the other pmap implementations I noticed on powerpc `pm_active` is managed…
kibAuthorUnsubmitted
Done
Inline Actions

Which makes powerpc another candidate for the common (naive) implementation of pmap_active_cpus().

kib: Which makes powerpc another candidate for the common (naive) implementation of pmap_active_cpus…
extern vm_offset_t virtual_avail; extern vm_offset_t virtual_avail;
extern vm_offset_t virtual_end; extern vm_offset_t virtual_end;
/* /*
* Macros to test if a mapping is mappable with an L1 Section mapping * Macros to test if a mapping is mappable with an L1 Section mapping
* or an L2 Large Page mapping. * or an L2 Large Page mapping.
*/ */
#define L1_MAPPABLE_P(va, pa, size) \ #define L1_MAPPABLE_P(va, pa, size) \
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines