Page MenuHomeFreeBSD
Differential D32359 Diff 96551 usr.sbin/bhyve/pci_emul.h

Changeset View

Standalone View

View Options

usr.sbin/bhyve/pci_emul.h

Show First 20 Lines • Show All 151 Lines • ▼ Show 20 Lines struct {
int table_bar; int table_bar;
int pba_bar; int pba_bar;
uint32_t table_offset; uint32_t table_offset;
int table_count; int table_count;
uint32_t pba_offset; uint32_t pba_offset;
int pba_size; int pba_size;
int function_mask; int function_mask;
struct msix_table_entry *table; /* allocated at runtime */ struct msix_table_entry *table; /* allocated at runtime */
void *pba_page; uint8_t *mapped_addr;
int pba_page_offset; size_t mapped_size;
val_packett.coolUnsubmitted
Not Done
Inline Actions

The removal of this field broke BHYVE_SNAPSHOT.

/usr/src/usr.sbin/bhyve/pci_emul.c:2082:36: error: no member named 'pba_page_offset' in 'struct pci_devinst::(unnamed at /usr/src/usr.sbin/bhyve/pci_emul.h:150:2)'; did you mean 'pba_offset'?
        SNAPSHOT_VAR_OR_LEAVE(pi->pi_msix.pba_page_offset, meta, ret, done);
                                          ^~~~~~~~~~~~~~~
                                          pba_offset
val_packett.cool: The removal of this field broke `BHYVE_SNAPSHOT`. ``` /usr/src/usr.sbin/bhyve/pci_emul.c:2082…
markjAuthorUnsubmitted
Done
Inline Actions

Sorry for the breakage. See https://reviews.freebsd.org/D32523 . Is it expected that snapshots saved by one version of bhyve(8) are restorable by a later one?

markj: Sorry for the breakage. See https://reviews.freebsd.org/D32523 . Is it expected that snapshots…
val_packett.coolUnsubmitted
Not Done
Inline Actions

I have no idea. I just have the option enabled but I haven't ever actually used the functionality yet

val_packett.cool: I have no idea. I just have the option enabled but I haven't ever actually used the…
} pi_msix; } pi_msix;
void *pi_arg; /* devemu-private data */ void *pi_arg; /* devemu-private data */
u_char pi_cfgdata[PCI_REGMAX + 1]; u_char pi_cfgdata[PCI_REGMAX + 1];
struct pcibar pi_bar[PCI_BARMAX + 1]; struct pcibar pi_bar[PCI_BARMAX + 1];
}; };
▲ Show 20 Lines • Show All 138 Lines • Show Last 20 Lines