Changeset View
Changeset View
Standalone View
Standalone View
sys/dev/usb/controller/dwc3.c
/*- | /*- | ||||
* SPDX-License-Identifier: BSD-2-Clause-FreeBSD | * SPDX-License-Identifier: BSD-2-Clause-FreeBSD | ||||
* | * | ||||
* Copyright (c) 2019 Emmanuel Vadot <manu@FreeBSD.Org> | * Copyright (c) 2019 Emmanuel Vadot <manu@FreeBSD.Org> | ||||
* Copyright (c) 2021 Bjoern A. Zeeb <bz@FreeBSD.ORG> | |||||
* | * | ||||
* Redistribution and use in source and binary forms, with or without | * Redistribution and use in source and binary forms, with or without | ||||
* modification, are permitted provided that the following conditions | * modification, are permitted provided that the following conditions | ||||
* are met: | * are met: | ||||
* 1. Redistributions of source code must retain the above copyright | * 1. Redistributions of source code must retain the above copyright | ||||
* notice, this list of conditions and the following disclaimer. | * notice, this list of conditions and the following disclaimer. | ||||
* 2. Redistributions in binary form must reproduce the above copyright | * 2. Redistributions in binary form must reproduce the above copyright | ||||
* notice, this list of conditions and the following disclaimer in the | * notice, this list of conditions and the following disclaimer in the | ||||
* documentation and/or other materials provided with the distribution. | * documentation and/or other materials provided with the distribution. | ||||
* | * | ||||
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND | * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND | ||||
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||||
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE | * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE | ||||
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE | * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE | ||||
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL | * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL | ||||
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS | * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS | ||||
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) | * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) | ||||
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT | * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT | ||||
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY | * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY | ||||
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF | * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF | ||||
* SUCH DAMAGE. | * SUCH DAMAGE. | ||||
* | * | ||||
* $FreeBSD$ | * $FreeBSD$ | ||||
* | |||||
*/ | */ | ||||
#include <sys/cdefs.h> | #include <sys/cdefs.h> | ||||
__FBSDID("$FreeBSD$"); | __FBSDID("$FreeBSD$"); | ||||
#include <sys/param.h> | #include <sys/param.h> | ||||
#include <sys/systm.h> | #include <sys/systm.h> | ||||
#include <sys/bus.h> | #include <sys/bus.h> | ||||
#include <sys/rman.h> | #include <sys/rman.h> | ||||
#include <sys/condvar.h> | #include <sys/condvar.h> | ||||
#include <sys/kernel.h> | #include <sys/kernel.h> | ||||
#include <sys/module.h> | #include <sys/module.h> | ||||
#include <sys/gpio.h> | |||||
#include <machine/bus.h> | #include <machine/bus.h> | ||||
#include <dev/fdt/simplebus.h> | |||||
#include <dev/fdt/fdt_common.h> | |||||
#include <dev/ofw/ofw_bus.h> | |||||
#include <dev/ofw/ofw_bus_subr.h> | |||||
#include <dev/ofw/ofw_subr.h> | |||||
#include <dev/usb/usb.h> | #include <dev/usb/usb.h> | ||||
#include <dev/usb/usbdi.h> | #include <dev/usb/usbdi.h> | ||||
#include <dev/usb/usb_core.h> | #include <dev/usb/usb_core.h> | ||||
#include <dev/usb/usb_busdma.h> | #include <dev/usb/usb_busdma.h> | ||||
#include <dev/usb/usb_process.h> | #include <dev/usb/usb_process.h> | ||||
#include <dev/usb/usb_controller.h> | #include <dev/usb/usb_controller.h> | ||||
#include <dev/usb/usb_bus.h> | #include <dev/usb/usb_bus.h> | ||||
#include <dev/usb/controller/xhci.h> | #include <dev/usb/controller/xhci.h> | ||||
#include <dev/usb/controller/dwc3.h> | #include <dev/usb/controller/dwc3.h> | ||||
#include <dev/extres/clk/clk.h> | |||||
#include <dev/extres/phy/phy_usb.h> | |||||
#include "generic_xhci.h" | #include "generic_xhci.h" | ||||
static struct ofw_compat_data compat_data[] = { | int | ||||
{ "snps,dwc3", 1 }, | snps_dwc3_attach_xhci(struct snps_dwc3_common_softc *csc) | ||||
{ NULL, 0 } | |||||
}; | |||||
struct snps_dwc3_softc { | |||||
struct xhci_softc sc; | |||||
device_t dev; | |||||
char dr_mode[16]; | |||||
struct resource * mem_res; | |||||
bus_space_tag_t bst; | |||||
bus_space_handle_t bsh; | |||||
phandle_t node; | |||||
phy_t usb2_phy; | |||||
phy_t usb3_phy; | |||||
}; | |||||
#define DWC3_WRITE(_sc, _off, _val) \ | |||||
bus_space_write_4(_sc->bst, _sc->bsh, _off, _val) | |||||
#define DWC3_READ(_sc, _off) \ | |||||
bus_space_read_4(_sc->bst, _sc->bsh, _off) | |||||
static int | |||||
snps_dwc3_attach_xhci(device_t dev) | |||||
{ | { | ||||
struct snps_dwc3_softc *snps_sc = device_get_softc(dev); | device_t dev = csc->dev; | ||||
struct xhci_softc *sc = &snps_sc->sc; | struct xhci_softc *xsc = &csc->xsc; | ||||
int err = 0, rid = 0; | int err = 0, rid = 0; | ||||
sc->sc_io_res = snps_sc->mem_res; | xsc->sc_io_res = csc->mem_res; | ||||
sc->sc_io_tag = snps_sc->bst; | xsc->sc_io_tag = csc->bst; | ||||
sc->sc_io_hdl = snps_sc->bsh; | xsc->sc_io_hdl = csc->bsh; | ||||
sc->sc_io_size = rman_get_size(snps_sc->mem_res); | xsc->sc_io_size = rman_get_size(csc->mem_res); | ||||
sc->sc_irq_res = bus_alloc_resource_any(dev, SYS_RES_IRQ, &rid, | xsc->sc_irq_res = bus_alloc_resource_any(dev, SYS_RES_IRQ, &rid, | ||||
RF_SHAREABLE | RF_ACTIVE); | RF_SHAREABLE | RF_ACTIVE); | ||||
if (sc->sc_irq_res == NULL) { | if (xsc->sc_irq_res == NULL) { | ||||
device_printf(dev, "Failed to allocate IRQ\n"); | device_printf(dev, "Failed to allocate IRQ\n"); | ||||
return (ENXIO); | return (ENXIO); | ||||
} | } | ||||
sc->sc_bus.bdev = device_add_child(dev, "usbus", -1); | xsc->sc_bus.bdev = device_add_child(dev, "usbus", -1); | ||||
if (sc->sc_bus.bdev == NULL) { | if (xsc->sc_bus.bdev == NULL) { | ||||
device_printf(dev, "Failed to add USB device\n"); | device_printf(dev, "Failed to add USB device\n"); | ||||
return (ENXIO); | return (ENXIO); | ||||
} | } | ||||
device_set_ivars(sc->sc_bus.bdev, &sc->sc_bus); | device_set_ivars(xsc->sc_bus.bdev, &xsc->sc_bus); | ||||
sprintf(sc->sc_vendor, "Synopsys"); | sprintf(xsc->sc_vendor, "Synopsys"); | ||||
device_set_desc(sc->sc_bus.bdev, "Synopsys"); | device_set_desc(xsc->sc_bus.bdev, "Synopsys"); | ||||
err = bus_setup_intr(dev, sc->sc_irq_res, INTR_TYPE_BIO | INTR_MPSAFE, | err = bus_setup_intr(dev, xsc->sc_irq_res, INTR_TYPE_BIO | INTR_MPSAFE, | ||||
NULL, (driver_intr_t *)xhci_interrupt, sc, &sc->sc_intr_hdl); | NULL, (driver_intr_t *)xhci_interrupt, xsc, &xsc->sc_intr_hdl); | ||||
if (err != 0) { | if (err != 0) { | ||||
device_printf(dev, "Failed to setup IRQ, %d\n", err); | device_printf(dev, "Failed to setup IRQ, %d\n", err); | ||||
sc->sc_intr_hdl = NULL; | xsc->sc_intr_hdl = NULL; | ||||
return (err); | return (err); | ||||
} | } | ||||
err = xhci_init(sc, dev, 1); | err = xhci_init(xsc, dev, 1); | ||||
if (err != 0) { | if (err != 0) { | ||||
device_printf(dev, "Failed to init XHCI, with error %d\n", err); | device_printf(dev, "Failed to init XHCI, with error %d\n", err); | ||||
return (ENXIO); | return (ENXIO); | ||||
} | } | ||||
err = xhci_start_controller(sc); | err = xhci_start_controller(xsc); | ||||
if (err != 0) { | if (err != 0) { | ||||
device_printf(dev, "Failed to start XHCI controller, with error %d\n", err); | device_printf(dev, "Failed to start XHCI controller, with error %d\n", err); | ||||
return (ENXIO); | return (ENXIO); | ||||
} | } | ||||
device_printf(sc->sc_bus.bdev, "trying to attach\n"); | device_printf(xsc->sc_bus.bdev, "trying to attach\n"); | ||||
err = device_probe_and_attach(sc->sc_bus.bdev); | err = device_probe_and_attach(xsc->sc_bus.bdev); | ||||
if (err != 0) { | if (err != 0) { | ||||
device_printf(dev, "Failed to initialize USB, with error %d\n", err); | device_printf(dev, "Failed to initialize USB, with error %d\n", err); | ||||
return (ENXIO); | return (ENXIO); | ||||
} | } | ||||
return (0); | return (0); | ||||
} | } | ||||
#if 0 | #if 0 | ||||
static void | void | ||||
snsp_dwc3_dump_regs(struct snps_dwc3_softc *sc) | snsp_dwc3_dump_regs(struct snps_dwc3_common_softc *csc) | ||||
{ | { | ||||
uint32_t reg; | uint32_t reg; | ||||
reg = DWC3_READ(sc, DWC3_GCTL); | reg = DWC3_READ(csc, DWC3_GCTL); | ||||
device_printf(sc->dev, "GCTL: %x\n", reg); | device_printf(csc->dev, "GCTL: %x\n", reg); | ||||
reg = DWC3_READ(sc, DWC3_GUCTL1); | reg = DWC3_READ(csc, DWC3_GUCTL1); | ||||
device_printf(sc->dev, "GUCTL1: %x\n", reg); | device_printf(csc->dev, "GUCTL1: %x\n", reg); | ||||
reg = DWC3_READ(sc, DWC3_GUSB2PHYCFG0); | reg = DWC3_READ(csc, DWC3_GUSB2PHYCFG0); | ||||
device_printf(sc->dev, "GUSB2PHYCFG0: %x\n", reg); | device_printf(csc->dev, "GUSB2PHYCFG0: %x\n", reg); | ||||
reg = DWC3_READ(sc, DWC3_GUSB3PIPECTL0); | reg = DWC3_READ(csc, DWC3_GUSB3PIPECTL0); | ||||
device_printf(sc->dev, "GUSB3PIPECTL0: %x\n", reg); | device_printf(csc->dev, "GUSB3PIPECTL0: %x\n", reg); | ||||
reg = DWC3_READ(sc, DWC3_DCFG); | reg = DWC3_READ(csc, DWC3_DCFG); | ||||
device_printf(sc->dev, "DCFG: %x\n", reg); | device_printf(csc->dev, "DCFG: %x\n", reg); | ||||
} | } | ||||
#endif | #endif | ||||
static void | void | ||||
manu: This was dropped, is it intentional ? | |||||
Not Done Inline Actionssnsp_dwc3_dump_regs() and snps_dwc3_dump_ctrlparams() were in 2 adjacent #ifdef DWC3_DEBUG sections. bz@ merged them. mw: snsp_dwc3_dump_regs() and snps_dwc3_dump_ctrlparams() were in 2 adjacent #ifdef DWC3_DEBUG… | |||||
Not Done Inline ActionsOops yes :) manu: Oops yes :)
Nevermind, nothing to see here. | |||||
snps_dwc3_reset(struct snps_dwc3_softc *sc) | snps_dwc3_reset(struct snps_dwc3_common_softc *csc) | ||||
{ | { | ||||
uint32_t gctl, phy2, phy3; | uint32_t gctl, phy2, phy3; | ||||
if (sc->usb2_phy) | gctl = DWC3_READ(csc, DWC3_GCTL); | ||||
phy_enable(sc->usb2_phy); | |||||
if (sc->usb3_phy) | |||||
phy_enable(sc->usb3_phy); | |||||
Done Inline ActionsWe do configure the PHYs right before the only call to reset so no need to do it here again. bz: We do configure the PHYs right before the only call to reset so no need to do it here again. | |||||
gctl = DWC3_READ(sc, DWC3_GCTL); | |||||
gctl |= DWC3_GCTL_CORESOFTRESET; | gctl |= DWC3_GCTL_CORESOFTRESET; | ||||
DWC3_WRITE(sc, DWC3_GCTL, gctl); | DWC3_WRITE(csc, DWC3_GCTL, gctl); | ||||
phy2 = DWC3_READ(sc, DWC3_GUSB2PHYCFG0); | phy2 = DWC3_READ(csc, DWC3_GUSB2PHYCFG0); | ||||
phy2 |= DWC3_GUSB2PHYCFG0_PHYSOFTRST; | phy2 |= DWC3_GUSB2PHYCFG0_PHYSOFTRST; | ||||
DWC3_WRITE(sc, DWC3_GUSB2PHYCFG0, phy2); | DWC3_WRITE(csc, DWC3_GUSB2PHYCFG0, phy2); | ||||
phy3 = DWC3_READ(sc, DWC3_GUSB3PIPECTL0); | phy3 = DWC3_READ(csc, DWC3_GUSB3PIPECTL0); | ||||
phy3 |= DWC3_GUSB3PIPECTL0_PHYSOFTRST; | phy3 |= DWC3_GUSB3PIPECTL0_PHYSOFTRST; | ||||
DWC3_WRITE(sc, DWC3_GUSB3PIPECTL0, phy3); | DWC3_WRITE(csc, DWC3_GUSB3PIPECTL0, phy3); | ||||
DELAY(1000); | DELAY(1000); | ||||
phy2 &= ~DWC3_GUSB2PHYCFG0_PHYSOFTRST; | phy2 &= ~DWC3_GUSB2PHYCFG0_PHYSOFTRST; | ||||
DWC3_WRITE(sc, DWC3_GUSB2PHYCFG0, phy2); | DWC3_WRITE(csc, DWC3_GUSB2PHYCFG0, phy2); | ||||
phy3 &= ~DWC3_GUSB3PIPECTL0_PHYSOFTRST; | phy3 &= ~DWC3_GUSB3PIPECTL0_PHYSOFTRST; | ||||
DWC3_WRITE(sc, DWC3_GUSB3PIPECTL0, phy3); | DWC3_WRITE(csc, DWC3_GUSB3PIPECTL0, phy3); | ||||
gctl &= ~DWC3_GCTL_CORESOFTRESET; | gctl &= ~DWC3_GCTL_CORESOFTRESET; | ||||
DWC3_WRITE(sc, DWC3_GCTL, gctl); | DWC3_WRITE(csc, DWC3_GCTL, gctl); | ||||
} | } | ||||
static void | void | ||||
snps_dwc3_configure_host(struct snps_dwc3_softc *sc) | snps_dwc3_configure_host(struct snps_dwc3_common_softc *csc) | ||||
{ | { | ||||
uint32_t reg; | uint32_t reg; | ||||
reg = DWC3_READ(sc, DWC3_GCTL); | reg = DWC3_READ(csc, DWC3_GCTL); | ||||
reg &= ~DWC3_GCTL_PRTCAPDIR_MASK; | reg &= ~DWC3_GCTL_PRTCAPDIR_MASK; | ||||
reg |= DWC3_GCTL_PRTCAPDIR_HOST; | reg |= DWC3_GCTL_PRTCAPDIR_HOST; | ||||
DWC3_WRITE(sc, DWC3_GCTL, reg); | DWC3_WRITE(csc, DWC3_GCTL, reg); | ||||
} | } | ||||
static void | void | ||||
snps_dwc3_configure_phy(struct snps_dwc3_softc *sc) | snps_dwc3_do_quirks(struct snps_dwc3_common_softc *csc) | ||||
{ | { | ||||
char *phy_type; | |||||
uint32_t reg; | uint32_t reg; | ||||
int nphy_types; | |||||
phy_type = NULL; | reg = DWC3_READ(csc, DWC3_GUSB2PHYCFG0); | ||||
nphy_types = OF_getprop_alloc(sc->node, "phy_type", (void **)&phy_type); | if (device_has_property(csc->dev, "snps,dis-u2-freeclk-exists-quirk")) | ||||
if (nphy_types <= 0) | |||||
return; | |||||
reg = DWC3_READ(sc, DWC3_GUSB2PHYCFG0); | |||||
if (strncmp(phy_type, "utmi_wide", 9) == 0) { | |||||
reg &= ~(DWC3_GUSB2PHYCFG0_PHYIF | DWC3_GUSB2PHYCFG0_USBTRDTIM(0xf)); | |||||
reg |= DWC3_GUSB2PHYCFG0_PHYIF | | |||||
DWC3_GUSB2PHYCFG0_USBTRDTIM(DWC3_GUSB2PHYCFG0_USBTRDTIM_16BITS); | |||||
} else { | |||||
reg &= ~(DWC3_GUSB2PHYCFG0_PHYIF | DWC3_GUSB2PHYCFG0_USBTRDTIM(0xf)); | |||||
reg |= DWC3_GUSB2PHYCFG0_PHYIF | | |||||
DWC3_GUSB2PHYCFG0_USBTRDTIM(DWC3_GUSB2PHYCFG0_USBTRDTIM_8BITS); | |||||
} | |||||
DWC3_WRITE(sc, DWC3_GUSB2PHYCFG0, reg); | |||||
OF_prop_free(phy_type); | |||||
} | |||||
static void | |||||
snps_dwc3_do_quirks(struct snps_dwc3_softc *sc) | |||||
{ | |||||
uint32_t reg; | |||||
reg = DWC3_READ(sc, DWC3_GUSB2PHYCFG0); | |||||
if (OF_hasprop(sc->node, "snps,dis-u2-freeclk-exists-quirk")) | |||||
reg &= ~DWC3_GUSB2PHYCFG0_U2_FREECLK_EXISTS; | reg &= ~DWC3_GUSB2PHYCFG0_U2_FREECLK_EXISTS; | ||||
else | else | ||||
reg |= DWC3_GUSB2PHYCFG0_U2_FREECLK_EXISTS; | reg |= DWC3_GUSB2PHYCFG0_U2_FREECLK_EXISTS; | ||||
if (OF_hasprop(sc->node, "snps,dis_u2_susphy_quirk")) | if (device_has_property(csc->dev, "snps,dis_u2_susphy_quirk")) | ||||
reg &= ~DWC3_GUSB2PHYCFG0_SUSPENDUSB20; | reg &= ~DWC3_GUSB2PHYCFG0_SUSPENDUSB20; | ||||
else | else | ||||
reg |= DWC3_GUSB2PHYCFG0_SUSPENDUSB20; | reg |= DWC3_GUSB2PHYCFG0_SUSPENDUSB20; | ||||
if (OF_hasprop(sc->node, "snps,dis_enblslpm_quirk")) | if (device_has_property(csc->dev, "snps,dis_enblslpm_quirk")) | ||||
reg &= ~DWC3_GUSB2PHYCFG0_ENBLSLPM; | reg &= ~DWC3_GUSB2PHYCFG0_ENBLSLPM; | ||||
else | else | ||||
reg |= DWC3_GUSB2PHYCFG0_ENBLSLPM; | reg |= DWC3_GUSB2PHYCFG0_ENBLSLPM; | ||||
DWC3_WRITE(sc, DWC3_GUSB2PHYCFG0, reg); | DWC3_WRITE(csc, DWC3_GUSB2PHYCFG0, reg); | ||||
reg = DWC3_READ(sc, DWC3_GUCTL1); | reg = DWC3_READ(csc, DWC3_GUCTL1); | ||||
if (OF_hasprop(sc->node, "snps,dis-tx-ipgap-linecheck-quirk")) | if (device_has_property(csc->dev, "snps,dis-tx-ipgap-linecheck-quirk")) | ||||
reg |= DWC3_GUCTL1_TX_IPGAP_LINECHECK_DIS; | reg |= DWC3_GUCTL1_TX_IPGAP_LINECHECK_DIS; | ||||
DWC3_WRITE(sc, DWC3_GUCTL1, reg); | DWC3_WRITE(csc, DWC3_GUCTL1, reg); | ||||
if (OF_hasprop(sc->node, "snps,dis-del-phy-power-chg-quirk")) { | reg = DWC3_READ(csc, DWC3_GUSB3PIPECTL0); | ||||
reg = DWC3_READ(sc, DWC3_GUSB3PIPECTL0); | if (device_has_property(csc->dev, "snps,dis-del-phy-power-chg-quirk")) | ||||
reg |= DWC3_GUSB3PIPECTL0_DELAYP1TRANS; | reg |= DWC3_GUSB3PIPECTL0_DELAYP1TRANS; | ||||
DWC3_WRITE(sc, DWC3_GUSB3PIPECTL0, reg); | if (device_has_property(csc->dev, "snps,dis_rxdet_inp3_quirk")) | ||||
reg |= DWC3_GUSB3PIPECTL0_DISRXDETINP3; | |||||
mwUnsubmitted Done Inline ActionsThis is a separate functional change. Please move to a separate smaller commit. mw: This is a separate functional change. Please move to a separate smaller commit. | |||||
DWC3_WRITE(csc, DWC3_GUSB3PIPECTL0, reg); | |||||
} | } | ||||
} | |||||
static int | int | ||||
snps_dwc3_probe(device_t dev) | snps_dwc3_probe_common(device_t dev) | ||||
{ | { | ||||
struct snps_dwc3_softc *sc; | char dr_mode[16]; | ||||
ssize_t s; | |||||
if (!ofw_bus_status_okay(dev)) | s = device_get_property(dev, "dr_mode", dr_mode, sizeof(dr_mode)); | ||||
if (s == -1) { | |||||
device_printf(dev, "Cannot determine dr_mode\n"); | |||||
return (ENXIO); | return (ENXIO); | ||||
} | |||||
Done Inline ActionsThis is needed now (again) as ACPI only copies 4 bytes for "host" and does not terminate the string. bz: This is needed now (again) as ACPI only copies 4 bytes for "host" and does not terminate the… | |||||
Done Inline ActionsWould: char dr_mode[16] = {0}; declaration work instead of memset? mw: Would:
char dr_mode[16] = {0};
declaration work instead of memset? | |||||
if (ofw_bus_search_compatible(dev, compat_data)->ocd_data == 0) | if (strcmp(dr_mode, "host") != 0) { | ||||
device_printf(dev, "Found dr_mode '%s' but only " | |||||
"'host' supported.\n", dr_mode); | |||||
return (ENXIO); | return (ENXIO); | ||||
sc = device_get_softc(dev); | |||||
sc->node = ofw_bus_get_node(dev); | |||||
OF_getprop(sc->node, "dr_mode", sc->dr_mode, sizeof(sc->dr_mode)); | |||||
if (strcmp(sc->dr_mode, "host") != 0) { | |||||
device_printf(dev, "Only host mode is supported\n"); | |||||
return (ENXIO); | |||||
} | } | ||||
device_set_desc(dev, "Synopsys Designware DWC3"); | device_set_desc(dev, "Synopsys Designware DWC3"); | ||||
return (BUS_PROBE_DEFAULT); | return (BUS_PROBE_DEFAULT); | ||||
} | } | ||||
Done Inline ActionsWe could move the entire PHY bits into snps_dwc3_configure_phy() if we wanted now. bz: We could move the entire PHY bits into snps_dwc3_configure_phy() if we wanted now. | |||||
static int | |||||
snps_dwc3_attach(device_t dev) | |||||
{ | |||||
struct snps_dwc3_softc *sc; | |||||
int rid = 0; | |||||
sc = device_get_softc(dev); | |||||
sc->dev = dev; | |||||
sc->mem_res = bus_alloc_resource_any(dev, SYS_RES_MEMORY, &rid, | |||||
RF_ACTIVE); | |||||
if (sc->mem_res == NULL) { | |||||
device_printf(dev, "Failed to map memory\n"); | |||||
return (ENXIO); | |||||
} | |||||
sc->bst = rman_get_bustag(sc->mem_res); | |||||
sc->bsh = rman_get_bushandle(sc->mem_res); | |||||
if (bootverbose) | |||||
device_printf(dev, "snps id: %x\n", DWC3_READ(sc, DWC3_GSNPSID)); | |||||
/* Get the phys */ | |||||
phy_get_by_ofw_name(dev, sc->node, "usb2-phy", &sc->usb2_phy); | |||||
phy_get_by_ofw_name(dev, sc->node, "usb3-phy", &sc->usb3_phy); | |||||
snps_dwc3_reset(sc); | |||||
snps_dwc3_configure_host(sc); | |||||
snps_dwc3_configure_phy(sc); | |||||
snps_dwc3_do_quirks(sc); | |||||
#if 0 | |||||
snsp_dwc3_dump_regs(sc); | |||||
#endif | |||||
snps_dwc3_attach_xhci(dev); | |||||
return (0); | |||||
} | |||||
static device_method_t snps_dwc3_methods[] = { | |||||
/* Device interface */ | |||||
DEVMETHOD(device_probe, snps_dwc3_probe), | |||||
DEVMETHOD(device_attach, snps_dwc3_attach), | |||||
DEVMETHOD_END | |||||
}; | |||||
static driver_t snps_dwc3_driver = { | |||||
"xhci", | |||||
snps_dwc3_methods, | |||||
sizeof(struct snps_dwc3_softc) | |||||
}; | |||||
static devclass_t snps_dwc3_devclass; | |||||
DRIVER_MODULE(snps_dwc3, simplebus, snps_dwc3_driver, snps_dwc3_devclass, 0, 0); | |||||
MODULE_DEPEND(snps_dwc3, xhci, 1, 1, 1); |
This was dropped, is it intentional ?