Changeset View
Changeset View
Standalone View
Standalone View
sys/arm/arm/nexus.c
Context not available. | |||||
static int nexus_print_child(device_t, device_t); | static int nexus_print_child(device_t, device_t); | ||||
static device_t nexus_add_child(device_t, u_int, const char *, int); | static device_t nexus_add_child(device_t, u_int, const char *, int); | ||||
static struct resource *nexus_alloc_resource(device_t, device_t, int, int *, | static struct resource *nexus_alloc_resource(device_t, device_t, int, int *, | ||||
u_long, u_long, u_long, u_int); | rman_res_t, rman_res_t, rman_res_t, u_int); | ||||
static int nexus_activate_resource(device_t, device_t, int, int, | static int nexus_activate_resource(device_t, device_t, int, int, | ||||
struct resource *); | struct resource *); | ||||
#ifdef ARM_INTRNG | #ifdef ARM_INTRNG | ||||
Context not available. | |||||
{ | { | ||||
mem_rman.rm_start = 0; | mem_rman.rm_start = 0; | ||||
mem_rman.rm_end = ~0ul; | mem_rman.rm_end = ~0; | ||||
andrew: Why not `RM_MIN_START` & `RM_MAX_END`? | |||||
Not Done Inline ActionsBecause I didn't want to change every single instance of 0/~0 to RM_MIN_START and RM_MAX_END. I even considered not even adding those #defines. jhibbits: Because I didn't want to change every single instance of 0/~0 to RM_MIN_START and RM_MAX_END. | |||||
mem_rman.rm_type = RMAN_ARRAY; | mem_rman.rm_type = RMAN_ARRAY; | ||||
mem_rman.rm_descr = "I/O memory addresses"; | mem_rman.rm_descr = "I/O memory addresses"; | ||||
if (rman_init(&mem_rman) || rman_manage_region(&mem_rman, 0, ~0)) | if (rman_init(&mem_rman) || rman_manage_region(&mem_rman, 0, ~0)) | ||||
Not Done Inline ActionsThis rman_manage_region needs to be updated to use BUS_SPACE_MAXADDR or it will fail. It is actually more important for rman_manage_region() to be correct as that determines the "available" address space. jhb: This rman_manage_region needs to be updated to use BUS_SPACE_MAXADDR or it will fail. It is… | |||||
Context not available. | |||||
*/ | */ | ||||
static struct resource * | static struct resource * | ||||
nexus_alloc_resource(device_t bus, device_t child, int type, int *rid, | nexus_alloc_resource(device_t bus, device_t child, int type, int *rid, | ||||
u_long start, u_long end, u_long count, u_int flags) | rman_res_t start, rman_res_t end, rman_res_t count, u_int flags) | ||||
{ | { | ||||
struct resource *rv; | struct resource *rv; | ||||
struct rman *rm; | struct rman *rm; | ||||
Context not available. | |||||
Done Inline ActionsThis would seem to be better handled by a proper rm_end in the rman instead when it is created (similar to what kib@ noted for x86). jhb: This would seem to be better handled by a proper rm_end in the rman instead when it is created… | |||||
Not Done Inline ActionsThis check is still here? I think it should be unnecessary after the nexus changes. jhb: This check is still here? I think it should be unnecessary after the nexus changes. |
Why not RM_MIN_START & RM_MAX_END?