Changeset View
Standalone View
sys/sys/types.h
Context not available. | |||||
typedef __vm_pindex_t vm_pindex_t; | typedef __vm_pindex_t vm_pindex_t; | ||||
typedef __vm_size_t vm_size_t; | typedef __vm_size_t vm_size_t; | ||||
typedef __rman_res_t rman_res_t; | |||||
kib: Do you see a need for the type outside the kernel ? | |||||
Not Done Inline ActionsI don't think so. Are resources or resource ranges ever exported to user space? jhibbits: I don't think so. Are resources or resource ranges ever exported to user space? | |||||
Not Done Inline ActionsMay be by devinfo(3) ? At least man page and devinfo.h use unsigned long for start/size/end. In the comment above, I mean, shouldn't the rman_res_t braced with #ifdef _KERNEL ? kib: May be by devinfo(3) ? At least man page and devinfo.h use unsigned long for start/size/end. | |||||
Not Done Inline ActionsHmm, you're right. I hadn't even looked at userspace usage. Right now, with the patch, devinfo would be broken, to a degree. Since I don't know the prevalence of this, I don't know how broken it actually is (how many devinfo consumers are there, and right now who beyond powerpc would be broken by this?) Would it be acceptable to tackle that in a separate commit, or should it come as a package deal? jhibbits: Hmm, you're right. I hadn't even looked at userspace usage. Right now, with the patch… | |||||
Not Done Inline ActionsI would do it as a package deal. I don't know if libdevinfo is used in ports at all. Hmm, the sysctls that back it will bail if the version is bumped, but they just fail outright. This means you could do a library bump of libdevinfo (assuming it doesn't have versioned symbols) and the result is that old programs on a new kernel will just not work. The interface to the kernel doesn't seem to (easily) permit adding backwards compat either. I think the KBI change in HEAD means that this isn't going into a stable branch anyway, but I don't know if we care about old programs (or 10.x jails) using libdevinfo. Maybe do a ports exp-run with a hack patch to unhook devinfo/libdevinfo from the build just to hide libdevinfo and see how many ports use it? jhb: I would do it as a package deal. I don't know if libdevinfo is used in ports at all. Hmm, the… | |||||
#ifdef _KERNEL | #ifdef _KERNEL | ||||
typedef int boolean_t; | typedef int boolean_t; | ||||
typedef struct device *device_t; | typedef struct device *device_t; | ||||
Context not available. |
Do you see a need for the type outside the kernel ?