Differential D31603 Diff 94119 lib/libc/string/mempcpy.c

Changeset View

Standalone View

lib/libc/string/mempcpy.c

	Show All 26 Lines
	* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY			* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
	* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF			* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
	* SUCH DAMAGE.			* SUCH DAMAGE.
	*/			*/

	#include <sys/cdefs.h>			#include <sys/cdefs.h>
	__FBSDID("$FreeBSD$");			__FBSDID("$FreeBSD$");

				#include <sys/types.h>

	#include <string.h>			#include <string.h>

	void *			void *
	mempcpy(void __restrict dst, const void __restrict src, size_t len)			mempcpy(void * __restrict dst, const void * __restrict src, size_t len)
				dimUnsubmitted Done Inline Actions I'm not sure what is gained here except more characters? The end cast to `void ` is not needed, it is implicit because of the return type. Changing the inner cast from `char ` to `unsigned char ` also does not have any effect, since the pointers are never dereferenced. The original seems clearer to me, and less obfuscated. dim:* I'm not sure what is gained here except more characters? The end cast to `void *` is not needed…
				jrtc27Unsubmitted Done Inline Actions Why? unsigned isn't needed, and implicit casts to `void ` are legal C. jrtc27:* Why? unsigned isn't needed, and implicit casts to `void *` are legal C.
				jrtc27Unsubmitted Done Inline Actions Comments still apply; zero reason to change the char to u_char below. Then you don't need to include a new header too. jrtc27: Comments still apply; zero reason to change the char to u_char below. Then you don't need to…
				gfunni234_gmail.comAuthorUnsubmitted Done Inline Actions is char * always one byte? if so then you are right gfunni234_gmail.com: is char * always one byte? if so then you are right
				jrtc27Unsubmitted Done Inline Actions `sizeof(char) == sizeof(signed char) == sizeof(unsigned char) == 1` by definition jrtc27: `sizeof(char) == sizeof(signed char) == sizeof(unsigned char) == 1` by definition
	{			{
	return ((char *)memcpy(dst, src, len) + len);			return ((u_char *)memcpy(dst, src, len) + len);
	}			}