Changeset View
Changeset View
Standalone View
Standalone View
lib/libc/posix1e/acl_cmp_np.c
- This file was added.
/*- | |||||
* SPDX-License-Identifier: BSD-2-Clause-FreeBSD | |||||
* | |||||
* Copyright (c) 2021 Gleb Popov | |||||
* All rights reserved. | |||||
* | |||||
* Redistribution and use in source and binary forms, with or without | |||||
* modification, are permitted provided that the following conditions | |||||
* are met: | |||||
* 1. Redistributions of source code must retain the above copyright | |||||
* notice, this list of conditions and the following disclaimer. | |||||
* 2. Redistributions in binary form must reproduce the above copyright | |||||
* notice, this list of conditions and the following disclaimer in the | |||||
* documentation and/or other materials provided with the distribution. | |||||
* | |||||
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND | |||||
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | |||||
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE | |||||
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE | |||||
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL | |||||
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS | |||||
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) | |||||
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT | |||||
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY | |||||
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF | |||||
* SUCH DAMAGE. | |||||
*/ | |||||
/* | |||||
* acl_cmp_np: Compare two ACL's. | |||||
*/ | |||||
#include <sys/cdefs.h> | |||||
__FBSDID("$FreeBSD$"); | |||||
#include <sys/acl.h> | |||||
#include <sys/errno.h> | |||||
#include "acl_support.h" | |||||
/* | |||||
* returns 0 if acl_t's are identical, 1 otherwise | |||||
*/ | |||||
int | |||||
acl_cmp_np(acl_t acl1, acl_t acl2) | |||||
{ | |||||
if (acl1 == NULL || acl2 == NULL) { | |||||
errno = EINVAL; | |||||
kib: Opening brace should be on the previous line.
Why do you check for NULL? This is untypical… | |||||
Done Inline ActionsNo idea, to be honest. This is what Linux libacl does, so I just replicated its behavior. Should I remove it? arrowd: No idea, to be honest. This is what Linux libacl does, so I just replicated its behavior. | |||||
Done Inline ActionsIf Linux does that ok. C code cannot validate a pointer, the check for NULL sometimes makes sense when API interprets it as absence of the value. kib: If Linux does that ok. C code cannot validate a pointer, the check for NULL sometimes makes… | |||||
return (-1); | |||||
} | |||||
if (_acl_brand(acl1) != _acl_brand(acl2)) | |||||
return (1); | |||||
Done Inline Actionsreturn (1); style requires () around return value kib: `return (1);` style requires () around return value | |||||
Done Inline ActionsI did not marked all places with the style problems. Issues I pointed out are systematic. For instance the return on the next line needs (). And '{' the placement is not fixed, it is also everywhere. kib: I did not marked all places with the style problems. Issues I pointed out are systematic. For… | |||||
Done Inline ActionsRight. I feel so stupid about this, what I have been thinking? -_\ arrowd: Right. I feel so stupid about this, what I have been thinking? -_\
The style should be fine now. | |||||
return (_acl_differs(acl1, acl2)); | |||||
} |
Opening brace should be on the previous line.
Why do you check for NULL? This is untypical for libc interfaces.