Changeset View
Standalone View
games/lwjgl3/Makefile
- This file was added.
# Created by: Cameron Katri <me@cameronkatri.com> | |||||
PORTNAME= lwjgl3 | |||||
DISTVERSION= 3.2.2 | |||||
DISTVERSIONSUFFIX= -full | |||||
koobs: 3.2.3 is out, can you rebase in your fork and update patch here? | |||||
Done Inline ActionsI will look into it, I am pretty swamped right now, hopefully I will be able to get to it soon. me_cameronkatri.com: I will look into it, I am pretty swamped right now, hopefully I will be able to get to it soon. | |||||
CATEGORIES= games java | |||||
MASTER_SITES= https://github.com/CRKatri/lwjgl3/releases/download/${DISTVERSION}-freebsd-1/ | |||||
DISTNAME= lwjgl3-${DISTVERSION}-full | |||||
Not Done Inline ActionsIs the aim to upstream this fork in the short term? Are there any open issues / pr's or discussions upstream re FreeBSD support? koobs: Is the aim to upstream this fork in the short term? Are there any open issues / pr's or… | |||||
Done Inline ActionsAccording to previous discussions, upstream is not interesting in it unless they get a FreeBSD runner for their CI, but hasn't taken up any of the offers. me_cameronkatri.com: According to previous discussions, upstream is not interesting in it unless they get a FreeBSD… | |||||
Not Done Inline ActionsThey added FreeBSD amd64 support: https://github.com/LWJGL/lwjgl3/issues/421 vvd: They added FreeBSD amd64 support: https://github.com/LWJGL/lwjgl3/issues/421
But build stage… | |||||
Done Inline ActionsOh, that's great! Unfortunately I don't have the bandwidth to fix this diff and make it proper with upstream so I'm gonna close this diff and let someone else do it proper. me_cameronkatri.com: Oh, that's great! Unfortunately I don't have the bandwidth to fix this diff and make it proper… | |||||
MAINTAINER= me@cameronkatri.com | |||||
COMMENT= Lightweight Java Game Library 3 | |||||
LICENSE= BSD3CLAUSE | |||||
Not Done Inline ActionsAdd LICENSE_FILE when one is provided in the distribution files koobs: Add LICENSE_FILE when one is provided in the distribution files | |||||
ONLY_FOR_ARCHS= amd64 | |||||
Not Done Inline ActionsDoes this need to be the static library? Whats the nature of the linking for this and is it required? koobs: Does this need to be the static library? Whats the nature of the linking for this and is it… | |||||
Done Inline Actionsdevel/dyncall only has a static library me_cameronkatri.com: devel/dyncall only has a static library | |||||
Done Inline ActionsUSES=pkgconf arrowd: `USES=pkgconf` | |||||
BUILD_DEPENDS= ${LOCALBASE}/lib/libdyncall_s.a:devel/dyncall \ | |||||
tcbernerUnsubmitted Done Inline Actions^ no need to specify a dependency on the same port more than once tcberner: ^ no need to specify a dependency on the same port more than once | |||||
${LOCALBASE}/lib/libdyncallback_s.a:devel/dyncall \ | |||||
${LOCALBASE}/lib/libdynload_s.a:devel/dyncall | |||||
Not Done Inline ActionsMinor nit: fix extra whitespace koobs: Minor nit: fix extra whitespace | |||||
LIB_DEPENDS= libgtk-3.so:x11-toolkits/gtk30 \ | |||||
tcbernerUnsubmitted Done Inline Actionsdon't use LIB_DEPENDS to depend on glib, gtk, use USES=gnome combined with USE_GNOME=... tcberner: don't use `LIB_DEPENDS` to depend on glib, gtk, use `USES=gnome` combined with `USE_GNOME=...` | |||||
libgobject-2.0.so:devel/glib20 \ | |||||
Done Inline Actionspkgconfig, not pkgconf :) tcberner: `pkgconfig`, not `pkgconf` :) | |||||
libglib-2.0.so:devel/glib20 \ | |||||
libglfw.so:graphics/glfw \ | |||||
libopenal.so:audio/openal-soft | |||||
USES= gl | |||||
USE_GL= gl | |||||
USE_JAVA= yes | |||||
Not Done Inline ActionsIs this required, whats is it for? Does it stop the build from using the network? koobs: Is this required, whats is it for? Does it stop the build from using the network? | |||||
Done Inline ActionsYes. me_cameronkatri.com: Yes. | |||||
USE_ANT= yes | |||||
ALL_TARGET= all release | |||||
Done Inline Actions^ you can run portclippy from ports-mgmt/portfmt to get the Makefile order a bit more "standard" conform. tcberner: ^ you can run `portclippy` from `ports-mgmt/portfmt` to get the Makefile order a bit more… | |||||
MAKE_ENV+= LWJGL_BUILD_OFFLINE=true | |||||
.include <bsd.port.pre.mk> | |||||
Done Inline Actions^ I don't quite see at the moment why you would need to include bsd.port.pre.mk, instead of simply using bsd.port.mk at the bottom. tcberner: ^ I don't quite see at the moment why you would need to include `bsd.port.pre.mk`, instead of… | |||||
do-install: | |||||
@${MKDIR} ${STAGEDIR}${JAVAJARDIR}/${PORTNAME} | |||||
@${MKDIR} ${STAGEDIR}${PREFIX}/lib/${PORTNAME} | |||||
${RM} -f ${WRKSRC}/bin/RELEASE/lwjgl*/lwjgl*-sources.jar \ | |||||
tcbernerUnsubmitted Done Inline Actions^it feels a bit weird, to rm in install. tcberner: ^it feels a bit weird, to rm in install. | |||||
me_cameronkatri.comAuthorUnsubmitted Done Inline ActionsWhen should I get rid of these files then? me_cameronkatri.com: When should I get rid of these files then? | |||||
tcbernerUnsubmitted Not Done Inline Actionspost-extract possibly tcberner: `post-extract` possibly | |||||
otisUnsubmitted Not Done Inline Actions
If those files are needed for build but not afterwards, then do-install seems OK. otis: > `post-extract` possibly
If those files are needed for build but not afterwards, then `do… | |||||
me_cameronkatri.comAuthorUnsubmitted Done Inline ActionsThese files are generated by the release target in do-build, so they don’t exist then. me_cameronkatri.com: These files are generated by the `release` target in `do-build`, so they don’t exist then. | |||||
${WRKSRC}/bin/RELEASE/lwjgl*/lwjgl*-javadoc.jar \ | |||||
${WRKSRC}/bin/RELEASE/lwjgl*/lwjgl*-linux.jar | |||||
.for x in ${WRKSRC}/bin/RELEASE/lwjgl*/*.jar | |||||
${INSTALL_DATA} ${WRKSRC}${x} ${STAGEDIR}${JAVAJARDIR}/${PORTNAME}/ | |||||
.endfor | |||||
.for x in ${WRKSRC}/bin/RELEASE/lwjgl*/*license.txt | |||||
${INSTALL_DATA} ${WRKSRC}${x} ${STAGEDIR}${JAVAJARDIR}/${PORTNAME}/ | |||||
.endfor | |||||
.for x in ${WRKSRC}/bin/libs/*.so | |||||
${INSTALL_LIB} ${WRKSRC}${x} ${STAGEDIR}${PREFIX}/lib/${PORTNAME}/ | |||||
.endfor | |||||
.include <bsd.port.post.mk> |
3.2.3 is out, can you rebase in your fork and update patch here?