Changeset View
Changeset View
Standalone View
Standalone View
sys/dev/uart/uart_dev_ns8250.c
| Context not available. | |||||
| * Check whether uart requires to read USR reg when IIR_BUSY and | * Check whether uart requires to read USR reg when IIR_BUSY and | ||||
| * has broken txfifo. | * has broken txfifo. | ||||
| */ | */ | ||||
| ns8250->busy_detect = ofw_bus_is_compatible(sc->sc_dev, "snps,dw-apb-uart"); | |||||
| node = ofw_bus_get_node(sc->sc_dev); | node = ofw_bus_get_node(sc->sc_dev); | ||||
| if ((OF_getencprop(node, "busy-detect", &cell, sizeof(cell))) > 0) | |||||
| ns8250->busy_detect = cell ? 1 : 0; | |||||
| if ((OF_getencprop(node, "broken-txfifo", &cell, sizeof(cell))) > 0) | if ((OF_getencprop(node, "broken-txfifo", &cell, sizeof(cell))) > 0) | ||||
andrew: Can you keep this for the case of a new kernel with an old device tree. It helps to keep… | |||||
Not Done Inline ActionsCorrected. bsz_semihalf.com: Corrected. | |||||
Not Done Inline ActionsWhen committed this should read something like the following. /* XXX: This is kept for a short time for compatibility with older device trees */ andrew: When committed this should read something like the following.
/* XXX: This is kept for a… | |||||
| broken_txfifo = cell ? 1 : 0; | broken_txfifo = cell ? 1 : 0; | ||||
| #endif | #endif | ||||
| Context not available. | |||||
Can you keep this for the case of a new kernel with an old device tree. It helps to keep compatibility around where possible to give people a chance to get both in sync.