Changeset View
Changeset View
Standalone View
Standalone View
sys/arm64/include/cpu.h
Show First 20 Lines • Show All 201 Lines • ▼ Show 20 Lines | arm64_address_translate_ ##stage (uint64_t addr) \ | ||||
return (ret); \ | return (ret); \ | ||||
} | } | ||||
ADDRESS_TRANSLATE_FUNC(s1e0r) | ADDRESS_TRANSLATE_FUNC(s1e0r) | ||||
ADDRESS_TRANSLATE_FUNC(s1e0w) | ADDRESS_TRANSLATE_FUNC(s1e0w) | ||||
ADDRESS_TRANSLATE_FUNC(s1e1r) | ADDRESS_TRANSLATE_FUNC(s1e1r) | ||||
ADDRESS_TRANSLATE_FUNC(s1e1w) | ADDRESS_TRANSLATE_FUNC(s1e1w) | ||||
/* retrieve the maximum valid physical address */ | |||||
extern uint64_t get_physaddr_max(void); | |||||
mhorne: nit: we typically don't add `extern` to function declarations. | |||||
Done Inline ActionsThat can be removed on commit. I'm in the crowd which thinks functions defaulting to external, but variables defaulting to static is a language problem. The better option would have been defaulting to static for everything. ehem_freebsd_m5p.com: That can be removed on commit. I'm in the crowd which thinks functions defaulting to external… | |||||
#endif | #endif | ||||
#endif /* !_MACHINE_CPU_H_ */ | #endif /* !_MACHINE_CPU_H_ */ |
nit: we typically don't add extern to function declarations.