Page MenuHomeFreeBSD
Differential D30061 Diff 90727 ports-mgmt/portlint/src/portlint.pl

Changeset View

Standalone View

View Options

ports-mgmt/portlint/src/portlint.pl

Show First 20 Lines • Show All 3,442 Lines • ▼ Show 20 LinesTEST_DEPENDS FETCH_DEPENDS DEPENDS_TARGET
} else { } else {
print "OK: seen NO_WRKSUBDIR, checking value of WRKSRC.\n" print "OK: seen NO_WRKSUBDIR, checking value of WRKSRC.\n"
if ($verbose); if ($verbose);
if ($wrksrc eq 'work' || $wrksrc =~ /^$[\{\(]WRKDIR[\}\)]/) { if ($wrksrc eq 'work' || $wrksrc =~ /^$[\{\(]WRKDIR[\}\)]/) {
&perror("WARN", $file, -1, "definition of WRKSRC not necessary. ". &perror("WARN", $file, -1, "definition of WRKSRC not necessary. ".
"WRKSRC is \${WRKDIR} by default."); "WRKSRC is \${WRKDIR} by default.");
} }
} }
# check RESTRICTED/NO_CDROM/NO_PACKAGE
print "OK: checking RESTRICTED/NO_CDROM/NO_PACKAGE.\n" if ($verbose);
my $lps = $makevar{LICENSE_PERMS} // '';
if ($committer && ($tmp =~ /\n(RESTRICTED|NO_CDROM|NO_PACKAGE)[+?]?=/ ||
$lps =~ /\bno-\b/)) {
&perror("WARN", $file, -1, "Possible restrictive licensing found. ".
"If there are, in fact, limitations to use or distribution, please update ports/LEGAL.");
}
if ($tmp =~ /\nNO_PACKAGE[+?]?=/) { if ($tmp =~ /\nNO_PACKAGE[+?]?=/) {
matUnsubmitted
Done
Inline Actions

This should more like error out saying "DON'T USE THAT, USE THE LICENSE FRAMEWORK" ;-)

mat: This should more like error out saying "DON'T USE THAT, USE THE LICENSE FRAMEWORK" ;-)
marcusUnsubmitted
Done
Inline Actions

I'm not sure we should have a warning like this unless there's an action. Since they wouldn't need to touch LEGAL anymore, I think we can leave this whole block out.

marcus: I'm not sure we should have a warning like this unless there's an action. Since they wouldn't…
&perror("WARN", $file, -1, "NO_PACKAGE is obsolete. It should be ". &perror("WARN", $file, -1, "NO_PACKAGE is obsolete. It should be ".
"replaced with \"LICENSE_PERMS=no-pkg-mirror\""); "replaced with \"LICENSE_PERMS=no-pkg-mirror\"");
} }
# check NO_STAGE # check NO_STAGE
if ($makevar{NO_STAGE}) { if ($makevar{NO_STAGE}) {
&perror("FATAL", $file, -1, "STAGE support is missing."); &perror("FATAL", $file, -1, "STAGE support is missing.");
} }
▲ Show 20 Lines • Show All 484 Lines • Show Last 20 Lines