Changeset View
Changeset View
Standalone View
Standalone View
sys/kern/vfs_default.c
Show First 20 Lines • Show All 57 Lines • ▼ Show 20 Lines | |||||
#include <sys/dirent.h> | #include <sys/dirent.h> | ||||
#include <sys/poll.h> | #include <sys/poll.h> | ||||
#include <sys/stat.h> | #include <sys/stat.h> | ||||
#include <security/audit/audit.h> | #include <security/audit/audit.h> | ||||
#include <sys/priv.h> | #include <sys/priv.h> | ||||
#include <security/mac/mac_framework.h> | #include <security/mac/mac_framework.h> | ||||
#include <vm/vm.h> | #include <vm/vm.h> | ||||
kib: Why is this needed? | |||||
#include <vm/vm_object.h> | #include <vm/vm_object.h> | ||||
#include <vm/vm_extern.h> | #include <vm/vm_extern.h> | ||||
#include <vm/pmap.h> | #include <vm/pmap.h> | ||||
#include <vm/vm_map.h> | #include <vm/vm_map.h> | ||||
#include <vm/vm_page.h> | #include <vm/vm_page.h> | ||||
#include <vm/vm_pager.h> | #include <vm/vm_pager.h> | ||||
#include <vm/vnode_pager.h> | #include <vm/vnode_pager.h> | ||||
▲ Show 20 Lines • Show All 1,270 Lines • ▼ Show 20 Lines | vfs_stdstatfs (mp, sbp) | ||||
struct mount *mp; | struct mount *mp; | ||||
struct statfs *sbp; | struct statfs *sbp; | ||||
{ | { | ||||
return (EOPNOTSUPP); | return (EOPNOTSUPP); | ||||
} | } | ||||
int | int | ||||
vfs_stdquotactl (mp, cmds, uid, arg) | vfs_stdquotactl (mp, cmds, uid, arg, mp_busy) | ||||
struct mount *mp; | struct mount *mp; | ||||
int cmds; | int cmds; | ||||
uid_t uid; | uid_t uid; | ||||
void *arg; | void *arg; | ||||
bool *mp_busy; | |||||
{ | { | ||||
return (EOPNOTSUPP); | return (EOPNOTSUPP); | ||||
} | } | ||||
int | int | ||||
vfs_stdsync(mp, waitfor) | vfs_stdsync(mp, waitfor) | ||||
Done Inline ActionsInstead of doubling down on the existing approach, would it be worthwhile to change the interface to VFS_QUOTACTL() so that it takes a "bool *mp_busy" param that allows the implementation to indicate whether the mount busy state was changed? That's not pretty, but it seems a bit more robust than what we have now. jah: Instead of doubling down on the existing approach, would it be worthwhile to change the… | |||||
Not Done Inline Actionsbool **mp_busy perhaps? kib: bool **mp_busy perhaps?
Yes it sounds much better than the current code. In fact, current code… | |||||
struct mount *mp; | struct mount *mp; | ||||
int waitfor; | int waitfor; | ||||
{ | { | ||||
struct vnode *vp, *mvp; | struct vnode *vp, *mvp; | ||||
struct thread *td; | struct thread *td; | ||||
int error, lockreq, allerror = 0; | int error, lockreq, allerror = 0; | ||||
td = curthread; | td = curthread; | ||||
▲ Show 20 Lines • Show All 258 Lines • Show Last 20 Lines |
Why is this needed?