Changeset View
Standalone View
sys/netinet/tcp_ratelimit.h
Context not available. | |||||
struct tcp_hwrate_limit_table { | struct tcp_hwrate_limit_table { | ||||
const struct tcp_rate_set *ptbl; /* Pointer to parent table */ | const struct tcp_rate_set *ptbl; /* Pointer to parent table */ | ||||
struct m_snd_tag *tag; /* Send tag if needed (chelsio) */ | struct m_snd_tag *tag; /* Send tag if needed (chelsio) */ | ||||
uint64_t rate; /* Rate we get in Bytes per second (Bps) */ | long rate; /* Rate we get in Bytes per second (Bps) */ | ||||
long using; /* How many flows are using this hdwr rate. */ | |||||
kbowling: should it be here? | |||||
Done Inline ActionsI am not understanding your comment. Maybe you are referring to the comment "Temporary".. and yeah The thing I thought, when I put it in, that it was just a nice temp for debugging. But I have found when rrs: I am not understanding your comment. Maybe you are referring to the comment "Temporary".. and… | |||||
long rs_num_enobufs; | |||||
Not Done Inline ActionsWhy do you change it from uint64_t to long? tuexen: Why do you change it from uint64_t to long? | |||||
Done Inline Actionsuint64_t breaks with 32 bit platforms. This code was yanked after the The other limit is in using, but 2 billion connections using a rate is a bit So I think its an ok compromise though it will be better when the 32 bit rrs: uint64_t breaks with 32 bit platforms. This code was yanked after the
ratelimit changes went in… | |||||
Not Done Inline ActionsThen I'm fine with the changes. Go ahead and commit them. tuexen: Then I'm fine with the changes. Go ahead and commit them. | |||||
uint32_t time_between; /* Time-Gap between packets at this rate */ | uint32_t time_between; /* Time-Gap between packets at this rate */ | ||||
uint32_t flags; | uint32_t flags; | ||||
}; | }; | ||||
Context not available. |
should it be here?