Page MenuHomeFreeBSD
Differential D29468 Diff 86430 sys/netpfil/pf/pf_lb.c

Changeset View

Standalone View

View Options

sys/netpfil/pf/pf_lb.c

Context not available.
if (pf_map_addr(af, r, saddr, naddr, &init_addr, sn)) if (pf_map_addr(af, r, saddr, naddr, &init_addr, sn))
return (1); return (1);
if (proto == IPPROTO_ICMP) {
low = 1;
high = 65535;
}
bzero(&key, sizeof(key)); bzero(&key, sizeof(key));
key.af = af; key.af = af;
key.proto = proto; key.proto = proto;
Context not available.
return (1); /* none available */ return (1); /* none available */
} }
static int
pf_get_mape_sport(sa_family_t af, u_int8_t proto, struct pf_krule *r,
struct pf_addr *saddr, uint16_t sport, struct pf_addr *daddr,
uint16_t dport, struct pf_addr *naddr, uint16_t *nport,
struct pf_ksrc_node **sn)
{
uint16_t psmask, low, highmask;
uint16_t i, ahigh, cut;
int ashift, psidshift;
ashift = 16 - r->rpool.mape.offset;
psidshift = ashift - r->rpool.mape.psidlen;
psmask = r->rpool.mape.psid & ((1U << r->rpool.mape.psidlen) - 1);
psmask = psmask << psidshift;
highmask = (1U << psidshift) - 1;
ahigh = (1U << r->rpool.mape.offset) - 1;
cut = arc4random() & ahigh;
if (cut == 0)
cut = 1;
for (i = cut; i < ahigh; i++) {
takahiro.kurosawa_gmail.comAuthorUnsubmitted
Done
Inline Actions

i < ahigh should be i <= ahigh.
The line 320 subtract 1 so ahigh should be inclusive.
I will fix the code.

takahiro.kurosawa_gmail.com: `i < ahigh` should be `i <= ahigh`. The line 320 subtract 1 so ahigh should be inclusive. I…
low = (i << ashift) | psmask;
if (!pf_get_sport(af, proto, r, saddr, sport, daddr, dport,
naddr, nport, low, low | highmask, sn))
return (0);
}
for (i = cut - 1; i > 0; i--) {
low = (i << ashift) | psmask;
if (!pf_get_sport(af, proto, r, saddr, sport, daddr, dport,
naddr, nport, low, low | highmask, sn))
return (0);
}
return (1);
}
int int
pf_map_addr(sa_family_t af, struct pf_krule *r, struct pf_addr *saddr, pf_map_addr(sa_family_t af, struct pf_krule *r, struct pf_addr *saddr,
struct pf_addr *naddr, struct pf_addr *init_addr, struct pf_ksrc_node **sn) struct pf_addr *naddr, struct pf_addr *init_addr, struct pf_ksrc_node **sn)
Context not available.
struct pf_krule *r = NULL; struct pf_krule *r = NULL;
struct pf_addr *naddr; struct pf_addr *naddr;
uint16_t *nport; uint16_t *nport;
uint16_t low, high;
PF_RULES_RASSERT(); PF_RULES_RASSERT();
KASSERT(*skp == NULL, ("*skp not NULL")); KASSERT(*skp == NULL, ("*skp not NULL"));
Context not available.
switch (r->action) { switch (r->action) {
case PF_NAT: case PF_NAT:
if (pf_get_sport(pd->af, pd->proto, r, saddr, sport, daddr, if (pd->proto == IPPROTO_ICMP) {
dport, naddr, nport, r->rpool.proxy_port[0], low = 1;
r->rpool.proxy_port[1], sn)) { high = 65535;
} else {
low = r->rpool.proxy_port[0];
high = r->rpool.proxy_port[1];
}
if (r->rpool.mape.offset > 0) {
if (pf_get_mape_sport(pd->af, pd->proto, r, saddr,
sport, daddr, dport, naddr, nport, sn)) {
DPFPRINTF(PF_DEBUG_MISC,
("pf: MAP-E port allocation (%u/%u/%u)"
" failed\n",
r->rpool.mape.offset,
r->rpool.mape.psidlen,
r->rpool.mape.psid));
goto notrans;
}
} else if (pf_get_sport(pd->af, pd->proto, r, saddr, sport,
daddr, dport, naddr, nport, low, high, sn)) {
DPFPRINTF(PF_DEBUG_MISC, DPFPRINTF(PF_DEBUG_MISC,
("pf: NAT proxy port allocation (%u-%u) failed\n", ("pf: NAT proxy port allocation (%u-%u) failed\n",
r->rpool.proxy_port[0], r->rpool.proxy_port[1])); r->rpool.proxy_port[0], r->rpool.proxy_port[1]));
Context not available.