Changeset View
Changeset View
Standalone View
Standalone View
sys/dev/ice/if_ice_iflib.c
/* SPDX-License-Identifier: BSD-3-Clause */ | /* SPDX-License-Identifier: BSD-3-Clause */ | ||||
/* Copyright (c) 2020, Intel Corporation | /* Copyright (c) 2021, Intel Corporation | ||||
* All rights reserved. | * All rights reserved. | ||||
* | * | ||||
* Redistribution and use in source and binary forms, with or without | * Redistribution and use in source and binary forms, with or without | ||||
* modification, are permitted provided that the following conditions are met: | * modification, are permitted provided that the following conditions are met: | ||||
* | * | ||||
* 1. Redistributions of source code must retain the above copyright notice, | * 1. Redistributions of source code must retain the above copyright notice, | ||||
* this list of conditions and the following disclaimer. | * this list of conditions and the following disclaimer. | ||||
* | * | ||||
▲ Show 20 Lines • Show All 1,477 Lines • ▼ Show 20 Lines | ice_if_msix_intr_assign(if_ctx_t ctx, int msix) | ||||
for (i = 0, vector = 1; i < vsi->num_rx_queues; i++, vector++) { | for (i = 0, vector = 1; i < vsi->num_rx_queues; i++, vector++) { | ||||
struct ice_rx_queue *rxq = &vsi->rx_queues[i]; | struct ice_rx_queue *rxq = &vsi->rx_queues[i]; | ||||
struct ice_tx_queue *txq = &vsi->tx_queues[i]; | struct ice_tx_queue *txq = &vsi->tx_queues[i]; | ||||
int rid = vector + 1; | int rid = vector + 1; | ||||
char irq_name[16]; | char irq_name[16]; | ||||
snprintf(irq_name, sizeof(irq_name), "rxq%d", i); | snprintf(irq_name, sizeof(irq_name), "rxq%d", i); | ||||
err = iflib_irq_alloc_generic(ctx, &sc->irqvs[vector].irq, rid, | err = iflib_irq_alloc_generic(ctx, &sc->irqvs[vector].irq, rid, | ||||
IFLIB_INTR_RXTX, ice_msix_que, | IFLIB_INTR_RXTX, ice_msix_que, | ||||
kbowling: is this change away from RXTX intentional? | |||||
Done Inline ActionsOn first glance, I can't think of why we would have changed it. I'll have to look into that. erj: On first glance, I can't think of why we would have changed it. I'll have to look into that. | |||||
Done Inline ActionsAnd on second glance, it's because I didn't notice that https://reviews.freebsd.org/D27683 didn't get committed (because I was out on vacation / IntelNetworking wasn't on there), so it didn't get pulled into our development code. So, I'll probably revert it back to RXTX. erj: And on second glance, it's because I didn't notice that https://reviews.freebsd.org/D27683… | |||||
rxq, rxq->me, irq_name); | rxq, rxq->me, irq_name); | ||||
if (err) { | if (err) { | ||||
device_printf(sc->dev, | device_printf(sc->dev, | ||||
"Failed to allocate q int %d err: %s\n", | "Failed to allocate q int %d err: %s\n", | ||||
i, ice_err_str(err)); | i, ice_err_str(err)); | ||||
vector--; | vector--; | ||||
i--; | i--; | ||||
goto fail; | goto fail; | ||||
▲ Show 20 Lines • Show All 1,429 Lines • Show Last 20 Lines |
is this change away from RXTX intentional?