Changeset View
Changeset View
Standalone View
Standalone View
sys/net/if.c
Show First 20 Lines • Show All 2,702 Lines • ▼ Show 20 Lines | case SIOCSIFNAME: | ||||
EVENTHANDLER_INVOKE(ifnet_arrival_event, ifp); | EVENTHANDLER_INVOKE(ifnet_arrival_event, ifp); | ||||
/* Announce the return of the interface. */ | /* Announce the return of the interface. */ | ||||
rt_ifannouncemsg(ifp, IFAN_ARRIVAL); | rt_ifannouncemsg(ifp, IFAN_ARRIVAL); | ||||
ifp->if_flags &= ~IFF_RENAMING; | ifp->if_flags &= ~IFF_RENAMING; | ||||
break; | break; | ||||
case SIOCGIFDNAME: | |||||
error = 0; | |||||
if (ifp->if_dname == NULL || ifp->if_dunit == IF_DUNIT_NONE) { | |||||
error = ENOMSG; | |||||
kp: break;
Then the 'else' isn't needed and the bulk of the code moves one level of indentation… | |||||
} else { | |||||
descrlen = snprintf(new_name, sizeof(new_name), "%s%u", | |||||
ifp->if_dname, ifp->if_dunit); | |||||
if (descrlen < 0) { | |||||
error = ENOMSG; | |||||
break; | |||||
} | |||||
/* space for terminating nul */ | |||||
descrlen++; | |||||
if (ifr_buffer_get_length(ifr) < descrlen) | |||||
ifr_buffer_set_buffer_null(ifr); | |||||
else | |||||
error = copyout(new_name, | |||||
ifr_buffer_get_buffer(ifr), descrlen); | |||||
ifr_buffer_set_length(ifr, descrlen); | |||||
} | |||||
break; | |||||
#ifdef VIMAGE | #ifdef VIMAGE | ||||
case SIOCSIFVNET: | case SIOCSIFVNET: | ||||
error = priv_check(td, PRIV_NET_SETIFVNET); | error = priv_check(td, PRIV_NET_SETIFVNET); | ||||
if (error) | if (error) | ||||
return (error); | return (error); | ||||
error = if_vmove_loan(td, ifp, ifr->ifr_name, ifr->ifr_jid); | error = if_vmove_loan(td, ifp, ifr->ifr_name, ifr->ifr_jid); | ||||
break; | break; | ||||
#endif | #endif | ||||
▲ Show 20 Lines • Show All 1,843 Lines • Show Last 20 Lines |
break;
Then the 'else' isn't needed and the bulk of the code moves one level of indentation down.