Page MenuHomeFreeBSD
Differential D3924 Diff 9459 share/mk/bsd.sys.mk

Changeset View

Standalone View

View Options

share/mk/bsd.sys.mk

Show First 20 Lines • Show All 142 Lines • ▼ Show 20 Lines
# they are treated as system headers, but we explicitly disable that warning # they are treated as system headers, but we explicitly disable that warning
# suppression when building the base system to catch bugs in our headers. # suppression when building the base system to catch bugs in our headers.
# Eventually we'll want to start building the base system C++ code as C++11, # Eventually we'll want to start building the base system C++ code as C++11,
# but not yet. # but not yet.
CXXFLAGS.clang+= -Wno-c++11-extensions CXXFLAGS.clang+= -Wno-c++11-extensions
.if ${MK_SSP} != "no" && \ .if ${MK_SSP} != "no" && \
${MACHINE_CPUARCH} != "arm" && ${MACHINE_CPUARCH} != "mips" ${MACHINE_CPUARCH} != "arm" && ${MACHINE_CPUARCH} != "mips"
.if (${COMPILER_TYPE} == "clang" && ${COMPILER_VERSION} >= 30500) || \
(${COMPILER_TYPE} == "gcc" && \
(${COMPILER_VERSION} == 40201 || ${COMPILER_VERSION} >= 40800))
ngieAuthorUnsubmitted
Done
Inline Actions

40800 is wrong; it needs to be 40804: https://svnweb.freebsd.org/ports/head/lang/gcc48/

ngie: 40800 is wrong; it needs to be 40804: https://svnweb.freebsd.org/ports/head/lang/gcc48/
ngieAuthorUnsubmitted
Not Done
Inline Actions

LGTM:

[ngie@escher ~/svn/freebsd/src/tests/sys/pjdfstest/pjdfstest]$ env CC=clang35 make -VCFLAGS:M-fstack-protector-strong
-fstack-protector-strong
[ngie@escher ~/svn/freebsd/src/tests/sys/pjdfstest/pjdfstest]$ env CC=clang make -VCFLAGS:M-fstack-protector-strong                                                                                         

[ngie@escher ~/svn/freebsd/src/tests/sys/pjdfstest/pjdfstest]$ env CC=gcc47 make -VCFLAGS:M-fstack-protector-strong                                                                                         

[ngie@escher ~/svn/freebsd/src/tests/sys/pjdfstest/pjdfstest]$ env CC=gcc48 make -VCFLAGS:M-fstack-protector-strong                                                                                         
-fstack-protector-strong
[ngie@escher ~/svn/freebsd/src/tests/sys/pjdfstest/pjdfstest]$ env CC=gcc49 make -VCFLAGS:M-fstack-protector-strong                                                                                         
-fstack-protector-strong
[ngie@escher ~/svn/freebsd/src/tests/sys/pjdfstest/pjdfstest]$ env CC=gcc make -VCFLAGS:M-fstack-protector-strong
-fstack-protector-strong
[ngie@escher ~/svn/freebsd/src/tests/sys/pjdfstest/pjdfstest]$ env CC=clang36 make -VCFLAGS:M-fstack-protector-strong                                                                                       
-fstack-protector-strong
[ngie@escher ~/svn/freebsd/src/tests/sys/pjdfstest/pjdfstest]$ env CC=clang37 make -VCFLAGS:M-fstack-protector-strong                                                                                       
-fstack-protector-strong
ngie: LGTM: ``` [ngie@escher ~/svn/freebsd/src/tests/sys/pjdfstest/pjdfstest]$ env CC=clang35 make…
# Don't use -Wstack-protector as it breaks world with -Werror. # Don't use -Wstack-protector as it breaks world with -Werror.
SSP_CFLAGS?= -fstack-protector-strong SSP_CFLAGS?= -fstack-protector-strong
CFLAGS+= ${SSP_CFLAGS} CFLAGS+= ${SSP_CFLAGS}
.endif
.endif # SSP && !ARM && !MIPS .endif # SSP && !ARM && !MIPS
# Allow user-specified additional warning flags, plus compiler specific flag overrides. # Allow user-specified additional warning flags, plus compiler specific flag overrides.
# Unless we've overriden this... # Unless we've overriden this...
.if ${MK_WARNS} != "no" .if ${MK_WARNS} != "no"
CFLAGS+= ${CWARNFLAGS} ${CWARNFLAGS.${COMPILER_TYPE}} CFLAGS+= ${CWARNFLAGS} ${CWARNFLAGS.${COMPILER_TYPE}}
.endif .endif
▲ Show 20 Lines • Show All 123 Lines • Show Last 20 Lines