Page MenuHomeFreeBSD
Differential D24566 Diff 78615 contrib/elftoolchain/libelf/Version.map

Changeset View

Standalone View

View Options

contrib/elftoolchain/libelf/Version.map

/* $Id: Version.map 2574 2012-09-11 15:11:59Z jkoshy $ */ /* $Id: Version.map 2574 2012-09-11 15:11:59Z jkoshy $ */
R1.0 { R1.0 {
global: global:
elf32_checksum; elf32_checksum;
elf32_fsize; elf32_fsize;
elf32_getehdr; elf32_getehdr;
elf32_getphdr; elf32_getphdr;
elf32_getshdr; elf32_getshdr;
elf32_newehdr; elf32_newehdr;
elf32_newphdr; elf32_newphdr;
elf32_xlatetof; elf32_xlatetof;
elf32_xlatetom; elf32_xlatetom;
elf64_checksum; elf64_checksum;
elf64_fsize; elf64_fsize;
elf64_getehdr; elf64_getehdr;
markjUnsubmitted
Done
Inline Actions

Shouldn't the added symbols go into a new namespace?

markj: Shouldn't the added symbols go into a new namespace?
emasteUnsubmitted
Done
Inline Actions

Indeed - this will be the first time we've added new symbols, it seems.

The version is arbitrary and not coupled to the elftoolchain release version, so will probably be R1.1.
Look at e.g. lib/libcxxrt/Version.map for an example of how the inheritance works.

emaste: Indeed - this will be the first time we've added new symbols, it seems. The version is…
markjUnsubmitted
Done
Inline Actions

So R1.1 will be the FreeBSD 13.0 ABI I suppose, and we'd just keep incrementing the minor number once per release, if necessary.

markj: So R1.1 will be the FreeBSD 13.0 ABI I suppose, and we'd just keep incrementing the minor…
elf64_getphdr; elf64_getphdr;
elf64_getshdr; elf64_getshdr;
elf64_newehdr; elf64_newehdr;
elf64_newphdr; elf64_newphdr;
elf64_xlatetof; elf64_xlatetof;
elf64_xlatetom; elf64_xlatetom;
elf_begin; elf_begin;
elf_cntl; elf_cntl;
▲ Show 20 Lines • Show All 61 Lines • ▼ Show 20 Linesglobal:
gelf_update_rel; gelf_update_rel;
gelf_update_rela; gelf_update_rela;
gelf_update_shdr; gelf_update_shdr;
gelf_update_sym; gelf_update_sym;
gelf_update_syminfo; gelf_update_syminfo;
gelf_update_symshndx; gelf_update_symshndx;
gelf_xlatetof; gelf_xlatetof;
gelf_xlatetom; gelf_xlatetom;
};
R1.1 {
global:
elf32_getchdr;
elf64_getchdr;
gelf_getchdr;
local: local:
*; *;
markjUnsubmitted
Done
Inline Actions

I believe the local block should stay in the R1.0 namespace.

markj: I believe the `local` block should stay in the R1.0 namespace.
tig_freebsdfoundation.orgAuthorUnsubmitted
Done
Inline Actions

The first example here: https://people.freebsd.org/~deischen/symver/freebsd_versioning.txt moved local to child namespace.

tig_freebsdfoundation.org: The first example here: https://people.freebsd.org/~deischen/symver/freebsd_versioning.txt…
markjUnsubmitted
Done
Inline Actions

I see. Really, it shouldn't matter which namespace that label goes in since the referenced symbols are not externally visible anyway. It just seemed a bit strange to move the local label each time a new version is defined, and that guide doesn't explain why they moved to the new version. In any case I'm fine just leaving this bit as it is.

markj: I see. Really, it shouldn't matter which namespace that label goes in since the referenced…
tig_freebsdfoundation.orgAuthorUnsubmitted
Done
Inline Actions

I thought it was a bit strange too but I followed its format anyway because it was the only reference I had. I'll mark this as done.

tig_freebsdfoundation.org: I thought it was a bit strange too but I followed its format anyway because it was the only…
}; } R1.0;