Changeset View
Changeset View
Standalone View
Standalone View
sys/sys/eventfd.h
- This file was added.
#ifndef _SYS_EVENTFD_H_ | |||||
markj: Missing a copyright header. | |||||
val_packett.coolUnsubmitted Done Inline ActionsWith these trivial API headers, I don't even know who should have the copyright. I can put myself I guess.. val_packett.cool: With these trivial API headers, I don't even know who should have the copyright. I can put… | |||||
#define _SYS_EVENTFD_H_ | |||||
#include <sys/types.h> | |||||
#include <sys/fcntl.h> | |||||
typedef uint64_t eventfd_t; | |||||
#define EFD_SEMAPHORE (1 << 0) | |||||
#define EFD_CLOEXEC O_CLOEXEC | |||||
Done Inline Actions
I wonder why Illumus did it like this. With a native syscall I would expect EFD_CLOEXEC == O_CLOEXEC and for the Linux compat layer to do a translation between LINUX_EFD_CLOEXEC and the "native" EFD_CLOEXEC. Similar for EFD_NONBLOCK. That way the Linux constants don't leak out unnecessarily. jan.kokemueller_gmail.com: > EFD_* flags are using Linux values of CLOEXEC and NONBLOCK to avoid extra conversions on the… | |||||
Done Inline ActionsBTW using octal for constants is very unusual for FreeBSD. kib: BTW using octal for constants is very unusual for FreeBSD. | |||||
#define EFD_NONBLOCK O_NONBLOCK | |||||
#ifdef _KERNEL | |||||
struct thread; | |||||
int eventfd_create(struct thread *td, uint32_t initval, int flags); | |||||
#else | |||||
#include <sys/cdefs.h> | |||||
__BEGIN_DECLS | |||||
int eventfd(unsigned int initval, int flags); | |||||
int eventfd_read(int fd, eventfd_t *value); | |||||
int eventfd_write(int fd, eventfd_t value); | |||||
__END_DECLS | |||||
#endif /* !_KERNEL */ | |||||
#endif /* !_SYS_EVENTFD_H_ */ | |||||
Done Inline ActionsThis include is excessive. sys/types.h already includes cdefs.h (as well as almost all other important headers). kib: This include is excessive. sys/types.h already includes cdefs.h (as well as almost all other… |
Missing a copyright header.