Changeset View
Standalone View
security/libressl/Makefile
| # Created by: Vsevolod Stakhov <vsevolod@FreeBSD.org> | # Created by: Vsevolod Stakhov <vsevolod@FreeBSD.org> | ||||
| # $FreeBSD$ | # $FreeBSD$ | ||||
| PORTNAME= libressl | PORTNAME= libressl | ||||
| PORTVERSION= 2.2.3 | PORTVERSION= 2.2.3 | ||||
| CATEGORIES= security devel | CATEGORIES= security devel | ||||
| MASTER_SITES= OPENBSD/LibreSSL | MASTER_SITES= OPENBSD/LibreSSL | ||||
| MAINTAINER= vsevolod@FreeBSD.org | MAINTAINER= vsevolod@FreeBSD.org | ||||
| COMMENT= Free version of the SSL/TLS protocol forked from OpenSSL | COMMENT= Free version of the SSL/TLS protocol forked from OpenSSL | ||||
| LICENSE= BSD4CLAUSE | LICENSE= BSD4CLAUSE | ||||
| LICENSE_FILE= ${WRKSRC}/COPYING | LICENSE_FILE= ${WRKSRC}/COPYING | ||||
| CPE_VENDOR= openbsd | CPE_VENDOR= openbsd | ||||
| CONFLICTS?= openssl-[0-9]* | OPTIONS_DEFINE= MAN3 | ||||
| OPTIONS_DEFAULT= MAN3 | |||||
| MAN3_DESC= Install API manpages (section 3) | |||||
| CONFLICTS?= openssl-[0-9]* \ | |||||
koobs: I'm not sure I like the addition of a non-standard MAN option (ie; those that users can disable… | |||||
Done Inline ActionsWell, first of all it is already possible to not install *all* the manpages. But I, and I'm sure there are many others, do want the single man1 page (openssl.1), but do not need the over 1,000 man3 pages (1,451 to be exact) that are only for people programming against the library. What you're talking about is removing the single manpage that normal admins need to run (and to which the FreeBSD Handbook recommends referring in the certificate creation article!), just "for completeness." The average user and admin has use for the openssl.1 manpage. The average user and admin has no use for the 1,451 API manpages. For what its worth, security/openssl just did the same thing in a different way: OPTIONS_DEFINE= MAN3
OPTIONS_DEFAULT=MAN3
MAN3_DESC= Install API manpages (section 3)
post-install-MAN3-off:
${RM} -rf ${STAGEDIR}/${PREFIX}/man/man3
${REINPLACE_CMD} -e '/^man\/man3/d' ${TMPPLIST}adamw: Well, first of all it is already possible to not install *all* the manpages.
But I, and I'm… | |||||
Done Inline ActionsI will refactor the patch to align with the OpenSSL method. brnrd: I will refactor the patch to align with the OpenSSL method. | |||||
| libressl-devel-[0-9]* | |||||
| GNU_CONFIGURE= yes | GNU_CONFIGURE= yes | ||||
Done Inline ActionsPlease mention that we should add mutual conflict for these ports. However, even in this case it won't work as expected, since tcltls likely depends on an SSL library. Therefore, I would recommend to patch tcltls to hide its tls.h file somehow. vsevolod: Please mention that we should add mutual conflict for these ports. However, even in this case… | |||||
Done Inline ActionsAgreed. This recivion should include adding (mutual) CONFLICTS in those ports too. Also, are these only CONFLICTS_INSTALL or CONFLICTS (build *and* install) ? koobs: Agreed. This recivion should include adding (mutual) CONFLICTS in those ports too.
Also, are… | |||||
Done Inline ActionsWill look at that next brnrd: Will look at that next | |||||
brnrdAuthorUnsubmitted Not Done Inline ActionsThere's now a maintainer-approved patch for devel/tcltls see D3695 brnrd: There's now a maintainer-approved patch for devel/tcltls see D3695 | |||||
| CONFIGURE_ARGS= --enable-silent-rules | CONFIGURE_ARGS= --enable-silent-rules | ||||
Done Inline ActionsI don't understand the point. Why not use the default silent rules value? vsevolod: I don't understand the point. Why not use the default silent rules value? | |||||
Done Inline ActionsThis was on my recommendation/request that the default should be verbose, particularly on cluster/package builders. This ensures that compiler flag/invocation issues (duplicate flags, honouring {c,ld}flags, etc) can be seen and fixed). Long term, the ports framework should do this. koobs: This was on my recommendation/request that the default should be verbose, particularly on… | |||||
Not Done Inline ActionsApart from the typo, done. disable--silent -> disable-slient brnrd: Apart from the typo, done. `disable--silent` -> `disable-slient` | |||||
| USES= cpe libtool pathfix pkgconfig | USES= cpe libtool pathfix pkgconfig | ||||
| USE_LDCONFIG= yes | USE_LDCONFIG= yes | ||||
| INSTALL_TARGET= install-strip | INSTALL_TARGET= install-strip | ||||
Done Inline ActionsI'm not sure if it is safe to do it this way. I need to check it carefully in terms of a possible security impact. vsevolod: I'm not sure if it is safe to do it this way. I need to check it carefully in terms of a… | |||||
Done Inline ActionsAlso, your itemized changes (log message) does *not* mention this change, or why/intention it is changing koobs: Also, your itemized changes (log message) does *not* mention this change, or why/intention it… | |||||
Not Done Inline ActionsRemoved for now. This was intended to fix the conflict between arc4random in base and in the port. Base arc4random is already OK in 11. brnrd: Removed for now. This was intended to fix the conflict between arc4random in base and in the… | |||||
| .include <bsd.port.pre.mk> | .include <bsd.port.pre.mk> | ||||
| .if ${ARCH} == "amd64" | .if ${ARCH} == "amd64" | ||||
| CONFIGURE_TARGET= x86_64-portbld-${OPSYS:tl}${OSREL} | CONFIGURE_TARGET= x86_64-portbld-${OPSYS:tl}${OSREL} | ||||
| .endif | .endif | ||||
| regression-test: build | regression-test: build | ||||
| cd ${WRKSRC} && ${MAKE} check | cd ${WRKSRC} && ${MAKE} check | ||||
| #post-install-MAN3-off: | |||||
| # ${RM} -rf ${STAGEDIR}/${PREFIX}/man/man3 | |||||
| # ${REINPLACE_CMD} -e '/^man\/man3/d' ${TMPPLIST} | |||||
adamwUnsubmitted Done Inline ActionsDid you want to uncomment the post-install-MAN3-off target? adamw: Did you want to uncomment the post-install-MAN3-off target?
| |||||
brnrdAuthorUnsubmitted Not Done Inline ActionsYes. This has now been fixed. brnrd: Yes. This has now been fixed. | |||||
| .include <bsd.port.post.mk> | .include <bsd.port.post.mk> | ||||
I'm not sure I like the addition of a non-standard MAN option (ie; those that users can disable in make.conf, etc).