Changeset View
Changeset View
Standalone View
Standalone View
lib/lib9p/Makefile
- This file was added.
# $FreeBSD$ | |||||
# Note: to turn on debug, use -DL9P_DEBUG=L9P_DEBUG, | |||||
# and set env variable LIB9P_LOGGING to stderr or to | |||||
# the (preferably full path name of) the debug log file. | |||||
CFLAGS+= -DWITH_CASPER -I${.CURDIR} | |||||
DEBUG_FLAGS= -DL9P_DEBUG=L9P_DEBUG -DACE_DEBUG -g -O0 | |||||
jhb: You probably don't want to override DEBUG_FLAGS here and let it by the default of '-g'. When… | |||||
emasteUnsubmitted Not Done Inline Actionsstill need to address that comment emaste: still need to address that comment | |||||
rgrimesUnsubmitted Not Done Inline ActionsI would just delete this line which addresses the concern quickly and allows this review to move forward unless there is some great reason that this debug stuff is needed in the production code. rgrimes: I would just delete this line which addresses the concern quickly and allows this review to… | |||||
Not Done Inline Actions-DWITH_CASPER repeated twice, and odd combination of -D and -I on the same line in one case and separate lines in other case. I would probably put the two -I entries on one line and -D on its own. emaste: `-DWITH_CASPER` repeated twice, and odd combination of -D and -I on the same line in one case… | |||||
Not Done Inline ActionsSuggested replacement for lines 4 to 6 that I think would take care of Ed's comment: CFLAGS+= -DWITH_CASPER CFLAGS+= -I${.CURDIR} CFLAGS+= -I${.CURDIR}/../../contrib/lib9p rgrimes: Suggested replacement for lines 4 to 6 that I think would take care of Ed's comment:
```… | |||||
LIB= 9p | |||||
PACKAGE= lib${LIB} | |||||
SHLIB_MAJOR= 1 | |||||
SHLIBDIR?= /lib | |||||
SRCS= connection.c \ | |||||
genacl.c \ | |||||
hashtable.c \ | |||||
log.c \ | |||||
pack.c \ | |||||
request.c \ | |||||
rfuncs.c \ | |||||
threadpool.c \ | |||||
utils.c \ | |||||
backend/fs.c \ | |||||
Done Inline Actionssort these? emaste: sort these? | |||||
Done Inline Actionsstill unsorted emaste: still unsorted | |||||
transport/socket.c | |||||
INCSDIR= ${INCLUDEDIR}/lib9p | |||||
INCS= fid.h lib9p.h backend/fs.h | |||||
LIBADD= sbuf | |||||
cscope: .PHONY | |||||
cd ${.CURDIR}; cscope -buq $$(find . -name '*.[ch]' -print) | |||||
.include <bsd.lib.mk> |
You probably don't want to override DEBUG_FLAGS here and let it by the default of '-g'. When are the cases when you would want L9P_DEBUG and ACE_DEBUG defined vs not? For example, do you want them always on (add them to CFLAGS), do you only want them enabled on HEAD (similar to MALLOC_PRODUCTION), or do you want to have a new makefile variable to turn them on for people hacking on lib9p directly but not on by default?