Differential D24246 Diff 70083 en_US.ISO8859-1/articles/committers-guide/article.xml

Changeset View

Standalone View

en_US.ISO8859-1/articles/committers-guide/article.xml

Show First 20 Lines • Show All 2,427 Lines • ▼ Show 20 Lines	<tbody>

<row>		<row>
<entry><literal>ports</literal></entry>		<entry><literal>ports</literal></entry>
<entry><filename>ports/svnadmin/conf/mentors</filename></entry>		<entry><filename>ports/svnadmin/conf/mentors</filename></entry>
</row>		</row>
</tbody>		</tbody>
</tgroup>		</tgroup>
</informaltable>		</informaltable>

		<para>New committers should aim to complete enough commits that
		their mentor is comfortable releasing them from mentorship
		within the first year. If they are still under mentorship, the
		impUnsubmitted Done Inline Actions space after under here. imp: space after under here.
		appropriate management body (core, doceng, or portmgr) should
		attempt to ensure that there are no barriers preverting
		bcrUnsubmitted Done Inline Actions s/preverting/preventing/ bcr: s/preverting/preventing/
		completion. If the committer is unable to satisfy their mentor
		impUnsubmitted Done Inline Actions s/complete/completion/ maybe? imp: s/complete/completion/ maybe?
		of readyness by a year and a half their commit bit should be
		jhbUnsubmitted Not Done Inline Actions Maybe s/should/will? jhb: Maybe s/should/will?
		converted to project membership.</para>
</sect2>		</sect2>
</sect1>		</sect1>

<sect1 xml:id="pre-commit-review">		<sect1 xml:id="pre-commit-review">
<title>Pre-Commit Review</title>		<title>Pre-Commit Review</title>

<para>Code review is one way to increase the quality of software.		<para>Code review is one way to increase the quality of software.
The following guidelines apply to commits to the		The following guidelines apply to commits to the
▲ Show 20 Lines • Show All 3,207 Lines • Show Last 20 Lines