Changeset View
Changeset View
Standalone View
Standalone View
sys/amd64/vmm/vmm_snapshot.c
- This file was added.
/*- | |||||
* SPDX-License-Identifier: BSD-2-Clause-FreeBSD | |||||
* | |||||
* Copyright (c) 2016 Flavius Anton | |||||
* Copyright (c) 2016 Mihai Tiganus | |||||
* Copyright (c) 2016-2019 Mihai Carabas | |||||
* Copyright (c) 2017-2019 Darius Mihai | |||||
* Copyright (c) 2017-2019 Elena Mihailescu | |||||
* Copyright (c) 2018-2019 Sergiu Weisz | |||||
* All rights reserved. | |||||
jhb: For local variables, we can just use 'op' without leading underscores. FreeBSD generally only… | |||||
Done Inline ActionsRenamed the variable. darius.mihaim_gmail.com: Renamed the variable. | |||||
* The bhyve-snapshot feature was developed under sponsorships | |||||
* from Matthew Grooms. | |||||
* | |||||
* Redistribution and use in source and binary forms, with or without | |||||
* modification, are permitted provided that the following conditions | |||||
* are met: | |||||
* 1. Redistributions of source code must retain the above copyright | |||||
* notice, this list of conditions and the following disclaimer. | |||||
* 2. Redistributions in binary form must reproduce the above copyright | |||||
* notice, this list of conditions and the following disclaimer in the | |||||
* documentation and/or other materials provided with the distribution. | |||||
* | |||||
* THIS SOFTWARE IS PROVIDED BY NETAPP, INC ``AS IS'' AND | |||||
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | |||||
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE | |||||
* ARE DISCLAIMED. IN NO EVENT SHALL NETAPP, INC OR CONTRIBUTORS BE LIABLE | |||||
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL | |||||
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS | |||||
Not Done Inline ActionsMaybe use __DEVOLATILE instead: void *_data; _data = __DEVOLATILE(void *, data); Maybe to avoid the leading underscore you could call the function parameter 'datav' and the local variable in the function 'data'. Alternatively, if there are not many volatile pointers being passed to this function, the volatile could just be removed and __DEVOLATILE could be used in callers in the places where it is needed. jhb: Maybe use __DEVOLATILE instead:
```
void *_data;
_data = __DEVOLATILE(void *, data)… | |||||
Done Inline ActionsUsed __DEVOLATILE here to be safe and keep the compatibility (same parameters and return type) with the functions used in userspace. darius.mihaim_gmail.com: Used __DEVOLATILE here to be safe and keep the compatibility (same parameters and return type)… | |||||
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) | |||||
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT | |||||
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY | |||||
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF | |||||
* SUCH DAMAGE. | |||||
* | |||||
* $FreeBSD$ | |||||
*/ | |||||
#include <sys/types.h> | |||||
#include <sys/systm.h> | |||||
#include <machine/vmm_snapshot.h> | |||||
void | |||||
vm_snapshot_buf_err(const char *bufname, const enum vm_snapshot_op op) | |||||
{ | |||||
const char *opstr; | |||||
if (op == VM_SNAPSHOT_SAVE) | |||||
opstr = "save"; | |||||
else if (op == VM_SNAPSHOT_RESTORE) | |||||
opstr = "restore"; | |||||
else | |||||
opstr = "unknown"; | |||||
printf("%s: snapshot-%s failed for %s\r\n", __func__, opstr, bufname); | |||||
} | |||||
int | |||||
vm_snapshot_buf(volatile void *data, size_t data_size, | |||||
struct vm_snapshot_meta *meta) | |||||
{ | |||||
struct vm_snapshot_buffer *buffer; | |||||
int op; | |||||
void *nv_data; | |||||
nv_data = __DEVOLATILE(void *, data); | |||||
buffer = &meta->buffer; | |||||
op = meta->op; | |||||
if (buffer->buf_rem < data_size) { | |||||
printf("%s: buffer too small\r\n", __func__); | |||||
return (E2BIG); | |||||
} | |||||
if (op == VM_SNAPSHOT_SAVE) | |||||
copyout(nv_data, buffer->buf, data_size); | |||||
else if (op == VM_SNAPSHOT_RESTORE) | |||||
copyin(buffer->buf, nv_data, data_size); | |||||
else | |||||
return (EINVAL); | |||||
buffer->buf += data_size; | |||||
buffer->buf_rem -= data_size; | |||||
return (0); | |||||
} | |||||
size_t | |||||
vm_get_snapshot_size(struct vm_snapshot_meta *meta) | |||||
{ | |||||
size_t length; | |||||
struct vm_snapshot_buffer *buffer; | |||||
buffer = &meta->buffer; | |||||
if (buffer->buf_size < buffer->buf_rem) { | |||||
printf("%s: Invalid buffer: size = %zu, rem = %zu\r\n", | |||||
__func__, buffer->buf_size, buffer->buf_rem); | |||||
length = 0; | |||||
} else { | |||||
length = buffer->buf_size - buffer->buf_rem; | |||||
} | |||||
return (length); | |||||
} | |||||
int | |||||
vm_snapshot_buf_cmp(volatile void *data, size_t data_size, | |||||
struct vm_snapshot_meta *meta) | |||||
{ | |||||
struct vm_snapshot_buffer *buffer; | |||||
int op; | |||||
int ret; | |||||
void *_data = *(void **)(void *)&data; | |||||
buffer = &meta->buffer; | |||||
op = meta->op; | |||||
if (buffer->buf_rem < data_size) { | |||||
printf("%s: buffer too small\r\n", __func__); | |||||
ret = E2BIG; | |||||
goto done; | |||||
} | |||||
if (op == VM_SNAPSHOT_SAVE) { | |||||
ret = 0; | |||||
copyout(_data, buffer->buf, data_size); | |||||
} else if (op == VM_SNAPSHOT_RESTORE) { | |||||
ret = memcmp(_data, buffer->buf, data_size); | |||||
} else { | |||||
ret = EINVAL; | |||||
goto done; | |||||
} | |||||
buffer->buf += data_size; | |||||
buffer->buf_rem -= data_size; | |||||
done: | |||||
return (ret); | |||||
} |
For local variables, we can just use 'op' without leading underscores. FreeBSD generally only uses leading underscores for global symbols that are not part of the public API.