Page MenuHomeFreeBSD
Differential D21915 Diff 68888 x11-toolkits/py-wxPython40/Makefile

Changeset View

Standalone View

View Options

x11-toolkits/py-wxPython40/Makefile

# $FreeBSD$ # $FreeBSD$
PORTNAME= wxPython PORTNAME= wxPython
PORTVERSION= 3.0.2.0 PORTVERSION= 4.0.7
PORTREVISION= 8
DISTVERSIONPREFIX= src-
CATEGORIES= x11-toolkits python CATEGORIES= x11-toolkits python
MASTER_SITES= SF/wxpython/wxPython/${PORTVERSION} MASTER_SITES= CHEESESHOP
PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
PKGNAMESUFFIX= 30 PKGNAMESUFFIX= 40
DIST_SUBDIR= python
MAINTAINER= python@FreeBSD.org MAINTAINER= python@FreeBSD.org
COMMENT= GUI toolkit for the Python programming language COMMENT= GUI toolkit for the Python programming language
DIST_SUBDIR= python LICENSE= WXWINDOWS LGPL21+ GPLv2+
LICENSE_COMB= multi
LICENSE_NAME_WXWINDOWS= wxWindows Library Licence, Version 3.1
LICENSE_FILE_WXWINDOWS= ${WRKSRC}/license/licence.txt
LICENSE_PERMS_WXWINDOWS= dist-mirror pkg-mirror auto-accept
WRKSRC_SUBDIR= wxPython BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}pathlib2>0:devel/py-pathlib2@${PY_FLAVOR}
USES= compiler:c++11-lib python:2.7 shebangfix tar:bzip2 USES= compiler:c++11-lib gl localbase pkgconfig python
SHEBANG_FILES= wx/tools/Editra/Editra.pyw USE_GL= glu
koobsUnsubmitted
Done
Inline Actions

Is this correct?
Does it need to be updated?
What parts, if any, of the WX ports framework elements need to be updated?

I see your comment in the revision summary "but I think that we need to modify also Mk/bsd.wx.mk."

koobs: Is this correct? Does it need to be updated? What parts, if any, of the WX ports framework…
lbartolettiAuthorUnsubmitted
Done
Inline Actions

Is this correct?

Yes, wxPython40 requires wx-widgets 3.0 AFAIK no one uses 3.1 yet.

I see your comment in the revision summary "but I think that we need to modify also Mk/bsd.wx.mk."

Yes, as I had asked on IRC who was taking care of that, because, I don't really understand why there are two ports (wxPythonX and wxPythonX-common) per version.

This new port, it's the only one allowing to offer wxwidgets in python3 (and requested by the new version of databases/grass7 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241892)

For the wx ports framework, I didn't modify it because I don't know how much I have to modify it to include this new port.

In my example on databases/grass7, I don't use the variable

USE_WX=3.0
WX_COMPS=wx:build python:run

but

RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}wxPython40>=0:x11-toolkits/py-wxPython40@${PY_FLAVOR}

I think that wxPython40 sould be callable within Mk/bsd.wx.mk, but how?

Should we replace py- wxPython30 by py-wxPython40 for wxgtk30 like this

_WX_PORT_python_3.0=	x11-toolkits/py-wxPython40
_WX_FILE_python_3.0=	${PYTHON_SITELIBDIR}/wx-3.0-gtk3/wx/__init__.py

Or, is it necessary to add something else to choose the version of wxPython (3 or 4) for wxWidgets (3.0). Knowing, that only wxPython40 is available for python3.

Maybe we need to integrate this port first and then run an exp-run by depreciating wxPython30 by wxPython40 and see the result?

lbartoletti: > Is this correct? Yes, wxPython40 requires wx-widgets 3.0 AFAIK no one uses 3.1 yet. > I see…
lbartolettiAuthorUnsubmitted
Done
Inline Actions

I tried to build ports where wxPython30 was required with wxPython40 and all built successfully

lbartoletti: I tried to build ports where wxPython30 was required with wxPython40 and all built successfully
lbartolettiAuthorUnsubmitted
Done
Inline Actions

(except emulators/playonbsd stage-qa for shebang errors and sysutils/hachoir-wx unfetchable)

lbartoletti: (except emulators/playonbsd stage-qa for shebang errors and sysutils/hachoir-wx unfetchable)
lbartolettiAuthorUnsubmitted
Done
Inline Actions

erg no sorry for the false positive alert... need a second try with wxPython40 instead of wxPython30

lbartoletti: erg no sorry for the false positive alert... need a second try with wxPython40 instead of…
.if defined(WITH_WXVERSION_ONLY)
PKGNAMESUFFIX= -common
USE_PYTHON= py3kplist flavors
do-build:
${PYTHON_CMD} ${PYTHON_LIBDIR}/compileall.py -d ${PYTHON_SITELIBDIR} -f ${WRKSRC}/wxversion
${PYTHON_CMD} -O ${PYTHON_LIBDIR}/compileall.py -d ${PYTHON_SITELIBDIR} -f ${WRKSRC}/wxversion
do-install:
@${MKDIR} ${STAGEDIR}${PYTHON_SITELIBDIR}
${INSTALL_DATA} ${WRKSRC}/wxversion/wxversion.py* ${STAGEDIR}${PYTHON_SITELIBDIR}/
${TOUCH} ${STAGEDIR}${PYTHON_SITELIBDIR}/wx.pth
.else
WXPORT= gtk3
WX_PYTHON_DIR= wx-${WX_VERSION}-${WXPORT}
RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}wxPython-common>0:x11-toolkits/py-wxPython-common@${PY_FLAVOR}
USES+= gettext pkgconfig
USE_WX= 3.0 USE_WX= 3.0
USE_PYTHON= distutils autoplist USE_PYTHON= distutils autoplist
PYDISTUTILS_BUILDARGS= WX_CONFIG="${WX_CONFIG}" \
WXPORT="${WXPORT}" \
NO_SCRIPTS=1 \
INSTALL_MULTIVERSION=1
PYDISTUTILS_CONFIGUREARGS+= ${PYDISTUTILS_BUILDARGS}
PYDISTUTILS_INSTALLARGS+= ${PYDISTUTILS_BUILDARGS}
OPTIONS_DEFINE= NLS
NLS_USES= gettext
post-patch: post-patch:
@${REINPLACE_CMD} -E \ @${REINPLACE_CMD} -e "s|WX_CONFIG = 'wx-config'|WX_CONFIG = '${WX_CONFIG}'|" ${WRKSRC}/build.py
koobsUnsubmitted
Done
Inline Actions

Can this be passed in as an environment variable of setup.py build argument? Preferable over patching.

koobs: Can this be passed in as an environment variable of setup.py build argument? Preferable over…
lbartolettiAuthorUnsubmitted
Done
Inline Actions

AFAIK, no. I tried with PYDISTUTILS_BUILDARGS= WX_CONFIG=${WX_CONFIG} but there is no effect on the variable.
All linux distributions make this substitution. I'm going to open a ticket upstream.

lbartoletti: AFAIK, no. I tried with PYDISTUTILS_BUILDARGS= WX_CONFIG=${WX_CONFIG} but there is no effect on…
lbartolettiAuthorUnsubmitted
Done
Inline Actions

koobs@ FYI, I opened an issue upstream

lbartoletti: koobs@ FYI, I opened an issue upstream
-e 's,distutils\.command\.install\.install\),setuptools.command.install.install),g' \
-e 's,distutils\.command\.install$$,setuptools.command.install,g' \
-e 's,distutils\.command\.install\.install\.,setuptools.command.install.install.,g' \
${WRKSRC}/config.py
post-install: post-install:
@${ECHO_CMD} "@unexec ${REINPLACE_CMD} -i '' -e '\,${WX_PYTHON_DIR}$$,d' ${PYTHON_SITELIBDIR}/wx.pth 2>/dev/null || true" >> ${TMPPLIST} ${FIND} ${STAGEDIR}${PYTHON_SITELIBDIR}/wx -name *.so -exec ${STRIP_CMD} {} +
@${ECHO_CMD} "@exec echo ${WX_PYTHON_DIR} >> ${PYTHON_SITELIBDIR}/wx.pth 2>/dev/null || true" >> ${TMPPLIST}
.endif
.include <bsd.port.mk> .include <bsd.port.mk>