Changeset View
Changeset View
Standalone View
Standalone View
Mk/Scripts/qa.sh
#!/bin/sh | #!/bin/sh | ||||
# MAINTAINER: portmgr@FreeBSD.org | # MAINTAINER: portmgr@FreeBSD.org | ||||
# $FreeBSD$ | # $FreeBSD$ | ||||
if [ -z "${STAGEDIR}" -o -z "${PREFIX}" -o -z "${LOCALBASE}" ]; then | if [ -z "${STAGEDIR}" -o -z "${PREFIX}" -o -z "${LOCALBASE}" ]; then | ||||
echo "STAGEDIR, PREFIX, LOCALBASE required in environment." >&2 | echo "STAGEDIR, PREFIX, LOCALBASE required in environment." >&2 | ||||
mat: Not sure this change is needed. We're only checking for the 3 most important variables. And… | |||||
exit 1 | exit 1 | ||||
fi | fi | ||||
[ -n "${DEBUG_MK_SCRIPTS}" -o -n "${DEBUG_MK_SCRIPTS_QA}" ] && set -x | [ -n "${DEBUG_MK_SCRIPTS}" -o -n "${DEBUG_MK_SCRIPTS_QA}" ] && set -x | ||||
LF=$(printf '\nX') | LF=$(printf '\nX') | ||||
LF=${LF%X} | LF=${LF%X} | ||||
▲ Show 20 Lines • Show All 984 Lines • ▼ Show 20 Lines | if [ -f "${message}" ]; then | ||||
warn "See https://www.freebsd.org/doc/en/books/porters-handbook/pkg-files.html#porting-message" | warn "See https://www.freebsd.org/doc/en/books/porters-handbook/pkg-files.html#porting-message" | ||||
fi | fi | ||||
fi | fi | ||||
done | done | ||||
return 0 | return 0 | ||||
} | } | ||||
reinplace() | |||||
{ | |||||
if [ -f ${REWARNFILE} ]; then | |||||
warn "Possible REINPLACE_CMD issues" | |||||
cat ${REWARNFILE} | |||||
fi | |||||
} | |||||
checks="shebang symlinks paths stripped desktopfileutils sharedmimeinfo" | checks="shebang symlinks paths stripped desktopfileutils sharedmimeinfo" | ||||
checks="$checks suidfiles libtool libperl prefixvar baselibs terminfo" | checks="$checks suidfiles libtool libperl prefixvar baselibs terminfo" | ||||
checks="$checks proxydeps sonames perlcore no_arch gemdeps gemfiledeps flavors" | checks="$checks proxydeps sonames perlcore no_arch gemdeps gemfiledeps flavors" | ||||
checks="$checks license depends_blacklist pkgmessage" | checks="$checks license depends_blacklist pkgmessage reinplace" | ||||
ret=0 | ret=0 | ||||
cd ${STAGEDIR} || exit 1 | cd ${STAGEDIR} || exit 1 | ||||
for check in ${checks}; do | for check in ${checks}; do | ||||
${check} || ret=1 | ${check} || ret=1 | ||||
done | done | ||||
exit ${ret} | exit ${ret} |
Not sure this change is needed. We're only checking for the 3 most important variables. And even then, qa.sh is only run from one place, where those three variables are always defined.
In any way, REWARNFILE is always added to the environment in bsd.port.mk, so I feel this is not needed.