Changeset View
Standalone View
x11/nvidia-hybrid-graphics/Makefile
| # $FreeBSD$ | |||||
| PORTNAME= nvidia-hybrid-graphics | |||||
| MASTERDIR= ${.CURDIR}/../nvidia-headless-utils | |||||
| COMMENT= NVIDIA headless (discrete GPU) graphics acceleration - AKA Optimus | |||||
| RUN_DEPENDS= nvidia-headless-utils>=0.3:x11/nvidia-headless-utils \ | |||||
| nvidia-headless-driver>=390.87:x11/nvidia-headless-driver \ | |||||
monwarez_mailoo.org: here (and in headless-utils) having a run depend on nvidia-headless-driver will force the… | |||||
theron.tarigo_gmail.comAuthorUnsubmitted Done Inline ActionsThanks. Is using FLAVORS for such small variations (that need to be packaged) no longer controversial? If I understand https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/flavors-using.html correctly, this is an intended use (the flavor would be "390" or "legacy") This seems preferable to either creating more slave port directories or removing the dependency, which would allow installation of a useless hybrid-graphics package and foreseeably cause user frustration (despite a warning in pkg-message). theron.tarigo_gmail.com: Thanks. Is using FLAVORS for such small variations (that need to be packaged) no longer… | |||||
| ${LOCALBASE}/VirtualGL/bin/vglrun:x11/virtualgl \ | |||||
| nvidia-settings:x11/nvidia-settings | |||||
| DESCR= ${.CURDIR}/pkg-descr | |||||
Done Inline ActionsI'm a bit obscured by RUN_DEPENDS= nvidia-headless-utils and using nvidia-headless-utils as MASTERDIR at the same time. Why is this port a slave at all? arrowd: I'm a bit obscured by `RUN_DEPENDS= nvidia-headless-utils` and using `nvidia-headless-utils` as… | |||||
Done Inline ActionsI had the two separate ports for two different use-cases:
I thought for the headless case, dependency on a particular nvidia driver version and VirtualGL are extraneous. The hybrid case is a strict superset of what is needed for headless. It's still a slave port since there is only one github repository for all this. theron.tarigo_gmail.com: I had the two separate ports for two different use-cases:
- Headless graphics. Only the bare… | |||||
Done Inline Actions
I think, yes. arrowd: > Probably I should abandon "headless-utils" and just make it an option of hybrid-graphics… | |||||
| PLIST= ${.CURDIR}/pkg-plist | |||||
| SUB_FILES= | |||||
| USE_RC_SUBR= | |||||
| OPTIONS_DEFINE= OPTIRUN | |||||
| OPTIONS_DEFAULT= OPTIRUN | |||||
| OPTIONS_SUB= OPTIRUN | |||||
| OPTIRUN_DESC= Install "optirun" alias for nvrun-vgl | |||||
| post-install-OPTIRUN-on: | |||||
| @${RLN} ${STAGEDIR}${PREFIX}/bin/nvrun-vgl \ | |||||
| ${STAGEDIR}${PREFIX}/bin/optirun | |||||
| .include "${MASTERDIR}/Makefile" | |||||
Done Inline ActionsYou should be using x_IMPLIES instead: 5.13.3.7. OPT_IMPLIES mat: You should be using x_IMPLIES instead: [[https://docs.freebsd.org/en/books/porters… | |||||
Done Inline ActionsAs VIRTUALGL is required by OPTIRUN, this is not needed. mat: As VIRTUALGL is required by OPTIRUN, this is not needed. | |||||
here (and in headless-utils) having a run depend on nvidia-headless-driver will force the install of the latest nvidia driver which will prevent legacy driver user to install nvidia-hybrid-graphics.
To this I see two solutions: not depending on the nvidia driver so that user can choose the version, or having a slave port with the version like for nvidia-headless-driver